All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Daniel P. Berrangé" <berrange@redhat.com>
To: John Snow <jsnow@redhat.com>
Cc: qemu-devel@nongnu.org,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>,
	"Vladimir Sementsov-Ogievskiy" <vsementsov@yandex-team.ru>,
	"Kevin Wolf" <kwolf@redhat.com>,
	"Maksim Davydov" <davydov-max@yandex-team.ru>,
	"Li-Wen Hsu" <lwhsu@freebsd.org>,
	"Markus Armbruster" <armbru@redhat.com>,
	"Thomas Huth" <thuth@redhat.com>,
	"Mauro Carvalho Chehab" <mchehab+huawei@kernel.org>,
	"Hanna Reitz" <hreitz@redhat.com>,
	"Cleber Rosa" <crosa@redhat.com>,
	"Michael Roth" <michael.roth@amd.com>,
	"Yonggang Luo" <luoyonggang@gmail.com>,
	"Ed Maste" <emaste@freebsd.org>, "Peter Xu" <peterx@redhat.com>,
	"Fabiano Rosas" <farosas@suse.de>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	qemu-block@nongnu.org,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>,
	"Alex Bennée" <alex.bennee@linaro.org>
Subject: Re: [PATCH v4 08/17] tests/lcitool: add python3 wheel and setuptools deps for qemu
Date: Tue, 20 Jan 2026 08:55:30 +0000	[thread overview]
Message-ID: <aW9DAktwCICK8dwv@redhat.com> (raw)
In-Reply-To: <20260119212744.1275455-9-jsnow@redhat.com>

On Mon, Jan 19, 2026 at 04:27:34PM -0500, John Snow wrote:
> Installing local dependencies while offline, without PyPI access,
> requires the python3-setuptools and python3-wheel packages. Most
> distributions have these available anyway for one reason or another, but
> not all of them.
> 
> If you are asking yourself "Wait, aren't these packages guaranteed via
> installation of pip, via the ensurepip module, which mkvenv takes
> immense pains to provide for us?" - Well... since Python 3.13, "pip"
> does not actually come with "setuptools" or "wheel" anymore, and so if
> we want to build and install a python package, we actually need these
> available in the host environment.
> 
> (Note that you don't need these packages just to install a pre-built
> package, you only need them to *build* a package. With cutting edge
> setuptools and pip, all locally installed packages, even in editable
> mode, must be "built" first before being installed. Thus, these
> dependencies are being added specifically to facilitate installing
> qemu.git/python/qemu to the configure-time venv.)
> 
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
>  .gitlab-ci.d/cirrus/freebsd-14.vars     | 2 +-
>  .gitlab-ci.d/cirrus/macos-14.vars       | 2 +-
>  .gitlab-ci.d/windows.yml                | 2 ++
>  tests/docker/dockerfiles/alpine.docker  | 2 ++
>  tests/docker/dockerfiles/centos9.docker | 2 ++
>  tests/lcitool/projects/qemu.yml         | 2 ++
>  tests/vm/generated/freebsd.json         | 2 ++
>  7 files changed, 12 insertions(+), 2 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|



  parent reply	other threads:[~2026-01-20  8:56 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-19 21:27 [PATCH v4 00/17] python: drop qemu.qmp from qemu.git tree John Snow
2026-01-19 21:27 ` [PATCH v4 01/17] python/mkvenv: create timestamp file for each group "ensured" John Snow
2026-01-19 21:27 ` [PATCH v4 02/17] python/mkvenv: bump 'qemu.qmp' dependency for testdeps John Snow
2026-01-19 21:27 ` [PATCH v4 03/17] python/mkvenv: add 'tooling' and 'functests' dependency groups John Snow
2026-01-20  6:05   ` Vladimir Sementsov-Ogievskiy
2026-01-20  8:41   ` Thomas Huth
2026-01-20  8:47   ` Daniel P. Berrangé
2026-01-19 21:27 ` [PATCH v4 04/17] python/mkvenv: add mechanism to install local package(s) John Snow
2026-01-19 21:27 ` [PATCH v4 05/17] meson, mkvenv: add functests custom target John Snow
2026-01-20  8:53   ` Daniel P. Berrangé
2026-01-20 17:27     ` John Snow
2026-01-20 17:33       ` Daniel P. Berrangé
2026-01-20 17:37         ` John Snow
2026-01-19 21:27 ` [PATCH v4 06/17] tests: Use configured python to run GitLab iotests John Snow
2026-01-20  8:45   ` Thomas Huth
2026-01-20  8:54   ` Daniel P. Berrangé
2026-01-19 21:27 ` [PATCH v4 07/17] tests: use "run" script to execute device-crash-test John Snow
2026-01-20  8:46   ` Thomas Huth
2026-01-20  8:54   ` Daniel P. Berrangé
2026-01-19 21:27 ` [PATCH v4 08/17] tests/lcitool: add python3 wheel and setuptools deps for qemu John Snow
2026-01-20  8:52   ` Thomas Huth
2026-01-20  8:55   ` Daniel P. Berrangé [this message]
2026-01-19 21:27 ` [PATCH v4 09/17] python: add vendored qemu.qmp package John Snow
2026-01-19 21:27 ` [PATCH v4 10/17] meson, mkvenv: make functional tests depend on functests group John Snow
2026-01-20  8:57   ` Daniel P. Berrangé
2026-01-20  8:57   ` Thomas Huth
2026-01-19 21:27 ` [PATCH v4 11/17] meson, mkvenv: add qemu.git/python/qemu package to pythondeps.toml John Snow
2026-01-19 21:27 ` [PATCH v4 12/17] configure: unconditionally install "tooling" group John Snow
2026-01-20  8:59   ` Daniel P. Berrangé
2026-01-20  9:00   ` Thomas Huth
2026-01-19 21:27 ` [PATCH v4 13/17] tests: remove "make check-venv" target John Snow
2026-01-20  9:01   ` Daniel P. Berrangé
2026-01-19 21:27 ` [PATCH v4 14/17] scripts: nudge users to use 'run' script for scripts that import qemu.qmp John Snow
2026-01-20  9:02   ` Daniel P. Berrangé
2026-01-19 21:27 ` [PATCH v4 15/17] python: delete qemu.qmp John Snow
2026-01-19 21:27 ` [PATCH v4 16/17] python: update README.rst to reflect qemu.qmp's removal John Snow
2026-01-20  9:05   ` Daniel P. Berrangé
2026-01-20 18:08     ` John Snow
2026-01-19 21:27 ` [PATCH v4 17/17] RFC: exclude pyvenv targets from "make check-build" John Snow
2026-01-20 18:27 ` [PATCH v4 00/17] python: drop qemu.qmp from qemu.git tree John Snow

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aW9DAktwCICK8dwv@redhat.com \
    --to=berrange@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=armbru@redhat.com \
    --cc=crosa@redhat.com \
    --cc=davydov-max@yandex-team.ru \
    --cc=emaste@freebsd.org \
    --cc=farosas@suse.de \
    --cc=hreitz@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=luoyonggang@gmail.com \
    --cc=lwhsu@freebsd.org \
    --cc=marcandre.lureau@redhat.com \
    --cc=mchehab+huawei@kernel.org \
    --cc=michael.roth@amd.com \
    --cc=pbonzini@redhat.com \
    --cc=peterx@redhat.com \
    --cc=philmd@linaro.org \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    --cc=vsementsov@yandex-team.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.