From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 736F0D2ECF7 for ; Tue, 20 Jan 2026 09:01:56 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vi7cR-0005kq-7v; Tue, 20 Jan 2026 04:01:47 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vi7cH-0005gj-DQ for qemu-devel@nongnu.org; Tue, 20 Jan 2026 04:01:37 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vi7cD-0000eg-Sp for qemu-devel@nongnu.org; Tue, 20 Jan 2026 04:01:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1768899692; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZCTU6hahMkQjruzdNp+O1Q88h/i90daJz4HMEwgg9rY=; b=CpRXCGonrGddZtVM9O5JAnWA8vR2IH3LLPCc6APePdNPRmutpbo2RaEZwipQra8a02Q6Sm Bdah0qMBxo2eDT57Qb1pV42UAO6JRDlpW8wtqYRsolKphtqkabQFBj51/l+ppS9npg1TqS HQlY1VtAtVERpcz5/3xEn7PQBzeHxOE= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-317-6ZaBV5yGN7CLfZLaTJvrUw-1; Tue, 20 Jan 2026 04:01:29 -0500 X-MC-Unique: 6ZaBV5yGN7CLfZLaTJvrUw-1 X-Mimecast-MFC-AGG-ID: 6ZaBV5yGN7CLfZLaTJvrUw_1768899687 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id B1D9319560A6; Tue, 20 Jan 2026 09:01:27 +0000 (UTC) Received: from redhat.com (unknown [10.42.28.89]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 0620C1800285; Tue, 20 Jan 2026 09:01:22 +0000 (UTC) Date: Tue, 20 Jan 2026 09:01:19 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: John Snow Cc: qemu-devel@nongnu.org, =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , Vladimir Sementsov-Ogievskiy , Kevin Wolf , Maksim Davydov , Li-Wen Hsu , Markus Armbruster , Thomas Huth , Mauro Carvalho Chehab , Hanna Reitz , Cleber Rosa , Michael Roth , Yonggang Luo , Ed Maste , Peter Xu , Fabiano Rosas , Paolo Bonzini , qemu-block@nongnu.org, Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Alex =?utf-8?Q?Benn=C3=A9e?= Subject: Re: [PATCH v4 13/17] tests: remove "make check-venv" target Message-ID: References: <20260119212744.1275455-1-jsnow@redhat.com> <20260119212744.1275455-14-jsnow@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260119212744.1275455-14-jsnow@redhat.com> User-Agent: Mutt/2.2.14 (2025-02-20) X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.016, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Mon, Jan 19, 2026 at 04:27:39PM -0500, John Snow wrote: > With the qemu.qmp and qemu.machine dependencies now installed by default > at configure time and additional dependencies required by functional > testing installed on demand, there is no longer any reason to have an > explicit target. > > FIXME: This forces image regeneration for vm tests whenever Make > determines that the image needs to be rebuilt; which is a regression > over the previous behavior. > > Signed-off-by: John Snow > --- > tests/Makefile.include | 22 ++-------------------- > tests/vm/Makefile.include | 24 +++++++----------------- > 2 files changed, 9 insertions(+), 37 deletions(-) Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|