All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yao Zi <me@ziyao.cc>
To: Georg Gottleuber <ggo@tuxedocomputers.com>,
	"Russell King (Oracle)" <linux@armlinux.org.uk>
Cc: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
	kuba@kernel.org, pabeni@redhat.com, Frank.Sae@motor-comm.com,
	hkallweit1@gmail.com, vladimir.oltean@nxp.com, wens@csie.org,
	jszhang@kernel.org, 0x1207@gmail.com,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
	jeffbai@aosc.io, kexybiscuit@aosc.io,
	Christoffer Sandberg <cs@tuxedocomputers.com>
Subject: Re: [PATCH RESEND net-next v6 0/3] Add DWMAC glue driver for Motorcomm YT6801
Date: Tue, 20 Jan 2026 11:52:07 +0000	[thread overview]
Message-ID: <aW9sZwDpQu88BRPG@pie> (raw)
In-Reply-To: <1be6caa4-abbd-4f3b-8c63-b637f0f9ed15@tuxedocomputers.com>

On Tue, Jan 20, 2026 at 10:42:28AM +0100, Georg Gottleuber wrote:
> 
> 
> Am 20.01.26 um 03:45 schrieb Yao Zi:
> > On Mon, Jan 19, 2026 at 06:57:48PM +0100, Georg Gottleuber wrote:
> >> Am 19.01.26 um 18:45 schrieb Georg Gottleuber:
> >>> Hi,
> >>>
> >>> thanks for the quick reply.
> >>>
> >>> Am 19.01.26 um 16:43 schrieb Russell King (Oracle):
> >>>> On Mon, Jan 19, 2026 at 04:33:17PM +0100, Georg Gottleuber wrote:
> >>>>> Hi,
> >>>>>
> >>>>> I tested this driver with our TUXEDO InfinityBook Pro AMD Gen9. Iperf
> >>>>> revealed that tx is only 100Mbit/s:
> >>>>>
> >>> ...
> >>>>>
> >>>>> With our normally used DKMS module, Ethernet works with full-duplex and
> >>>>> gigabit. Attached are some logs from lspci and dmesg. Do you have any
> >>>>> idea how I can debug this further?
> >>>>
> >>>> My suggestion would be:
> >>>>
> >>>> - Look at the statistics, e.g.
> >>>>
> >>>>    ip -s li sh dev enp2s0
> >>>
> >>> That looks good (after iperf):
> >>>
> >>> 2: enp2s0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc mq state UP
> >>> mode DEFAULT group default qlen 1000
> >>>     link/ether ba:90:88:24:49:4f brd ff:ff:ff:ff:ff:ff
> >>>     RX:  bytes packets errors dropped  missed   mcast
> >>>        2091654   31556      0       0       0       0
> >>>     TX:  bytes packets errors dropped carrier collsns
> >>>       88532451    1518      0       0       0       0
> >>>
> >>>
> >>>> - apply
> >>>>   https://lore.kernel.org/r/E1vgtBc-00000005D6v-040n@rmk-PC.armlinux.org.uk
> >>>>   to enable more statistics to work, and check the network driver
> >>>>   statistics:
> >>>>
> >>>>    ethtool --statistics enp2s0
> >>>>
> >>>> to see if there's any clues for what is going on.
> >>>
> >>> That looks also good, I think. I saved it before and after the test with
> >>> iperf. See attachments.
> >>
> >> Oh, there was something else interesting in dmesg. See attachment.
> >>
> >>> Regards,
> >>> Georg
> > 
> >> [    0.933480] dwmac-motorcomm 0000:02:00.0: error -ENOENT: failed to read maca0lr from eFuse
> >> [    0.933483] dwmac-motorcomm 0000:02:00.0: eFuse contains no valid MAC address
> >> [    0.933485] dwmac-motorcomm 0000:02:00.0: fallback to random MAC address
> > 
> > Some vendors didn't write a MAC address to the eFuse. With these YT6801
> > chips, the failure is expected.
> 
> I believe we have a fixed address, as our DKMS driver always uses it (it
> is also displayed in the BIOS).
> 
> > Which DKMS driver do you use? Could you read out a permanent address
> > with your DKMS driver? If not, this piece of log should have nothing to
> > do with the rate problem.
> 
> DKMS module we use:
> https://gitlab.com/tuxedocomputers/development/packages/tuxedo-yt6801
> 
> Apparently, your driver can also read the permanent address. I rebooted
> nine times to test it, and it worked nine times. So it was probably a
> glitch that doesn't occur very often.

Thanks for the hint. I'm sure I've encountered similar cases once or
twice during development, but it stopped happening later, so I
considered it's somehow fixed. I'll test more and see what's going wrong
here.

> 
> Do you have any ideas on how I can further debug the rate problem?

Sadly I don't have any good suggestions. The Motorcomm glue is
mysterious and totally undocumented, so it's hard to find out what's
missing or wrong. I had to debug the driver by modifying this and vendor
driver and then comparing behavior differences.

Do you build the driver into the kernel, or as a module? I'll try to
reproduce your case locally and investigate it, but as a hobbyist I
cannot make any promises, really sorry about it.

Best regards,
Yao Zi

  reply	other threads:[~2026-01-20 11:53 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-09  9:34 [PATCH RESEND net-next v6 0/3] Add DWMAC glue driver for Motorcomm YT6801 Yao Zi
2026-01-09  9:34 ` [PATCH RESEND net-next v6 1/3] net: phy: motorcomm: Support YT8531S PHY in YT6801 Ethernet controller Yao Zi
2026-01-09 10:06   ` Russell King (Oracle)
2026-01-09  9:34 ` [PATCH RESEND net-next v6 2/3] net: stmmac: Add glue driver for Motorcomm YT6801 ethernet controller Yao Zi
2026-01-12  6:10   ` Sai Krishna Gajula
2026-01-12  7:51     ` Yao Zi
2026-01-12 10:17     ` Russell King (Oracle)
2026-01-09  9:34 ` [PATCH RESEND net-next v6 3/3] MAINTAINERS: Assign myself as maintainer of Motorcomm DWMAC glue driver Yao Zi
2026-01-13  3:30 ` [PATCH RESEND net-next v6 0/3] Add DWMAC glue driver for Motorcomm YT6801 patchwork-bot+netdevbpf
2026-01-19 15:33   ` Georg Gottleuber
2026-01-19 15:43     ` Russell King (Oracle)
2026-01-19 17:45       ` Georg Gottleuber
2026-01-19 17:57         ` Georg Gottleuber
2026-01-20  2:45           ` Yao Zi
2026-01-20  9:42             ` Georg Gottleuber
2026-01-20 11:52               ` Yao Zi [this message]
2026-01-21  7:10                 ` Xi Ruoyao
2026-04-06  7:44           ` [PATCH net] net: stmmac: dwmac-motorcomm: fix eFUSE MAC address read failure Johan Alvarado
2026-04-06 13:41             ` Andrew Lunn
2026-04-08  1:30             ` patchwork-bot+netdevbpf
2026-04-06  7:44           ` Johan Alvarado
     [not found]           ` <4aaa214c-4286-4c24-ab5c-b17a3a1a8f1e@smtp-relay.sendinblue.com>
2026-04-06 12:42             ` Yao Zi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aW9sZwDpQu88BRPG@pie \
    --to=me@ziyao.cc \
    --cc=0x1207@gmail.com \
    --cc=Frank.Sae@motor-comm.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=cs@tuxedocomputers.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=ggo@tuxedocomputers.com \
    --cc=hkallweit1@gmail.com \
    --cc=jeffbai@aosc.io \
    --cc=jszhang@kernel.org \
    --cc=kexybiscuit@aosc.io \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=vladimir.oltean@nxp.com \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.