From: Gregory Price <gourry@gourry.net>
To: "David Hildenbrand (Red Hat)" <david@kernel.org>
Cc: Hannes Reinecke <hare@suse.de>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
kernel-team@meta.com, osalvador@suse.de,
gregkh@linuxfoundation.org, rafael@kernel.org, dakr@kernel.org,
akpm@linux-foundation.org, lorenzo.stoakes@oracle.com,
Liam.Howlett@oracle.com, vbabka@suse.cz, rppt@kernel.org,
surenb@google.com, mhocko@suse.com
Subject: Re: [RFC PATCH] memory,memory_hotplug: allow restricting memory blocks to zone movable
Date: Fri, 9 Jan 2026 11:41:29 -0500 [thread overview]
Message-ID: <aWEvuS95-7yP-Vc8@gourry-fedora-PF4VCD3F> (raw)
In-Reply-To: <65c246bc-fb10-4cef-8163-3a55bd96f326@kernel.org>
On Thu, Jan 08, 2026 at 03:16:24PM +0100, David Hildenbrand (Red Hat) wrote:
> On 1/8/26 08:31, Hannes Reinecke wrote:
> > On 1/6/26 21:22, David Hildenbrand (Red Hat) wrote:
> > > On 1/6/26 20:59, Gregory Price wrote:
>
> > For hardware-based scenarios memory will always be removed in
> > larger entities (eg the CXL device), and it's always an 'all-or-nothing'
> > scenario; you cannot remove individual memory blocks on a CXL device.
> > So there the memory block abstraction makes less sense, and it
> > would be good to have a single 'knob' to remove the entire CXL
> > device and all memory blocks on it.
> > Sure, it might take some time, but one doesn't need to worry about
> > restoring the original state if the operation on one block fails.
>
> That's not what I was getting at:
>
> offline_and_remove_memory() can be called on large regions, and it properly
> handles whether we have to back out because some offlining failed.
>
> The issue arises once dax would have to call offline_and_remove_memory()
> multiple times, on non-contiguous areas. Of course, we could handle that by
> providing an interface that consumes multiple memory ranges.
>
> For the DAX use case, I thing we'd really want a way to just use
>
> * add_and_online_memory() [does not exist yet, but ppc does something
> similar]
> * offline_and_remove_memory()
>
I'm starting to think this issue is actually the result of bad patterns
in the cxl driver - namely using dax as a path to hotplug sysram.
I suppose either we need a `cxl/dax_region/remove` that handles the
whole operation in one go, or
we want `cxl/region/commit` to handle hot(un)plug as a single action.
tl;dr: Split the dax use case from the sysram use case, and make a
cxl sysram driver directly manage hotplug rather than use dax.
~Gregory
next prev parent reply other threads:[~2026-01-09 16:42 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-05 20:36 [RFC PATCH] memory,memory_hotplug: allow restricting memory blocks to zone movable Gregory Price
2026-01-06 15:05 ` Michal Hocko
2026-01-06 16:53 ` Gregory Price
2026-01-06 19:49 ` Michal Hocko
2026-01-07 12:47 ` Hannes Reinecke
2026-01-07 17:17 ` Michal Hocko
2026-01-07 15:09 ` David Hildenbrand (Red Hat)
2026-01-07 16:00 ` Gregory Price
2026-01-07 17:19 ` Michal Hocko
2026-01-06 15:24 ` David Hildenbrand (Red Hat)
2026-01-06 16:58 ` Gregory Price
2026-01-06 17:52 ` David Hildenbrand (Red Hat)
2026-01-06 18:06 ` Gregory Price
2026-01-06 18:38 ` David Hildenbrand (Red Hat)
2026-01-06 19:59 ` Gregory Price
2026-01-06 20:22 ` David Hildenbrand (Red Hat)
2026-01-08 7:31 ` Hannes Reinecke
2026-01-08 14:16 ` David Hildenbrand (Red Hat)
2026-01-09 16:41 ` Gregory Price [this message]
2026-01-12 7:28 ` Hannes Reinecke
2026-01-12 14:23 ` Gregory Price
2026-01-08 7:21 ` Hannes Reinecke
2026-01-08 7:22 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aWEvuS95-7yP-Vc8@gourry-fedora-PF4VCD3F \
--to=gourry@gourry.net \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=dakr@kernel.org \
--cc=david@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hare@suse.de \
--cc=kernel-team@meta.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=mhocko@suse.com \
--cc=osalvador@suse.de \
--cc=rafael@kernel.org \
--cc=rppt@kernel.org \
--cc=surenb@google.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.