From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from CH5PR02CU005.outbound.protection.outlook.com (mail-northcentralusazon11012014.outbound.protection.outlook.com [40.107.200.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 37253366DCC for ; Fri, 9 Jan 2026 20:19:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.200.14 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767989960; cv=fail; b=N6btAts0SjFHIsgAdTld59q8gnF3pciV1K2KnCquuJ15w2nVDO2lzXspCpA6EN/12OO+t2mVEMOmHUpj1PBgyncCgdo43aHPbQWBFUMZ6xj52+lhiufTm1UYmETKOZrhoGBTCROtdQsMd7Lx9oQ4PEYH+RHuXoqCn4D3jeZFXWo= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767989960; c=relaxed/simple; bh=2/ujk69/yX5fWTIlmwmuwCY68hSzle9DT1sRW9DAp8Q=; h=Date:From:To:Cc:Subject:Message-ID:References:Content-Type: Content-Disposition:In-Reply-To:MIME-Version; b=jjCB/BCoEscirCp9+xG1dRNmJOzjIvRohgnF3lcfbG1FMjpI0Jy2yYFjTPY04x+3hnQomS2JTjgs8qg+F0vIcI1YpfNEpQTyT6ePqwN6L2CWLgzn9qw2jA+FcC80FIu9j2acOAJ7eyfvaidZaH+b0bOyRQVuiVAjPY51D92inMA= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=AEUC3Msb; arc=fail smtp.client-ip=40.107.200.14 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="AEUC3Msb" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=FalyfuO/tvwAoZEc9/EApOKYJ+nLCNPeq++LX6m2EpgZiEaFMitiDBLDEKe7E+agosD7+ZF6n2O1Zs+9U1PP9fGVIKLBsMLZoSBJWxqD1JauJ6i87ETl4YMWcQnj1qQpjdX8/QQfeidHqRXHLAqcc712fJOo7OQAMae+CuZdEqdTRxes+PBWntNjiG/to+j27nU5U5zQWbmVKll1Kv3QCquL1ReOjg7S4+P6+pnTfToLQkqtkiDemEKBypYilwYQghEtyEfINASwHPm6CWydC13m6xdGkZKdcc0+/xHzQ9mjrZbvj7+EWscXNxjw2mjygiGVb2nQo/QNTewwMaKljg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=g46oh6bF3OHUYjWeYSO66CN+cq87zi2mHT5LL+BlkLI=; b=Cv6DEUrMshROppoY6WHeLCLwHlK7+qLfW8IyChDy1K4b5HES1UChotoTv+5lE/nb7iQxWT+jWV2XQywToegsz/WiIxKhdGaFKHLAtqFDqt/00GGB6U+uLYsO5wD+GpoczF0Hp84K1cG7+9368T0ie6cdVUiWiE6nKn3mrgVoKjXghVakr+2/LHn0mS6RUxPIkX1WvI8Z59ntYxvSS4US79EEU9tSXilpa0f5MtJh9BgBBG8MAgWGM/5Jhlzyzz55k8a5kxpwtuQMXUinAgGtx6rcEUZIRMR9GOOE42pPRXHh6JfFPvLKu7PXBxeQjlYFA7j1wxWzUg3RTJCGI5tJRQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=g46oh6bF3OHUYjWeYSO66CN+cq87zi2mHT5LL+BlkLI=; b=AEUC3MsbFkDUiG+1u9w73rAL8EGQ2AiTpl/NBB+aJV+0nsBApQLiclRgEnuvGROClkxjmU0aCk3leWEa5g6ZsOdfmTwkCD7h19JLMRBLxAC18Nzm5yFYuRFSt4hplN8ab9E+gBBySBnkBWbY7+n+xtlFXu8SNnrarIGrkVfDdoRDkMxl8xItng1evcjtndUCwbATIM7UusFBjbxPI95ivO9k6xYKYKODMke+YeIN42oeoAEt3TegU8ZbBd9n2vFfTva/qqb8n1gIbHTTjdodY3bzKRqzypEdmsjLuEhommN3r+nie/l93zBT4m2+bHnn1WNhZv7rt2jznzTcAVtYHg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from PH0PR12MB8800.namprd12.prod.outlook.com (2603:10b6:510:26f::12) by PH7PR12MB6561.namprd12.prod.outlook.com (2603:10b6:510:213::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9499.2; Fri, 9 Jan 2026 20:19:14 +0000 Received: from PH0PR12MB8800.namprd12.prod.outlook.com ([fe80::bdb6:e12f:18b6:2b77]) by PH0PR12MB8800.namprd12.prod.outlook.com ([fe80::bdb6:e12f:18b6:2b77%5]) with mapi id 15.20.9499.003; Fri, 9 Jan 2026 20:19:14 +0000 Date: Fri, 9 Jan 2026 15:19:10 -0500 From: Yury Norov To: Petr Tesarik Cc: Yury Norov , Rasmus Villemoes , Richard Henderson , Matt Turner , Magnus Lindholm , Vineet Gupta , Geert Uytterhoeven , "Maciej W. Rozycki" , Thomas Bogendoerfer , Madhavan Srinivasan , Michael Ellerman , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Chris Zankel , Max Filippov , Patrik Jakobsson , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Robin Murphy , Joerg Roedel , Will Deacon , Jakub Kicinski , Andrew Lunn , "David S. Miller" , Eric Dumazet , Paolo Abeni , Oliver Neukum , Arnd Bergmann , Kuan-Wei Chiu , Andrew Morton , Marcel Holtmann , Johan Hedberg , Luiz Augusto von Dentz , Pablo Neira Ayuso , Florian Westphal , linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 2/2] treewide, bits: use ffs_val() where it is open-coded Message-ID: References: <1ce341045ad0487c66ca21003f9974916aba0bce.1767975412.git.ptesarik@suse.com> <20260109203250.08b6f746@mordecai> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260109203250.08b6f746@mordecai> X-ClientProxiedBy: BN9PR03CA0555.namprd03.prod.outlook.com (2603:10b6:408:138::20) To PH0PR12MB8800.namprd12.prod.outlook.com (2603:10b6:510:26f::12) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR12MB8800:EE_|PH7PR12MB6561:EE_ X-MS-Office365-Filtering-Correlation-Id: 664c7c9d-c471-4d81-0fa6-08de4fbc5baa X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|10070799003|7416014|376014|1800799024|366016; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?xG/TbdtNJB7RGKcy/JdS9P2C5wI5ZUoBvhuDhbn2KMvl3BT9McYCAPfOVdr5?= =?us-ascii?Q?F5ucwKucrcE65hwEgDVC9M16RxMnYajiBHBIpiIRa9OwPty/hYBTTV/J6wYE?= =?us-ascii?Q?/iodowkFBh/VFLjii1FHYJi9SeVit7p9bYblbz36TkITQgBYVNNRRpx4WKrv?= =?us-ascii?Q?cQuXl8oyPbiJj/iWV8PubR16hsX5/v3TMeQYAu1oukj11uWvMbZHeGAtximD?= =?us-ascii?Q?G6VSzxApWr2ceu8UFGPhQlTlconyFBtXlQsDnYCeh8pBKVCcUu0tknX5pZLE?= =?us-ascii?Q?oYqAwuB8vuLYvFeUwniWzQxzUBYYQpDACG7KIDeQ+tmyzf1dNyGktRr0L+xh?= =?us-ascii?Q?vTcuOEnIeULJzm1Fw7wdrbNnPGEAgNIMGT2FflsokdLJe41aGZ9lfV3njbXV?= =?us-ascii?Q?NFzE9aXE1PVcFa/HtGKGN5gHJsSFP1UAb/kWsuk2qNeTIfq59QOo5f3V34sW?= =?us-ascii?Q?khpix95uDTw6VM3JoSPlY5GFP5aTGKqk4y1l5YllVDkZ+88EoBYQWWkSiMQD?= =?us-ascii?Q?6J0Yoe+5rpTjcfeBvLC3ij2L9Z7mQbPjbfL4tncrO35hIZ4HAj2mm/gYj39S?= =?us-ascii?Q?/DgDbyt74UqkBYA4E9OlgrYgvBuOwSti7MaIuVFSnlBVfhsd4ILurdjq2FHm?= =?us-ascii?Q?PmrL4R0Jk2riYnZp6uSPnXO++ruIo5PNl8MIkVrl9JLM1Kfy8n/IbXyckhww?= =?us-ascii?Q?+/X+kZecOuhK4g2FENnjsKory+v1YHQQ93szcN+iXFQZ8ckpTUkDG5T5iIMn?= =?us-ascii?Q?Pyab1hMzuJ5LeJwkC2S4XFO3jF++kmGU9+vxJT3gpHalOWwExMwkambBinJf?= =?us-ascii?Q?qTffIpJfC8w+6t5VYXqjdqXBP8bTgkxqW8tC7c+xYT541eHwfRVok9+LqoUX?= =?us-ascii?Q?38rk3JE1Fyu6KGKjXuX2N1j7eOrmh56JfNGbOTL3QzU4yxjnEAtdsquSxbrL?= =?us-ascii?Q?LMBclAdguXdY8Q0s47umbilSrBggHU1TiIvLqSnsC0tj7VHAWJTpcL6PoNK5?= =?us-ascii?Q?gmf6fzh+F0Pu3XRV8ut6htVMq5GNhVDZwsRRYxLPV1TK/2IEQO6M76l12gNB?= =?us-ascii?Q?UCKllU8QfHAtWo2NfzFlxaZz8NAhnc+D1OxkcJtL4F3GipG4p/dRXI9lmTF7?= =?us-ascii?Q?7yUxv5m9EE5hVfur5YJ/L98PzcNTnonNnEz36lG7gQKs3qr4B5sIpPj7kdsv?= =?us-ascii?Q?5jLUZQQj7irAR339PUP5O8E5MT4v0gaWibldF3pNujWCYxEbcapMiyG2AK+0?= =?us-ascii?Q?e2j0ZNvlmCfBaaiM7mDbpMR2ifHJBc1L2l/0eISoG1e8aHOVv1e7zUEZSERg?= =?us-ascii?Q?yT7PFDyjhVhVOPDS28AqVI22tTeVQLiI1vCEp27EJUkdJWcVGoKZFYmJ9vWW?= =?us-ascii?Q?KWXVs8CP+no0n6xEen4F+6+pQC/sAQqe8OhXYolanjga6klYU4iQtK89O0N0?= =?us-ascii?Q?wUW0LZuVMALhiWjbbZkl2wzWPqJmRvkA?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR12MB8800.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(10070799003)(7416014)(376014)(1800799024)(366016);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?IvA0PpCiNKvafuSQdSwgF4JLeydgeqsQ5EzVJp4JgAdHOn72xX1poaedcNc5?= =?us-ascii?Q?s7q+mLR0QOzbN51iwBOiOa9C1EkJupJ4WoDpNXLB2urCfMWsiWW7idK2r2yS?= =?us-ascii?Q?OBK80OoeGCTy44FSQO5jv2ZLXMvl1zgif1aUXNHEjyHyApFn14VgUj7lIhIO?= =?us-ascii?Q?LsUWzmRxXVpVCCVI6CHotCZfJRrKpTBGS6dNh1GRZY2BhTq/z6X9bGTA/Brv?= =?us-ascii?Q?2KuWYAgTTtDqocZuGLG162mi8RvNCOylR/v/fpb/mIETXOLKNmtM0bPCXtWh?= =?us-ascii?Q?GnRvZ/59hXlkKcsw5jzlUqdbFjtxtlUHL9QzBNBeu03HqmensNxreJlTfTBJ?= =?us-ascii?Q?Y5TbVhVVUr5Q4JfYmuLT5Jrte1Qs6mUlXocS/FemnOjclXJdhwgokmeOwwbg?= =?us-ascii?Q?Hifc//G5y+OBn5ZkrUNRsCNN6VDZYgfVZBiikP9rmO2K4Kzi9SMkt0lztyeA?= =?us-ascii?Q?+TAYFRDnPqwkWxmmUpu/WAs/UGCzUpxRfRGChAfvMovyx8P9N2Vq8x/bPllJ?= =?us-ascii?Q?qmqobGNvZpJdz2ib1kUcwJyVmyY3Rtrm0/cH79c4fwqtpvCqTcOwvoZt5pxN?= =?us-ascii?Q?mhPPWeBvomMJB8VUbLZQlvyCSr3oaAetkH3XJIIh77d3QgNffhDYnuB+ZbQZ?= =?us-ascii?Q?KDq537YXDpiuv+yRXLpbR4HVHxaOQvfiyBJHfkRMXW2DlQituKg99ISkk5kB?= =?us-ascii?Q?GL37v8KUDJuncl8miW3t0iJX1Z//HsL33Gl5guDvI4jlfzrM3ulPEtvHthhX?= =?us-ascii?Q?LFyaB82JYd1KELFrBLEuY+St0ue78zCQ8LCzybLaBjHBI4uvWSgftKE+J4fx?= =?us-ascii?Q?domwplNJZoThVFOulVn/O37GjXe9tIny+14VRDbl6kIWlwrJxMg9JyNG8Rdb?= =?us-ascii?Q?nu53Y65PSlhk4Fve06vfSBJZWSPVWSIwnpL6FzLvFxIo4jL8k9d116YCC1zK?= =?us-ascii?Q?PRvlC8sAYyQCXQSnLTaZyDYpgHrkpJ7yMfDjaiEIFtAmG/nP4gSSpQ4sn/9v?= =?us-ascii?Q?wgiuxeyIeLwgg+oDZQGCYE1zsVNvaBPBXuw80+6TmQsTeagn+5MLzKGYB/WN?= =?us-ascii?Q?wL3dBA5ebReMmi0GNJuQGcswp/5XgKMHO9JVydDqeXy4L6XYE4rldsfhd3J3?= =?us-ascii?Q?trxLaQU6DufIJ4N+Dc2rDJUbhMgX/s0IKmGYiFeMp+X9Jm63mCNpsDyPLvYu?= =?us-ascii?Q?cAxRBsAyu6xz1WQn3l7ARDC1FgmgmwhJyaJDij9A1yKy2a9Bdh0i/FCAb0aW?= =?us-ascii?Q?sjX90HQ6YT6D5jHVzrCimlL2MpT+HTzujuzK6gLOZL2e1gZiywfowUvglFjb?= =?us-ascii?Q?iLfCzUjE6d7YNTDdcZUOiqg9Gy4iWF2J0AVSkQdwxQbE/dNPMI3HkE6urimV?= =?us-ascii?Q?I29ZYewS7WwudNCJWC/il9rfNpoqsiIw4140QeSbjeG6FbvTfPnF8sZUcJCL?= =?us-ascii?Q?7INaO940Lgc5xPPVtQ1Xf+ITObxXcSPA5bDpHl+RR7qMG0TfRN3TnVeXASJM?= =?us-ascii?Q?2LJH42fPtlmXR263vefvchTE7U6M1bvf9gcMfuNUIc/tspoZ8mvpzLjiao40?= =?us-ascii?Q?+aUuTjYsjhel7zuodbyrlyAnNeGEl2yCGR6ylPl9KTmNuC241wYfYk7sj6Zp?= =?us-ascii?Q?43zMRjULoGxb5XW6TN3/jF1RuPuT4mgJCcRi81eofn3V1nUOUqVoIm2imBxB?= =?us-ascii?Q?No19432UBAr+wfkEzqGYdm0GP6prLlM9B9ZwJ2wwX543LOjNKvVsL4c6T8nA?= =?us-ascii?Q?MC3/qOx8/sOhn5V8/9bKyS8KZibVqBNB4RegnwhlXLu4vwQxS7MH?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 664c7c9d-c471-4d81-0fa6-08de4fbc5baa X-MS-Exchange-CrossTenant-AuthSource: PH0PR12MB8800.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jan 2026 20:19:14.5167 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 2odkuB9DHMlcHjegsSCG0OyEhWFeOTxb+IlkbZOqkYV5H4Qn8135O7ZaOngUI0F1QSi7WvAcV5gGM+FLsW2nzQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB6561 On Fri, Jan 09, 2026 at 08:32:50PM +0100, Petr Tesarik wrote: > On Fri, 9 Jan 2026 13:19:25 -0500 > Yury Norov wrote: > > >[...] > > -- > > > > OK, let me stop here. > > > > Can you please instead of mechanical rework check each case > > individually and find the best replacement to highlight the intention? > > > > Can you also split this patch to a series according to subsystems, so > > that corresponding maintainers will have better access to their changes? > > Well, then it makes more sense to start by identifying the intention in > every place and getting them fixed one by one. Whatever remains should > be converted to use the new macro. > > In fact, I can do both in parallel, converting the places where the > result of ffs() is immediately used as a shift count. > > Then no tree-wide change is necessary, as long as we can first get the > helper (under whichever name) into bitops.h. But it will be rejected > without an in-tree user. I somehow feel caught by Catch XXII. > > Advice welcome. Non-ironically. Build your series like this: 1. Switch all 'a & -a' chunks to the existing helpers where possible; 2. Introduce the new macro; 3. Convert the rest of the codebase to using the macro; In cover-letter mention that patches from #1 may be taken individually or together with the rest of the series at maintainers' discretion, and #2 and 3 must be merged at once, for example with my branch. Then depending on feedback, I'll take your series as is, or will take only explicitly acked patches. In 2nd case, I will ask you to resend non-acked part for better visibility, and then decide either take it or drop. Thanks, Yury