From: Mike Rapoport <rppt@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Ben Dooks <ben.dooks@codethink.co.uk>,
linux-kernel@vger.kernel.or, linux-mm@kvack.org
Subject: Re: [PATCH] mm: numa,memblock: include <asm/numa.h> for 'numa_nodes_parsed'
Date: Sun, 11 Jan 2026 11:05:12 +0200 [thread overview]
Message-ID: <aWNnyDTTRoO2HKnD@kernel.org> (raw)
In-Reply-To: <20260108105220.f1577b1c1709319e83760699@linux-foundation.org>
On Thu, Jan 08, 2026 at 10:52:20AM -0800, Andrew Morton wrote:
> On Thu, 8 Jan 2026 10:15:39 +0000 Ben Dooks <ben.dooks@codethink.co.uk> wrote:
>
> > The 'numa_nodes_parsed' is defined in <asm/numa.h> but this file
> > is not included in mm/numa_memblks.c (build x86_64) so add this
> > to the incldues to fix the following sparse warning:
> >
> > mm/numa_memblks.c:13:12: warning: symbol 'numa_nodes_parsed' was not declared. Should it be static?
> >
>
> huh, I wonder how that snuck through and survived more than a
> year.
Probably most configs include <asm/numa.h> as other header dependencies and
Ben's config does not for some reason.
> Thanks, I'll add
>
> Fixes: 87482708210f ("mm: introduce numa_memblks")
> Cc: <stable@vger.kernel.org>
and please add
Reviewed-by: Mike Rapoport (Microsoft) <rppt@kernel.org>
--
Sincerely yours,
Mike.
next prev parent reply other threads:[~2026-01-11 9:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-08 10:15 [PATCH] mm: numa,memblock: include <asm/numa.h> for 'numa_nodes_parsed' Ben Dooks
2026-01-08 18:52 ` Andrew Morton
2026-01-11 9:05 ` Mike Rapoport [this message]
2026-01-12 15:12 ` Ben Dooks
2026-01-14 5:25 ` Anshuman Khandual
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aWNnyDTTRoO2HKnD@kernel.org \
--to=rppt@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=ben.dooks@codethink.co.uk \
--cc=linux-kernel@vger.kernel.or \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.