From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: manivannan.sadhasivam@oss.qualcomm.com
Cc: "Rob Herring" <robh@kernel.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Jiri Slaby" <jirislaby@kernel.org>,
"Nathan Chancellor" <nathan@kernel.org>,
"Nicolas Schier" <nicolas.schier@linux.dev>,
"Hans de Goede" <hansg@kernel.org>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Mark Pearson" <mpearson-lenovo@squebb.ca>,
"Derek J. Clark" <derekjohn.clark@gmail.com>,
"Manivannan Sadhasivam" <mani@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Marcel Holtmann" <marcel@holtmann.org>,
"Luiz Augusto von Dentz" <luiz.dentz@gmail.com>,
"Bartosz Golaszewski" <brgl@bgdev.pl>,
"Daniel Scally" <djrscally@gmail.com>,
"Heikki Krogerus" <heikki.krogerus@linux.intel.com>,
"Sakari Ailus" <sakari.ailus@linux.intel.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
"Danilo Krummrich" <dakr@kernel.org>,
"Bartosz Golaszewski" <brgl@kernel.org>,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-kbuild@vger.kernel.org,
platform-driver-x86@vger.kernel.org, linux-pci@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-bluetooth@vger.kernel.org, linux-pm@vger.kernel.org,
"Stephan Gerhold" <stephan.gerhold@linaro.org>,
"Dmitry Baryshkov" <dmitry.baryshkov@oss.qualcomm.com>,
linux-acpi@vger.kernel.org,
"Sui Jingfeng" <sui.jingfeng@linux.dev>
Subject: Re: [PATCH v3 03/14] software node: Implement device_get_match_data fwnode callback
Date: Mon, 12 Jan 2026 09:56:06 +0200 [thread overview]
Message-ID: <aWSpFk9z0zpyKjr6@smile.fi.intel.com> (raw)
In-Reply-To: <20260110-pci-m2-e-v3-3-4faee7d0d5ae@oss.qualcomm.com>
On Sat, Jan 10, 2026 at 12:26:21PM +0530, Manivannan Sadhasivam via B4 Relay wrote:
> Because the software node backend of the fwnode API framework lacks an
> implementation for the .device_get_match_data function callback.
Maybe this is done on purpose. Have you thought about this aspect?
> This makes it difficult to use(and/or test) a few drivers that originates
> from DT world on the non-DT platform.
How difficult? DSA implementation went to the way of taking DT overlay
approach. Why that one can't be applied here?
> Implement the .device_get_match_data fwnode callback, which helps to keep
> the three backends of the fwnode API aligned as much as possible. This is
> also a fundamental step to make a few drivers OF-independent truely
> possible.
>
> Device drivers or platform setup codes are expected to provide a software
> node string property, named as "compatible". At this moment, the value of
> this string property is being used to match against the compatible entries
> in the of_device_id table. It can be extended in the future though.
I really do not want to see this patch without very good justification
(note, there were at least two attempts in the past to add this stuff
and no-one was merged, have you studied those cases?).
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-01-12 7:56 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-10 6:56 [PATCH v3 00/14] Add support for handling PCIe M.2 Key E connectors in devicetree Manivannan Sadhasivam
2026-01-10 6:56 ` Manivannan Sadhasivam via B4 Relay
2026-01-10 6:56 ` [PATCH v3 01/14] serdev: Convert to_serdev_*() helpers to macros and use container_of_const() Manivannan Sadhasivam
2026-01-10 6:56 ` Manivannan Sadhasivam via B4 Relay
2026-01-10 6:56 ` [PATCH v3 02/14] serdev: Add an API to find the serdev controller associated with the devicetree node Manivannan Sadhasivam
2026-01-10 6:56 ` Manivannan Sadhasivam via B4 Relay
2026-01-12 7:50 ` Andy Shevchenko
2026-01-12 7:55 ` Manivannan Sadhasivam
2026-01-12 8:06 ` Andy Shevchenko
2026-01-12 10:59 ` Bartosz Golaszewski
2026-01-10 6:56 ` [PATCH v3 03/14] software node: Implement device_get_match_data fwnode callback Manivannan Sadhasivam
2026-01-10 6:56 ` Manivannan Sadhasivam via B4 Relay
2026-01-12 7:56 ` Andy Shevchenko [this message]
2026-01-12 8:19 ` Manivannan Sadhasivam
2026-01-12 8:27 ` Andy Shevchenko
2026-01-12 9:02 ` Manivannan Sadhasivam
2026-01-12 16:31 ` Manivannan Sadhasivam
2026-01-12 13:37 ` Konstantin Ryabitsev
2026-01-12 16:41 ` Manivannan Sadhasivam
2026-01-14 3:40 ` Sui Jingfeng
[not found] ` <26a001c3-2140-4241-87dd-604eab3f827b@linux.dev>
2026-01-22 8:51 ` Andy Shevchenko
2026-01-10 6:56 ` [PATCH v3 04/14] software node: Add software_node_match_device() API Manivannan Sadhasivam
2026-01-10 6:56 ` Manivannan Sadhasivam via B4 Relay
2026-01-12 8:31 ` Andy Shevchenko
2026-01-12 11:03 ` Bartosz Golaszewski
2026-01-12 11:15 ` Andy Shevchenko
2026-01-10 6:56 ` [PATCH v3 05/14] software node: Add software_node_device_uevent() API Manivannan Sadhasivam
2026-01-10 6:56 ` Manivannan Sadhasivam via B4 Relay
2026-01-12 8:09 ` Andy Shevchenko
2026-01-10 6:56 ` [PATCH v3 06/14] software node: Add software_node_device_modalias() API Manivannan Sadhasivam
2026-01-10 6:56 ` Manivannan Sadhasivam via B4 Relay
2026-01-12 8:32 ` Andy Shevchenko
2026-01-10 6:56 ` [PATCH v3 07/14] serdev: Do not return -ENODEV from of_serdev_register_devices() if external connector is used Manivannan Sadhasivam
2026-01-10 6:56 ` Manivannan Sadhasivam via B4 Relay
2026-01-10 6:56 ` [PATCH v3 08/14] serdev: Add support for swnode based driver matching and uevent/modalias Manivannan Sadhasivam
2026-01-10 6:56 ` Manivannan Sadhasivam via B4 Relay
2026-01-10 6:56 ` [PATCH v3 09/14] dt-bindings: serial: Document the graph port Manivannan Sadhasivam
2026-01-10 6:56 ` Manivannan Sadhasivam via B4 Relay
2026-01-10 6:56 ` [PATCH v3 10/14] dt-bindings: connector: Add PCIe M.2 Mechanical Key E connector Manivannan Sadhasivam
2026-01-10 6:56 ` Manivannan Sadhasivam via B4 Relay
2026-01-10 6:56 ` [PATCH v3 11/14] dt-bindings: connector: m2: Add M.2 1620 LGA soldered down connector Manivannan Sadhasivam
2026-01-10 6:56 ` Manivannan Sadhasivam via B4 Relay
2026-01-10 6:56 ` [PATCH v3 12/14] Bluetooth: hci_qca: Add M.2 Bluetooth device support using pwrseq Manivannan Sadhasivam
2026-01-10 6:56 ` Manivannan Sadhasivam via B4 Relay
2026-01-10 6:56 ` [PATCH v3 13/14] power: sequencing: pcie-m2: Add support for PCIe M.2 Key E connectors Manivannan Sadhasivam
2026-01-10 6:56 ` Manivannan Sadhasivam via B4 Relay
2026-01-10 6:56 ` [PATCH v3 14/14] power: sequencing: pcie-m2: Create serdev device for WCN7850 bluetooth Manivannan Sadhasivam
2026-01-10 6:56 ` Manivannan Sadhasivam via B4 Relay
2026-01-12 8:04 ` [PATCH v3 00/14] Add support for handling PCIe M.2 Key E connectors in devicetree Andy Shevchenko
2026-01-12 8:18 ` Andy Shevchenko
2026-01-14 12:40 ` Herve Codina
2026-01-22 8:52 ` Andy Shevchenko
2026-01-12 10:54 ` Bartosz Golaszewski
-- strict thread matches above, loose matches on Subject: below --
2026-01-12 16:25 [PATCH v4 0/9] " Manivannan Sadhasivam
2026-01-12 16:26 ` [PATCH v4 9/9] power: sequencing: pcie-m2: Create serdev device for WCN7850 bluetooth Manivannan Sadhasivam
2026-01-12 16:43 ` [PATCH v3 03/14] software node: Implement device_get_match_data fwnode callback Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aWSpFk9z0zpyKjr6@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=brgl@bgdev.pl \
--cc=brgl@kernel.org \
--cc=conor+dt@kernel.org \
--cc=dakr@kernel.org \
--cc=derekjohn.clark@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=djrscally@gmail.com \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=gregkh@linuxfoundation.org \
--cc=hansg@kernel.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jirislaby@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=mani@kernel.org \
--cc=manivannan.sadhasivam@oss.qualcomm.com \
--cc=marcel@holtmann.org \
--cc=mpearson-lenovo@squebb.ca \
--cc=nathan@kernel.org \
--cc=nicolas.schier@linux.dev \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=stephan.gerhold@linaro.org \
--cc=sui.jingfeng@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.