From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Cc: David Rhodes <david.rhodes@cirrus.com>,
Richard Fitzgerald <rf@opensource.cirrus.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
Herve Codina <herve.codina@bootlin.com>,
Alexander Sverdlin <alexander.sverdlin@gmail.com>,
Pascal Huerst <pascal.huerst@gmail.com>,
linux-sound@vger.kernel.org, patches@opensource.cirrus.com,
linux-kernel@vger.kernel.org, dan.carpenter@linaro.org,
kernel-janitors@vger.kernel.org, error27@gmail.com
Subject: Re: [PATCH] ASoC: cs4271: Fix resource leak in cs4271_soc_resume()
Date: Mon, 12 Jan 2026 10:54:57 +0000 [thread overview]
Message-ID: <aWTTAXwR5o61s64t@opensource.cirrus.com> (raw)
In-Reply-To: <20260110195337.2522347-1-harshit.m.mogalapalli@oracle.com>
On Sat, Jan 10, 2026 at 11:53:36AM -0800, Harshit Mogalapalli wrote:
> Smatch detects this resource leak:
>
> sound/soc/codecs/cs4271.c:548 cs4271_soc_resume() warn:
> 'cs4271->clk' from clk_prepare_enable() not released on lines: 540,546.
>
> Instead of direct returns, unprepare the clock and disable regulators on
> the error paths.
>
> Fixes: cf6bf51b5325 ("ASoC: cs4271: Add support for the external mclk")
> Fixes: 9a397f473657 ("ASoC: cs4271: add regulator consumer support")
> Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
> ---
Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Thanks,
Charles
next prev parent reply other threads:[~2026-01-12 10:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-10 19:53 [PATCH] ASoC: cs4271: Fix resource leak in cs4271_soc_resume() Harshit Mogalapalli
2026-01-10 20:12 ` Alexander Sverdlin
2026-01-12 7:24 ` Herve Codina
2026-01-12 10:54 ` Charles Keepax [this message]
2026-02-05 17:28 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aWTTAXwR5o61s64t@opensource.cirrus.com \
--to=ckeepax@opensource.cirrus.com \
--cc=alexander.sverdlin@gmail.com \
--cc=broonie@kernel.org \
--cc=dan.carpenter@linaro.org \
--cc=david.rhodes@cirrus.com \
--cc=error27@gmail.com \
--cc=harshit.m.mogalapalli@oracle.com \
--cc=herve.codina@bootlin.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=pascal.huerst@gmail.com \
--cc=patches@opensource.cirrus.com \
--cc=perex@perex.cz \
--cc=rf@opensource.cirrus.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.