From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Cc: Linux Doc Mailing List <linux-doc@vger.kernel.org>,
linux-kernel@vger.kernel.org, Jani Nikula <jani.nikula@intel.com>,
Jonathan Corbet <corbet@lwn.net>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Randy Dunlap <rdunlap@infradead.org>
Subject: Re: [PATCH 1/4] scripts/kernel-doc: fix logic to handle unissued warnings
Date: Mon, 12 Jan 2026 13:43:36 +0200 [thread overview]
Message-ID: <aWTeaEHm8n_pDQhr@smile.fi.intel.com> (raw)
In-Reply-To: <914b07e496fd204d7082c6e1b138d99d8488da9b.1768216455.git.mchehab+huawei@kernel.org>
On Mon, Jan 12, 2026 at 12:23:23PM +0100, Mauro Carvalho Chehab wrote:
> Changeset 469c1c9eb6c9 ("kernel-doc: Issue warnings that were silently discarded")
> didn't properly addressed the missing messages behavior, as
> it was calling directly python logger low-level function,
> instead of using the expected method to emit warnings.
>
> Basically, there are two methods to log messages:
>
> - self.config.log.warning() - This is the raw level to emit a
> warning. It just writes the a message at stderr, via python
> logging, as it is initialized as:
>
> self.config.log = logging.getLogger("kernel-doc")
>
> - self.config.warning() - This is where we actually consider a
> message as a warning, properly incrementing error count.
>
> Due to that, several parsing error messages are internally considered
> as success, causing -Werror to not work on such messages.
>
> While here, ensure that the last ignored entry will also be handled
> by adding an extra check at the end of the parse handler.
Thanks for addressing these issues, Mauro!
I am not promising I will test this soon, but from code perspective it looks
good to me,
Acked-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-01-12 11:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-12 11:23 [PATCH 0/4] kernel-doc: fix -Werror issues Mauro Carvalho Chehab
2026-01-12 11:23 ` [PATCH 1/4] scripts/kernel-doc: fix logic to handle unissued warnings Mauro Carvalho Chehab
2026-01-12 11:43 ` Andy Shevchenko [this message]
2026-01-12 11:23 ` [PATCH 2/4] scripts/kernel-doc: avoid error_count overflows Mauro Carvalho Chehab
2026-01-12 12:02 ` Jani Nikula
2026-01-12 14:39 ` Mauro Carvalho Chehab
2026-01-12 11:23 ` [PATCH 3/4] scripts/kernel-doc: ensure that comments are using our coding style Mauro Carvalho Chehab
2026-01-12 11:23 ` [PATCH 4/4] scripts/kernel-doc: some fixes to kernel-doc comments Mauro Carvalho Chehab
2026-01-12 12:11 ` Jani Nikula
-- strict thread matches above, loose matches on Subject: below --
2026-01-12 15:54 [PATCH 1/4] scripts/kernel-doc: fix logic to handle unissued warnings kernel test robot
2026-01-13 2:37 kernel test robot
2026-01-13 3:12 kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aWTeaEHm8n_pDQhr@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=corbet@lwn.net \
--cc=jani.nikula@intel.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab+huawei@kernel.org \
--cc=mchehab@kernel.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.