From: Patrick Steinhardt <ps@pks.im>
To: Taylor Blau <me@ttaylorr.com>
Cc: git@vger.kernel.org, Jeff King <peff@peff.net>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH 1/2] t/t5319-multi-pack-index.sh: drop early 'test_done'
Date: Tue, 13 Jan 2026 08:37:01 +0100 [thread overview]
Message-ID: <aWX2HSakgzcfi-CL@pks.im> (raw)
In-Reply-To: <9c5faa5932cdd9e570406bc85ba27f94195a4d3d.1768261435.git.me@ttaylorr.com>
On Mon, Jan 12, 2026 at 06:45:03PM -0500, Taylor Blau wrote:
> diff --git a/t/t5319-multi-pack-index.sh b/t/t5319-multi-pack-index.sh
> index 794f8b5ab4e..b6622849db7 100755
> --- a/t/t5319-multi-pack-index.sh
> +++ b/t/t5319-multi-pack-index.sh
> @@ -415,8 +415,6 @@ test_expect_success 'up-to-date multi-pack-index is retained' '
> )
> '
>
> -test_done
> -
> test_expect_success 'verify multi-pack-index success' '
> git multi-pack-index verify --object-dir=$objdir
> '
Oh dear, this is embarassing.
Patrick
next prev parent reply other threads:[~2026-01-13 7:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-12 23:44 [PATCH 0/2] midx-write.c: do not optimize out writes with corrupt MIDXs Taylor Blau
2026-01-12 23:45 ` [PATCH 1/2] t/t5319-multi-pack-index.sh: drop early 'test_done' Taylor Blau
2026-01-13 7:37 ` Patrick Steinhardt [this message]
2026-01-12 23:45 ` [PATCH 2/2] midx-write.c: assume checksum-invalid MIDXs require an update Taylor Blau
2026-01-13 7:38 ` Patrick Steinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aWX2HSakgzcfi-CL@pks.im \
--to=ps@pks.im \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=me@ttaylorr.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.