From: Oscar Salvador <osalvador@suse.de>
To: Kefeng Wang <wangkefeng.wang@huawei.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
David Hildenbrand <david@kernel.org>,
Muchun Song <muchun.song@linux.dev>,
linux-mm@kvack.org, sidhartha.kumar@oracle.com,
jane.chu@oracle.com, Zi Yan <ziy@nvidia.com>,
Vlastimil Babka <vbabka@suse.cz>,
Brendan Jackman <jackmanb@google.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Matthew Wilcox <willy@infradead.org>
Subject: Re: [PATCH 1/5] mm: page_isolation: introduce page_is_unmovable()
Date: Tue, 13 Jan 2026 05:37:17 +0100 [thread overview]
Message-ID: <aWXL_ctqTCTdaJHe@localhost.localdomain> (raw)
In-Reply-To: <20260112150954.1802953-2-wangkefeng.wang@huawei.com>
On Mon, Jan 12, 2026 at 11:09:50PM +0800, Kefeng Wang wrote:
> Factor out the check if a page is unmovable into a new helper,
> and will be reused in the following patch.
>
> No functional change intended, the minor changes are as follows,
> 1) Avoid unnecessary calls by checking CONFIG_ARCH_ENABLE_HUGEPAGE_MIGRATION
> 2) Directly call PageCompound since PageTransCompound may be dropped
> 3) Using folio_test_hugetlb()
>
> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
Looks good to me, I was a bit confused why we cannot rely directly on
hugepage_migration_supported() without having to check for
CONFIG_ARCH_ENABLE_HUGEPAGE_MIGRATION first, but I guess it speed up
things.
Reviewed-by: Oscar Salvador <osalvador@suse.de>
--
Oscar Salvador
SUSE Labs
next prev parent reply other threads:[~2026-01-13 4:37 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-12 15:09 [PATCH mm-new resend 0/5] mm: accelerate gigantic folio allocation Kefeng Wang
2026-01-12 15:09 ` [PATCH 1/5] mm: page_isolation: introduce page_is_unmovable() Kefeng Wang
2026-01-12 16:36 ` Zi Yan
2026-01-13 4:37 ` Oscar Salvador [this message]
2026-01-12 15:09 ` [PATCH 2/5] mm: page_alloc: optimize pfn_range_valid_contig() Kefeng Wang
2026-01-12 17:02 ` Zi Yan
2026-01-13 1:24 ` Kefeng Wang
2026-01-13 1:27 ` Zi Yan
2026-01-13 9:55 ` Kefeng Wang
2026-01-14 1:47 ` Andrew Morton
2026-01-13 5:14 ` Oscar Salvador
2026-01-13 9:55 ` Kefeng Wang
2026-01-12 15:09 ` [PATCH 3/5] mm: hugetlb: optimize replace_free_hugepage_folios() Kefeng Wang
2026-01-13 5:27 ` Oscar Salvador
2026-01-13 11:38 ` Kefeng Wang
2026-01-14 13:55 ` [PATCH v2 " Kefeng Wang
2026-01-15 22:42 ` Andrew Morton
2026-01-16 0:58 ` Kefeng Wang
2026-01-12 15:09 ` [PATCH 4/5] mm: hugetlb_cma: optimize hugetlb_cma_alloc_frozen_folio() Kefeng Wang
2026-01-13 16:29 ` Zi Yan
2026-01-12 15:09 ` [PATCH 5/5] mm: hugetlb_cma: mark hugetlb_cma{_only} as __ro_after_init Kefeng Wang
2026-01-13 16:29 ` Zi Yan
2026-01-14 7:36 ` Muchun Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aWXL_ctqTCTdaJHe@localhost.localdomain \
--to=osalvador@suse.de \
--cc=akpm@linux-foundation.org \
--cc=david@kernel.org \
--cc=hannes@cmpxchg.org \
--cc=jackmanb@google.com \
--cc=jane.chu@oracle.com \
--cc=linux-mm@kvack.org \
--cc=muchun.song@linux.dev \
--cc=sidhartha.kumar@oracle.com \
--cc=vbabka@suse.cz \
--cc=wangkefeng.wang@huawei.com \
--cc=willy@infradead.org \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.