All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jinchao Wang <wangjinchao600@gmail.com>
To: Luca Ceresoli <luca.ceresoli@bootlin.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	"Matthieu Baerts (NGI0)" <matttbe@kernel.org>,
	Carlos Llamas <cmllamas@google.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scripts/decode_stacktrace.sh update usage to show vmlinux is mandatory
Date: Tue, 13 Jan 2026 16:41:22 +0800	[thread overview]
Message-ID: <aWYFMrKXPBOgbY9k@ndev> (raw)
In-Reply-To: <DFNAUPRS23JF.1IM2BY5O66493@bootlin.com>

On Tue, Jan 13, 2026 at 08:57:03AM +0100, Luca Ceresoli wrote:
> Hello Jinchao,
> 
> On Mon Jan 12, 2026 at 10:10 AM CET, Jinchao Wang wrote:
> > The script currently errors out if vmlinux is not provided, but the
> > usage string implies it is optional. Remove the square brackets to
> > correctly indicate that <vmlinux> is a required argument.
> >
> > Signed-off-by: Jinchao Wang <wangjinchao600@gmail.com>
> 
> Thanks for your patch, but it is not correct.
> 
> The vmlinux argument is optional when debuginfod info is found:
> 
>         # Can we use debuginfod-find?
>         if type debuginfod-find >/dev/null 2>&1 ; then
>                 debuginfod=${1-only}
>         fi
> 
>         if [[ $vmlinux == "" && -z $debuginfod ]] ; then
>                 echo "ERROR! vmlinux image must be specified" >&2
>                 usage
>                 exit 1
>         fi
> 
> (https://elixir.bootlin.com/linux/v6.19-rc4/source/scripts/decode_stacktrace.sh#L65-L74)
> 
> However I realize improving the error message might make sense, something
> like:
> 
>                 echo "ERROR! vmlinux image must be specified or debuginfo must be accessible" >&2

Thanks for the feedback. That sounds reasonable to me.
> 
> Best regards,
> Luca
> 
> --
> Luca Ceresoli, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com

      reply	other threads:[~2026-01-13  8:41 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-12  9:10 [PATCH] scripts/decode_stacktrace.sh update usage to show vmlinux is mandatory Jinchao Wang
2026-01-13  7:57 ` Luca Ceresoli
2026-01-13  8:41   ` Jinchao Wang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aWYFMrKXPBOgbY9k@ndev \
    --to=wangjinchao600@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=cmllamas@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luca.ceresoli@bootlin.com \
    --cc=matttbe@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.