From: kenkinming2002@gmail.com
To: Benjamin Tissoires <bentiss@kernel.org>
Cc: jikos@kernel.org, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] HID: i2c-hid: override HID descriptors for some Haptick 5288 touchpads
Date: Tue, 13 Jan 2026 21:11:31 +0800 [thread overview]
Message-ID: <aWZEST09jJlVZOzq@anonymous> (raw)
In-Reply-To: <aV6d5mt2veL-vEvf@anonymous>
On Thu, Jan 08, 2026 at 02:14:29AM +0800, kenkinming2002@gmail.com wrote:
> > The simplest "solution" following what you are doing is making a HID-BPF
> > fixup which checks whether the device properly sent the report
> > descriptor and if not puts the one here. The HID-BPF has the advantage
> > of being compatible with hid-multitouch so you won't get into troubles
> > with a separate module.
> This might be a solution but would that not only fix it just for me? I
> would have to look into how to do HID-BPF fixup.
An update, I have looked into HID-BPF but it seems to me that we can
only fix up the HID report descriptor and not the HID descriptor (this
descriptor is specific to i2c-hid device) but from my testing both
descriptor can be corrupted. Specifically, I see messages such as:
i2c_hid_acpi i2c-SPPT2600:00: unexpected HID descriptor bcdVersion (0x0209)
i2c_hid_acpi i2c-SPPT2600:00: Failed to fetch the HID Descriptor
appearing in my log.
For now, I am just going to just apply the patch locally for myself till
a better solution come up.
I have finally clean up the pile of garbage I have while investigating
the problem and put up a proper git repository with relevant script and
logs at https://github.com/kenkinming2002/samsung-i2c-hid-bug-repro.git.
Huge thanks to Benjamin and anyway who might have stumbled across this
patch for your time.
Yours sincerly,
Ken Kwok
next prev parent reply other threads:[~2026-01-13 13:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-25 19:08 [PATCH] HID: i2c-hid: override HID descriptors for some Haptick 5288 touchpads Kwok Kin Ming
2026-01-07 17:45 ` Benjamin Tissoires
2026-01-07 18:14 ` kenkinming2002
2026-01-13 13:11 ` kenkinming2002 [this message]
2026-01-13 15:00 ` Benjamin Tissoires
2026-01-13 18:08 ` kenkinming2002
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aWZEST09jJlVZOzq@anonymous \
--to=kenkinming2002@gmail.com \
--cc=bentiss@kernel.org \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.