From: Simon Horman <horms@kernel.org>
To: Lorenzo Bianconi <lorenzo@kernel.org>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, netdev@vger.kernel.org
Subject: Re: [PATCH net v2] net: airoha: Fix schedule while atomic in airoha_ppe_deinit()
Date: Tue, 13 Jan 2026 13:26:49 +0000 [thread overview]
Message-ID: <aWZIGbwN1fdHCgnb@horms.kernel.org> (raw)
In-Reply-To: <aWDLg6RzI4s2VgIH@lore-desk>
On Fri, Jan 09, 2026 at 10:33:55AM +0100, Lorenzo Bianconi wrote:
> > On Mon, Jan 05, 2026 at 09:43:31AM +0100, Lorenzo Bianconi wrote:
> > > airoha_ppe_deinit() runs airoha_npu_ppe_deinit() in atomic context.
> > > airoha_npu_ppe_deinit routine allocates ppe_data buffer with GFP_KERNEL
> > > flag. Rely on rcu_replace_pointer in airoha_ppe_deinit routine in order
> > > to fix schedule while atomic issue in airoha_npu_ppe_deinit() since we
> > > do not need atomic context there.
> >
> > Hi Lorenzo,
>
> Hi Simon,
>
> >
> > If I understand things correctly the key problem here is that
> > an allocation with GFP_KERNEL implies GFP_RECLAIM and thus may sleep.
> > But RCU read-side critical sections are not allowed to sleep in non-RT
> > kernels.
>
> yes, right, RCU section is atomic.
>
> >
> > If so, I think it would be clearer to describe the problem along those
> > lines. But maybe it is just me.
>
> This patch is already in Linus's tree.
Yeah, sorry for missing that.
prev parent reply other threads:[~2026-01-13 13:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-05 8:43 [PATCH net v2] net: airoha: Fix schedule while atomic in airoha_ppe_deinit() Lorenzo Bianconi
2026-01-08 10:30 ` patchwork-bot+netdevbpf
2026-01-08 13:22 ` Simon Horman
2026-01-09 9:33 ` Lorenzo Bianconi
2026-01-13 13:26 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aWZIGbwN1fdHCgnb@horms.kernel.org \
--to=horms@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=lorenzo@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.