From: Niklas Cassel <cassel@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: cem@kernel.org, linux-xfs@vger.kernel.org, mark.tinguely@oracle.com
Subject: Re: [PATCH] xfs: remove xfs_attr_leaf_hasname
Date: Tue, 13 Jan 2026 14:36:07 +0100 [thread overview]
Message-ID: <aWZKR16It8Lm2Uvp@ryzen> (raw)
In-Reply-To: <20260109151741.2376835-1-hch@lst.de>
On Fri, Jan 09, 2026 at 04:17:40PM +0100, Christoph Hellwig wrote:
> The calling convention of xfs_attr_leaf_hasname() is problematic, because
> it returns a NULL buffer when xfs_attr3_leaf_read fails, a valid buffer
> when xfs_attr3_leaf_lookup_int returns -ENOATTR or -EEXIST, and a
> non-NULL buffer pointer for an already released buffer when
> xfs_attr3_leaf_lookup_int fails with other error values.
>
> Fix this by simply open coding xfs_attr_leaf_hasname in the callers, so
> that the buffer release code is done by each caller of
> xfs_attr3_leaf_read.
>
> X-Cc: stable@vger.kernel.org # v5.19+
This looks like a typo. (Thus stable is not on cc:)
Probably not enough reson to resend,
(since the stable scripts backport anything with a Fixes-tag anyway),
but perhaps s/X-Cc/Cc/ when applying.
Kind regards,
Niklas
next prev parent reply other threads:[~2026-01-13 13:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-09 15:17 [PATCH] xfs: remove xfs_attr_leaf_hasname Christoph Hellwig
2026-01-09 16:29 ` Darrick J. Wong
2026-01-09 16:37 ` Christoph Hellwig
2026-01-09 17:41 ` Darrick J. Wong
2026-01-13 9:38 ` Carlos Maiolino
2026-01-13 13:26 ` Christoph Hellwig
2026-01-13 13:36 ` Niklas Cassel [this message]
2026-01-21 12:23 ` Carlos Maiolino
-- strict thread matches above, loose matches on Subject: below --
2026-03-01 1:33 FAILED: Patch "xfs: remove xfs_attr_leaf_hasname" failed to apply to 6.6-stable tree Sasha Levin
2026-06-05 1:36 ` [PATCH] xfs: remove xfs_attr_leaf_hasname Jiping Ma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aWZKR16It8Lm2Uvp@ryzen \
--to=cassel@kernel.org \
--cc=cem@kernel.org \
--cc=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
--cc=mark.tinguely@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.