From: Brian Foster <bfoster@redhat.com>
To: Christoph Hellwig <hch@lst.de>
Cc: "Darrick J. Wong" <djwong@kernel.org>,
brauner@kernel.org, linux-xfs@vger.kernel.org,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] iomap: wait for batched folios to be stable in __iomap_get_folio
Date: Tue, 13 Jan 2026 11:12:01 -0500 [thread overview]
Message-ID: <aWZu0TxyoyHFTqXi@bfoster> (raw)
In-Reply-To: <20260113155805.GA3726@lst.de>
On Tue, Jan 13, 2026 at 04:58:05PM +0100, Christoph Hellwig wrote:
> On Tue, Jan 13, 2026 at 07:48:55AM -0800, Darrick J. Wong wrote:
> > I wonder if we ought to have a filemap_fbatch_next() that would take
> > care of the relocking, revalidation, and stabilization... but this spot
> > fix is good as-is.
>
> Let's wait until we have another user or two. Premature refactoring
> tends to backfire.
>
I agree on not being too aggressive on that... I do like the idea
though, so I'll try to keep it in mind if this happens to expand down
the road. Thanks for the fix.
Brian
next prev parent reply other threads:[~2026-01-13 16:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-13 15:39 [PATCH] iomap: wait for batched folios to be stable in __iomap_get_folio Christoph Hellwig
2026-01-13 15:48 ` Darrick J. Wong
2026-01-13 15:58 ` Christoph Hellwig
2026-01-13 16:12 ` Brian Foster [this message]
2026-01-13 18:08 ` Darrick J. Wong
2026-01-13 15:50 ` Brian Foster
2026-01-14 16:06 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aWZu0TxyoyHFTqXi@bfoster \
--to=bfoster@redhat.com \
--cc=brauner@kernel.org \
--cc=djwong@kernel.org \
--cc=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.