From: Raag Jadav <raag.jadav@intel.com>
To: Matt Roper <matthew.d.roper@intel.com>
Cc: intel-xe@lists.freedesktop.org
Subject: Re: [PATCH 41/79] drm/xe: Cleanup headers in xe_i2c.c
Date: Wed, 14 Jan 2026 06:12:00 +0100 [thread overview]
Message-ID: <aWcloOfxYjg-XvFQ@black.igk.intel.com> (raw)
In-Reply-To: <20260113230315.3081153-122-matthew.d.roper@intel.com>
On Tue, Jan 13, 2026 at 03:03:46PM -0800, Matt Roper wrote:
> xe_i2c.c doesn't use anything from xe_device.h or xe_platform_types.h.
> Drop the unnecessary includes. However it does require xe_sriov.h which
> was being indirectly included; add an explicit include for that.
>
> Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
> ---
> drivers/gpu/drm/xe/xe_i2c.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_i2c.c b/drivers/gpu/drm/xe/xe_i2c.c
> index befc77e46eae..1e1fb72e49bf 100644
> --- a/drivers/gpu/drm/xe/xe_i2c.c
> +++ b/drivers/gpu/drm/xe/xe_i2c.c
> @@ -5,6 +5,7 @@
> * Copyright (C) 2025 Intel Corporation.
> */
>
> +#include <drm/drm_print.h>
> #include <linux/array_size.h>
> #include <linux/container_of.h>
> #include <linux/device.h>
> @@ -26,11 +27,10 @@
> #include "regs/xe_i2c_regs.h"
> #include "regs/xe_irq_regs.h"
>
> -#include "xe_device.h"
> #include "xe_device_types.h"
> #include "xe_i2c.h"
> #include "xe_mmio.h"
> -#include "xe_platform_types.h"
> +#include "xe_sriov.h"
My guess is, with pci.h here you won't even need this. But I could be
wrong.
Raag
> #include "xe_survivability_mode.h"
>
> /**
> --
> 2.52.0
>
next prev parent reply other threads:[~2026-01-14 5:12 UTC|newest]
Thread overview: 93+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-13 23:03 [PATCH 00/79] Cleanup unused headers reported by clangd Matt Roper
2026-01-13 23:03 ` [PATCH 01/79] drm/xe: Cleanup headers in xe_bb.c Matt Roper
2026-01-13 23:03 ` [PATCH 02/79] drm/xe: Drop unused header in xe_bo.c Matt Roper
2026-01-13 23:03 ` [PATCH 03/79] drm/xe: Cleanup headers in xe_devcoredump.c Matt Roper
2026-01-13 23:03 ` [PATCH 04/79] drm/xe: Drop unused header in xe_device.c Matt Roper
2026-01-13 23:03 ` [PATCH 05/79] drm/xe: Drop unused header in xe_exec.c Matt Roper
2026-01-13 23:03 ` [PATCH 06/79] drm/xe: Cleanup headers in xe_execlist.c Matt Roper
2026-01-13 23:03 ` [PATCH 07/79] drm/xe: Drop unused headers in xe_exec_queue.c Matt Roper
2026-01-13 23:03 ` [PATCH 08/79] drm/xe: Simplify headers in xe_ggtt.c Matt Roper
2026-01-13 23:03 ` [PATCH 09/79] drm/xe: Cleanup headers in xe_gsc_debugfs.c Matt Roper
2026-01-13 23:03 ` [PATCH 10/79] drm/xe: Simplify header in xe_gsc_proxy.c Matt Roper
2026-01-13 23:03 ` [PATCH 11/79] drm/xe: Drop unused headers in xe_gsc_submit.c Matt Roper
2026-01-13 23:03 ` [PATCH 12/79] drm/xe: Drop unused headers in xe_gt.c Matt Roper
2026-01-13 23:03 ` [PATCH 13/79] drm/xe: Cleanup headers in xe_gt_clock.c Matt Roper
2026-01-13 23:03 ` [PATCH 14/79] drm/xe: Drop unused header in xe_gt_debugfs.c Matt Roper
2026-01-13 23:03 ` [PATCH 15/79] drm/xe: Drop unused header in xe_gt_idle.c Matt Roper
2026-01-13 23:03 ` [PATCH 16/79] drm/xe: Drop unused header in xe_gt_mcr.c Matt Roper
2026-01-13 23:03 ` [PATCH 17/79] drm/xe: Drop unused headers in xe_gt_sriov_pf_config.c Matt Roper
2026-01-13 23:03 ` [PATCH 18/79] drm/xe: Drop unused header in xe_gt_sriov_pf_debugfs.c Matt Roper
2026-01-13 23:03 ` [PATCH 19/79] drm/xe: Simplify header in xe_gt_sriov_pf_migration.c Matt Roper
2026-01-13 23:03 ` [PATCH 20/79] drm/xe: Drop unused header in xe_gt_sriov_pf_policy.c Matt Roper
2026-01-13 23:03 ` [PATCH 21/79] drm/xe: Cleanup headers in xe_gt_sriov_pf_service.c Matt Roper
2026-01-13 23:03 ` [PATCH 22/79] drm/xe: Drop unused header in xe_gt_sriov_vf.c Matt Roper
2026-01-13 23:03 ` [PATCH 23/79] drm/xe: Simplify header in xe_gt_stats.c Matt Roper
2026-01-13 23:03 ` [PATCH 24/79] drm/xe: Simplify header in xe_gt_sysfs.c Matt Roper
2026-01-13 23:03 ` [PATCH 25/79] drm/xe: Simplify header in xe_gt_throttle.c Matt Roper
2026-01-14 5:07 ` Raag Jadav
2026-01-13 23:03 ` [PATCH 26/79] drm/xe: Drop unused headers in xe_guc_ads.c Matt Roper
2026-01-13 23:03 ` [PATCH 27/79] drm/xe: Drop unused header in xe_guc_buf.c Matt Roper
2026-01-13 23:03 ` [PATCH 28/79] drm/xe: Cleanup headers in xe_guc_capture.c Matt Roper
2026-01-13 23:03 ` [PATCH 29/79] drm/xe: Cleanup headers in xe_guc_debugfs.c Matt Roper
2026-01-13 23:03 ` [PATCH 30/79] drm/xe: Simplify headers in xe_guc_hwconfig.c Matt Roper
2026-01-13 23:03 ` [PATCH 31/79] drm/xe: Simplify header in xe_guc_log.c Matt Roper
2026-01-13 23:03 ` [PATCH 32/79] drm/xe: Cleanup headers in xe_guc_relay.c Matt Roper
2026-01-13 23:03 ` [PATCH 33/79] drm/xe: Drop unused headers in xe_guc_submit.c Matt Roper
2026-01-13 23:03 ` [PATCH 34/79] drm/xe: Drop unused header in xe_heci_gsc.c Matt Roper
2026-01-13 23:03 ` [PATCH 35/79] drm/xe: Drop unused header in xe_huc.c Matt Roper
2026-01-13 23:03 ` [PATCH 36/79] drm/xe: Clean up headers in xe_huc_debugfs.c Matt Roper
2026-01-13 23:03 ` [PATCH 37/79] drm/xe: Drop unused header in xe_hw_engine.c Matt Roper
2026-01-13 23:03 ` [PATCH 38/79] drm/xe: Simplify include in xe_hw_engine_class_sysfs.c Matt Roper
2026-01-13 23:03 ` [PATCH 39/79] drm/xe: Simplify include in xe_hw_engine_group.c Matt Roper
2026-01-13 23:03 ` [PATCH 40/79] drm/xe: Cleanup headers in xe_hw_fence.c Matt Roper
2026-01-13 23:03 ` [PATCH 41/79] drm/xe: Cleanup headers in xe_i2c.c Matt Roper
2026-01-14 5:12 ` Raag Jadav [this message]
2026-01-14 16:29 ` Matt Roper
2026-01-14 17:11 ` Raag Jadav
2026-01-13 23:03 ` [PATCH 42/79] drm/xe: Drop unused header in xe_irq.c Matt Roper
2026-01-13 23:03 ` [PATCH 43/79] drm/xe: Drop unused headers in xe_memirq.c Matt Roper
2026-01-13 23:03 ` [PATCH 44/79] drm/xe: Drop unused headers in xe_mmio.c Matt Roper
2026-01-13 23:03 ` [PATCH 45/79] drm/xe: Drop unused headers in xe_mocs.c Matt Roper
2026-01-13 23:03 ` [PATCH 46/79] drm/xe: Simplify include in xe_module.c Matt Roper
2026-01-13 23:03 ` [PATCH 47/79] drm/xe: Drop unused header in xe_nvm.c Matt Roper
2026-01-13 23:03 ` [PATCH 48/79] drm/xe: Drop unused headers in xe_page_reclaim.c Matt Roper
2026-01-13 23:03 ` [PATCH 49/79] drm/xe: Drop unused header in xe_pci.c Matt Roper
2026-01-13 23:03 ` [PATCH 50/79] drm/xe: Simplify include in xe_psmi.c Matt Roper
2026-01-13 23:03 ` [PATCH 51/79] drm/xe: Drop unused header in xe_pxp.c Matt Roper
2026-01-13 23:03 ` [PATCH 52/79] drm/xe: Simplify header in xe_pxp_debugfs.c Matt Roper
2026-01-13 23:03 ` [PATCH 53/79] drm/xe: Cleanup headers in xe_reg_sr.c Matt Roper
2026-01-13 23:03 ` [PATCH 54/79] drm/xe: Drop unused headers in xe_reg_whitelist.c Matt Roper
2026-01-13 23:04 ` [PATCH 55/79] drm/xe: Cleanup headers in xe_ring_ops.c Matt Roper
2026-01-13 23:04 ` [PATCH 56/79] drm/xe: Drop unused header in xe_rtp.c Matt Roper
2026-01-13 23:04 ` [PATCH 57/79] drm/xe: Simplify header in xe_sa.c Matt Roper
2026-01-13 23:04 ` [PATCH 58/79] drm/xe: Simplify header in xe_sched_job.c Matt Roper
2026-01-13 23:04 ` [PATCH 59/79] drm/xe: Drop unused header in xe_sriov_packet.c Matt Roper
2026-01-13 23:04 ` [PATCH 60/79] drm/xe: Drop unused header in xe_sriov_pf_debugfs.c Matt Roper
2026-01-13 23:04 ` [PATCH 61/79] drm/xe: Drop unused header in xe_sriov_vf.c Matt Roper
2026-01-13 23:04 ` [PATCH 62/79] drm/xe: Cleanup headers in xe_step.c Matt Roper
2026-01-13 23:04 ` [PATCH 63/79] drm/xe: Drop unused header in xe_survivability_mode.c Matt Roper
2026-01-13 23:04 ` [PATCH 64/79] drm/xe: Cleanup headers in xe_tile.c Matt Roper
2026-01-13 23:04 ` [PATCH 65/79] drm/xe: Cleanup headers in xe_tlb_inval.c Matt Roper
2026-01-13 23:04 ` [PATCH 66/79] drm/xe: Drop unused header in xe_ttm_stolen_mgr.c Matt Roper
2026-01-13 23:04 ` [PATCH 67/79] drm/xe: Drop unused header in xe_ttm_sys_mgr.c Matt Roper
2026-01-13 23:04 ` [PATCH 68/79] drm/xe: Drop unused header in xe_ttm_vram_mgr.c Matt Roper
2026-01-13 23:04 ` [PATCH 69/79] drm/xe: Drop unused headers in xe_uc.c Matt Roper
2026-01-13 23:04 ` [PATCH 70/79] drm/xe: Cleanup headers in xe_uc_debugfs.c Matt Roper
2026-01-13 23:04 ` [PATCH 71/79] drm/xe: Simplify header in xe_uc_fw.c Matt Roper
2026-01-13 23:04 ` [PATCH 72/79] drm/xe: Drop unused header in xe_validation.c Matt Roper
2026-01-13 23:04 ` [PATCH 73/79] drm/xe: Drop unused header in xe_vm.c Matt Roper
2026-01-13 23:04 ` [PATCH 74/79] drm/xe: Drop unused headers in xe_vram.c Matt Roper
2026-01-13 23:04 ` [PATCH 75/79] drm/xe: Drop unused header in xe_vram_freq.c Matt Roper
2026-01-13 23:04 ` [PATCH 76/79] drm/xe: Drop unused header in xe_vsec.c Matt Roper
2026-01-13 23:04 ` [PATCH 77/79] drm/xe: Simplify header in xe_wa.c Matt Roper
2026-01-13 23:04 ` [PATCH 78/79] drm/xe: Drop unused header in xe_wait_user_fence.c Matt Roper
2026-01-13 23:04 ` [PATCH 79/79] drm/xe: Simplify header in xe_wopcm.c Matt Roper
2026-01-13 23:17 ` ✓ CI.KUnit: success for Cleanup unused headers reported by clangd Patchwork
2026-01-14 0:03 ` ✓ Xe.CI.BAT: " Patchwork
2026-01-14 0:10 ` [PATCH 00/79] " Matthew Brost
2026-01-14 0:36 ` Matt Roper
2026-01-14 3:46 ` Matthew Brost
2026-01-14 5:02 ` Raag Jadav
2026-01-14 5:33 ` Matthew Brost
2026-01-14 16:22 ` Matt Roper
2026-01-14 8:29 ` ✓ Xe.CI.Full: success for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aWcloOfxYjg-XvFQ@black.igk.intel.com \
--to=raag.jadav@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=matthew.d.roper@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.