From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Vivek BalachandharTN <vivek.balachandhar@gmail.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@kernel.org>
Subject: Re: [PATCH] input: byd: use %*ph for Z packet dump
Date: Wed, 14 Jan 2026 10:53:05 +0200 [thread overview]
Message-ID: <aWdZcba5pK99Pfvu@smile.fi.intel.com> (raw)
In-Reply-To: <f846343a-49ac-443f-bef3-04e3e08ee20c@gmail.com>
On Wed, Jan 14, 2026 at 04:49:32AM -0400, Vivek BalachandharTN wrote:
> Thanks Andy — good point. Packet length is fixed here, so |%4ph| is better.
> I’ll follow this pattern in future patches (and can send a small follow-up
> to adjust this one if desired).
You can find all such places in input subsystem and convert them all
(1 patch per subfolder probably, 1 for keyboard/*, 1 for mouse/*, ...).
P.S. And do not top-post!
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2026-01-14 8:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-02 3:31 [PATCH] input: byd: use %*ph for Z packet dump Vivek BalachandharTN
2025-12-09 5:43 ` Dmitry Torokhov
2026-01-14 7:37 ` Andy Shevchenko
2026-01-14 8:49 ` Vivek BalachandharTN
2026-01-14 8:53 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aWdZcba5pK99Pfvu@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
--cc=vivek.balachandhar@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.