Re: [PATCH] tests/functional/x86_64: Limit the memlock test to Linux hosts

["Daniel P. Berrangé" <berrange@redhat.com>]

On Wed, Jan 14, 2026 at 10:59:04AM +0100, Thomas Huth wrote:
> From: Thomas Huth <thuth@redhat.com>
> 
> The memlock test analyzes /proc/*/status files and expects the layout
> from Linux in there. However, these files also exist on NetBSD hosts
> with a completely different layout, causing this test to fail. Thus
> limit the test to Linux hosts now.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  tests/functional/x86_64/meson.build | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/functional/x86_64/meson.build b/tests/functional/x86_64/meson.build
> index f78eec5e6cf..97286d78b8f 100644
> --- a/tests/functional/x86_64/meson.build
> +++ b/tests/functional/x86_64/meson.build
> @@ -9,12 +9,13 @@ test_x86_64_timeouts = {
>    'virtio_balloon': 120,
>  }
>  
> -tests_x86_64_system_quick = [
> +tests_x86_64_system_quick = \
> +  (host_os == 'linux' ? ['memlock'] : []) + \

IMHO this should be done with a decorator in the test program, so
we keep all conditions in the source, not meson.

> +[
>    'bad_vmstate',
>    'cpu_model_versions',
>    'cpu_queries',
>    'mem_addr_space',
> -  'memlock',
>    'migration',
>    'pc_cpu_hotplug_props',
>    'virtio_version',
> -- 
> 2.52.0
> 
> 

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|