From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DEC1FD30CDB for ; Wed, 14 Jan 2026 10:21:30 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vfy05-0004j8-4E; Wed, 14 Jan 2026 05:21:18 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vfxzu-0004iS-Jt for qemu-devel@nongnu.org; Wed, 14 Jan 2026 05:21:06 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vfxzn-0002wz-SF for qemu-devel@nongnu.org; Wed, 14 Jan 2026 05:21:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1768386058; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BkQRkqOX7RtJbx5XQv72TClBEDfkqmsL0VH8yjFv8ZI=; b=BgtrLkryHrk/J4RY5OJCtVRZAh19IWrS72HRvk7xK/p0mw5E8n+KrVuCqZrhdqEonU9rXw funudlYVOjOMFhkl3OqSj3D9YFgUVFn3nsCR5i6vl1jjHD7WWTk08HON0x+WcVic5VZKRD kFgWkFyERxcAP3AJPJYRRPWiU4vwen4= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-651-kbiVI3huNhC5d9XpGUJ7Jg-1; Wed, 14 Jan 2026 05:20:57 -0500 X-MC-Unique: kbiVI3huNhC5d9XpGUJ7Jg-1 X-Mimecast-MFC-AGG-ID: kbiVI3huNhC5d9XpGUJ7Jg_1768386056 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 5836F1956061; Wed, 14 Jan 2026 10:20:56 +0000 (UTC) Received: from redhat.com (unknown [10.42.28.41]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id BE83A19560A7; Wed, 14 Jan 2026 10:20:53 +0000 (UTC) Date: Wed, 14 Jan 2026 10:20:50 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Thomas Huth Cc: qemu-devel@nongnu.org, Peter Xu , Fabiano Rosas , Paolo Bonzini , Zhao Liu Subject: Re: [PATCH] tests/functional/x86_64: Use the right Python interpreter & fix format string Message-ID: References: <20260114101101.36225-1-thuth@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260114101101.36225-1-thuth@redhat.com> User-Agent: Mutt/2.2.14 (2025-02-20) X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Wed, Jan 14, 2026 at 11:11:01AM +0100, Thomas Huth wrote: > From: Thomas Huth > > The bad_vmstate test currently fails if the host does not have a "python3" > binary in $PATH because the vmstate-static-checker.py script is executed > directly, so that it gets run via its shebang line. Use the right Python > interpreter from sys.executable to fix this problem. > > Additionally, there was another bug with the formatting of the error > message in case of failures: The "+" operator can only concatenate strings, > but not strings with integers. Use a proper format string here instead. > > Signed-off-by: Thomas Huth > --- > tests/functional/x86_64/test_bad_vmstate.py | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|