All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Xu <peterx@redhat.com>
To: Prasad Pandit <ppandit@redhat.com>
Cc: qemu-devel@nongnu.org, Fabiano Rosas <farosas@suse.de>,
	Lukas Straub <lukasstraub2@web.de>,
	Juraj Marcin <jmarcin@redhat.com>
Subject: Re: [PATCH 2/2] tests/migration-test: Remove postcopy_recovery_fail_stage from MigrateCommon
Date: Wed, 14 Jan 2026 10:36:04 -0500	[thread overview]
Message-ID: <aWe35LsGn_68MIUu@x1.local> (raw)
In-Reply-To: <CAE8KmOzPHTf6eaufn3dWTJJ2nsifdxZzwENK2hD_LZLGiE-pcQ@mail.gmail.com>

On Thu, Jan 08, 2026 at 03:11:32PM +0530, Prasad Pandit wrote:
> On Wed, 7 Jan 2026 at 22:45, Peter Xu <peterx@redhat.com> wrote:
> > On Wed, Jan 07, 2026 at 05:07:40PM +0530, Prasad Pandit wrote:
> > > On Wed, 7 Jan 2026 at 02:04, Peter Xu <peterx@redhat.com> wrote:
> > > > The parameter can be instead passed into the function.
> > >
> > > * It'll help to include - why? pass the parameter instead.
> >
> > I want to remove special and unnecessary fields in MigrateCommon struct.
> >
> > I'll add a sentence when repost.
> ...
> > > * To keep it consistent, maybe we can call the variable 'stage' as above?
> >
> > Personally I prefer fail_stage, e.g. fail_stage=NONE means it never fails.
> > stage==NONE is less clear.
> 
> * Let's make it fail_stage in both places then?

Could you explain what's the 2nd place to use it besides the parameter in
test_postcopy_recovery_common()?

> 
> Reviewed-by: Prasad Pandit <pjp@fedoraproject.org>

Thanks,

> 
> Thank you.
> ---
>   - Prasad
> 

-- 
Peter Xu



  reply	other threads:[~2026-01-14 15:36 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-06 20:33 [PATCH 0/2] tests/migration-test: Small cleanup series on postcopy tests Peter Xu
2026-01-06 20:33 ` [PATCH 1/2] tests/migration-test: Remove postcopy_data from MigrateCommon Peter Xu
2026-01-07 11:23   ` Prasad Pandit
2026-01-07 17:12     ` Peter Xu
2026-01-08  9:38       ` Prasad Pandit
2026-01-14 15:34         ` Peter Xu
2026-01-15 11:11           ` Prasad Pandit
2026-01-06 20:33 ` [PATCH 2/2] tests/migration-test: Remove postcopy_recovery_fail_stage " Peter Xu
2026-01-07 11:37   ` Prasad Pandit
2026-01-07 17:14     ` Peter Xu
2026-01-08  9:41       ` Prasad Pandit
2026-01-14 15:36         ` Peter Xu [this message]
2026-01-15 11:57           ` Prasad Pandit
2026-01-15 13:44             ` Peter Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aWe35LsGn_68MIUu@x1.local \
    --to=peterx@redhat.com \
    --cc=farosas@suse.de \
    --cc=jmarcin@redhat.com \
    --cc=lukasstraub2@web.de \
    --cc=ppandit@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.