From: Sean Christopherson <seanjc@google.com>
To: "Naveen N Rao (AMD)" <naveen@kernel.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
Maxim Levitsky <mlevitsk@redhat.com>,
Vasant Hegde <vasant.hegde@amd.com>,
Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
Subject: Re: [RFC PATCH 2/3] KVM: SVM: Fix IRQ window inhibit handling across multiple vCPUs
Date: Wed, 14 Jan 2026 12:19:54 -0800 [thread overview]
Message-ID: <aWf6avEdiBPcIiyN@google.com> (raw)
In-Reply-To: <aWf0zQ6vA0Hmon2r@google.com>
On Wed, Jan 14, 2026, Sean Christopherson wrote:
> Finally mustered up the brainpower to land this series :-)
>
> On Fri, Jul 18, 2025, Naveen N Rao (AMD) wrote:
> > diff --git a/arch/x86/include/asm/kvm_host.h b/arch/x86/include/asm/kvm_host.h
> > index f19a76d3ca0e..b781b4f1d304 100644
> > --- a/arch/x86/include/asm/kvm_host.h
> > +++ b/arch/x86/include/asm/kvm_host.h
> > @@ -1395,6 +1395,10 @@ struct kvm_arch {
> > struct kvm_pit *vpit;
> > #endif
> > atomic_t vapics_in_nmi_mode;
> > +
> > + /* Keep this in a cacheline separate from apicv_update_lock */
>
> A comment won't suffice. To isolate what we want to isolate, tag things with
> __aligned(). Ideally we would use __cacheline_aligned_in_smp, but AFAIK that
> can't be used within a struct as it uses .section tags, :-(
Gah, finally found what I was looking for: ____cacheline_aligned
next prev parent reply other threads:[~2026-01-14 20:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-18 6:43 [RFC PATCH 0/3] KVM: SVM: Fix IRQ window inhibit handling Naveen N Rao (AMD)
2025-07-18 6:43 ` [RFC PATCH 1/3] KVM: SVM: Fix clearing IRQ window inhibit with nested guests Naveen N Rao (AMD)
2025-07-18 6:43 ` [RFC PATCH 2/3] KVM: SVM: Fix IRQ window inhibit handling across multiple vCPUs Naveen N Rao (AMD)
2026-01-14 19:55 ` Sean Christopherson
2026-01-14 20:19 ` Sean Christopherson [this message]
2026-01-22 14:49 ` Naveen N Rao
2026-01-23 19:55 ` Sean Christopherson
2025-07-18 6:43 ` [RFC PATCH 3/3] KVM: SVM: Optimize IRQ window inhibit handling Naveen N Rao (AMD)
2025-09-09 14:30 ` [RFC PATCH 0/3] KVM: SVM: Fix " Naveen N Rao
2025-09-09 15:34 ` Sean Christopherson
2025-09-10 12:30 ` Naveen N Rao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aWf6avEdiBPcIiyN@google.com \
--to=seanjc@google.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mlevitsk@redhat.com \
--cc=naveen@kernel.org \
--cc=pbonzini@redhat.com \
--cc=suravee.suthikulpanit@amd.com \
--cc=vasant.hegde@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.