From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Petre Rodan <petre.rodan@subdimension.ro>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Andreas Klinger" <ak@it-klinger.de>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
"Jonathan Cameron" <Jonathan.Cameron@huawei.com>
Subject: Re: [PATCH v3 03/13] iio: pressure: mprls0025pa: fix interrupt flag
Date: Wed, 14 Jan 2026 19:07:54 +0200 [thread overview]
Message-ID: <aWfNauwMv1EFczD8@smile.fi.intel.com> (raw)
In-Reply-To: <20260114-mprls_cleanup-v3-3-bc7f1c2957c2@subdimension.ro>
On Wed, Jan 14, 2026 at 06:55:32PM +0200, Petre Rodan wrote:
> Interrupt falling/rising flags should only be defined in the device tree.
...
> if (data->irq > 0) {
> - ret = devm_request_irq(dev, data->irq, mpr_eoc_handler,
> - IRQF_TRIGGER_RISING,
> - dev_name(dev),
> - data);
> + ret = devm_request_irq(dev, data->irq, mpr_eoc_handler, 0,
> + dev_name(dev), data);
> if (ret)
> return dev_err_probe(dev, ret,
> "request irq %d failed\n", data->irq);
Also drop this (in a separate change?) as devm_request_*irq*() prints the
similar one.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-01-14 17:07 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-14 16:55 [PATCH v3 00/13] iio: pressure: mprls0025pa: driver code cleanup Petre Rodan
2026-01-14 16:55 ` [PATCH v3 01/13] iio: pressure: mprls0025pa: fix spi_transfer struct initialisation Petre Rodan
2026-01-14 16:55 ` [PATCH v3 02/13] iio: pressure: mprls0025pa: fix SPI CS delay violation Petre Rodan
2026-01-14 16:55 ` [PATCH v3 03/13] iio: pressure: mprls0025pa: fix interrupt flag Petre Rodan
2026-01-14 17:07 ` Andy Shevchenko [this message]
2026-01-14 16:55 ` [PATCH v3 04/13] iio: pressure: mprls0025pa: fix scan_type struct Petre Rodan
2026-01-14 16:55 ` [PATCH v3 05/13] iio: pressure: mprls0025pa: fix pressure calculation Petre Rodan
2026-01-14 16:55 ` [PATCH v3 06/13] iio: pressure: mprls0025pa: cleanup includes Petre Rodan
2026-01-14 16:55 ` [PATCH v3 07/13] iio: pressure: mprls0025pa: remove redundant declarations Petre Rodan
2026-01-14 16:55 ` [PATCH v3 08/13] iio: pressure: mprls0025pa: rename buffer variable Petre Rodan
2026-01-14 16:55 ` [PATCH v3 09/13] iio: pressure: mprls0025pa: introduce tx buffer Petre Rodan
2026-01-14 16:55 ` [PATCH v3 10/13] iio: pressure: mprls0025pa: move memset to core Petre Rodan
2026-01-14 16:55 ` [PATCH v3 11/13] iio: pressure: mprls0025pa: stricter checks for the status byte Petre Rodan
2026-01-14 16:55 ` [PATCH v3 12/13] iio: pressure: mprls0025pa: change measurement sequence Petre Rodan
2026-01-14 16:55 ` [PATCH v3 13/13] iio: pressure: mprls0025pa: add copyright line Petre Rodan
2026-01-14 17:09 ` [PATCH v3 00/13] iio: pressure: mprls0025pa: driver code cleanup Andy Shevchenko
2026-01-16 18:56 ` Petre Rodan
2026-01-16 19:01 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aWfNauwMv1EFczD8@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=ak@it-klinger.de \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=petre.rodan@subdimension.ro \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.