All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
	qemu-block@nongnu.org,  Hanna Reitz <hreitz@redhat.com>,
	qemu-devel@nongnu.org
Subject: Re: [PATCH] tests/qemu-iotests: Mark 182 as Linux-only
Date: Wed, 14 Jan 2026 12:42:57 -0600	[thread overview]
Message-ID: <aWfjO5TxVQ0szLDy@redhat.com> (raw)
In-Reply-To: <20260113141744.97469-1-thuth@redhat.com>

On Tue, Jan 13, 2026 at 03:17:44PM +0100, Thomas Huth wrote:
> From: Thomas Huth <thuth@redhat.com>
> 
> Running test 182 on FreeBSD fails with this error message in the output:
> 
>  +warning: File lock requested but OFD locking syscall is unavailable, falling back to POSIX file locks
>  +Due to the implementation, locks can be lost unexpectedly.
> 
> OFD locks seem to be only available on Linux, so let's mark this
> test as Linux-only to silence the failure.

OFD locks are part of POSIX now, so eventually new-enough BSD will
have them.  Is it worth trying to be more specific and testing for the
actual feature that we are depending on, rather than just limiting the
test to an early-adopter OS?  That said, I don't have any quick ideas
on how to do a more-specific feature test, so I don't mind this going
in as-is; we already know BSD gets less coverage for other reasons.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.
Virtualization:  qemu.org | libguestfs.org



      parent reply	other threads:[~2026-01-14 18:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-13 14:17 [PATCH] tests/qemu-iotests: Mark 182 as Linux-only Thomas Huth
2026-01-13 14:34 ` Daniel P. Berrangé
2026-01-14 18:42 ` Eric Blake [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aWfjO5TxVQ0szLDy@redhat.com \
    --to=eblake@redhat.com \
    --cc=hreitz@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.