All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alejandro Colomar <alx@kernel.org>
To: Jeff Layton <jlayton@kernel.org>
Cc: linux-man@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH man-pages v2 2/2] man/man2const: clean up the F_GETLEASE manpage
Date: Wed, 14 Jan 2026 20:48:10 +0100	[thread overview]
Message-ID: <aWfy0citkX0b1TkU@devuan> (raw)
In-Reply-To: <20260114-master-v2-2-719f5b47dfe2@kernel.org>

[-- Attachment #1: Type: text/plain, Size: 2622 bytes --]

Hi Jeff,

On Wed, Jan 14, 2026 at 12:35:25PM -0500, Jeff Layton wrote:
> - Remove a redundant subsection heading
> - Add in the lease-specific error codes
> - Clean up some semantic newline warts
> 
> Signed-off-by: Jeff Layton <jlayton@kernel.org>

Thanks!  I've applied it, and split it in two commits.


Have a lovely night!
Alex

> ---
>  man/man2const/F_GETLEASE.2const | 22 +++++++++++++++++-----
>  1 file changed, 17 insertions(+), 5 deletions(-)
> 
> diff --git a/man/man2const/F_GETLEASE.2const b/man/man2const/F_GETLEASE.2const
> index 10f7ac7a89a70b83be10a381462d879cff813471..e841f7f8c7c64ba8c6868e68d493716040e3dec2 100644
> --- a/man/man2const/F_GETLEASE.2const
> +++ b/man/man2const/F_GETLEASE.2const
> @@ -20,7 +20,6 @@ Standard C library
>  .BI "int fcntl(int " fd ", F_GETLEASE);"
>  .fi
>  .SH DESCRIPTION
> -.SS Leases
>  .B F_SETLEASE
>  and
>  .B F_GETLEASE
> @@ -43,7 +42,7 @@ values is specified in the integer
>  .RS
>  .TP
>  .B F_RDLCK
> -Take out a read lease.
> +Establish a read lease.
>  This will cause the calling process to be notified when
>  the file is opened for writing or is truncated.
>  .\" The following became true in Linux 2.6.10:
> @@ -52,7 +51,7 @@ A read lease can be placed only on a file descriptor that
>  is opened read-only.
>  .TP
>  .B F_WRLCK
> -Take out a write lease.
> +Establish a write lease.
>  This will cause the caller to be notified when
>  the file is opened for reading or writing or is truncated.
>  A write lease may be placed on a file only if there are no
> @@ -86,8 +85,11 @@ capability may take out leases on arbitrary files.
>  Indicates what type of lease is associated with the file descriptor
>  .I fd
>  by returning either
> -.BR F_RDLCK ", " F_WRLCK ", or " F_UNLCK ,
> -indicating, respectively, a read lease , a write lease, or no lease.
> +.BR F_RDLCK,
> +.BR F_WRLCK,
> +or
> +.BR F_UNLCK,
> +indicating, respectively, a read lease, a write lease, or no lease.
>  .I arg
>  is ignored.
>  .P
> @@ -196,6 +198,16 @@ is set to indicate the error.
>  .SH ERRORS
>  See
>  .BR fcntl (2).
> +These operations can also fail with the following error codes:
> +.TP
> +.B EAGAIN
> +The operation is prohibited because the file is open in a way that conflicts with the requested lease.
> +.TP
> +.B EINVAL
> +The operation is prohibited because the underlying filesystem doesn't support leases,
> +or because
> +.I fd
> +does not represent a regular file.
>  .SH STANDARDS
>  Linux.
>  .SH HISTORY
> 
> -- 
> 2.52.0
> 

-- 
<https://www.alejandro-colomar.es>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2026-01-14 19:48 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-14 17:35 [PATCH man-pages v2 0/2] man/man2const: clean up F_GETLEASE and add F_SETDELEG/F_GETDELEG manpages Jeff Layton
2026-01-14 17:35 ` [PATCH man-pages v2 1/2] man/man2const: document the new F_SETDELEG and F_GETDELEG constants Jeff Layton
2026-01-14 17:50   ` G. Branden Robinson
2026-01-14 18:19     ` Alejandro Colomar
2026-01-18 15:40   ` Alejandro Colomar
2026-01-14 17:35 ` [PATCH man-pages v2 2/2] man/man2const: clean up the F_GETLEASE manpage Jeff Layton
2026-01-14 19:48   ` Alejandro Colomar [this message]
2026-01-18 15:42 ` [PATCH v3] man/man2const/F_[SG]ETDELEG.2const, man/man2/fcntl.2: Document F_SETDELEG and F_GETDELEG Alejandro Colomar
2026-01-20 14:39   ` Jeff Layton
2026-01-20 15:12     ` Alejandro Colomar
2026-01-20 15:30       ` Jeff Layton
2026-01-20 15:58         ` Alejandro Colomar
2026-01-23 15:36           ` Alejandro Colomar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aWfy0citkX0b1TkU@devuan \
    --to=alx@kernel.org \
    --cc=jlayton@kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-man@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.