All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lorenzo Bianconi <lorenzo@kernel.org>
To: Sayantan Nandy <sayantann11@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org, netdev@vger.kernel.org,
	sayantan.nandy@airoha.com, bread.hsu@airoha.com,
	kuldeep.malik@airoha.com, aniket.negi@airoha.com,
	rajeev.kumar@airoha.com
Subject: Re: [PATCH] net: airoha_eth: increase max mtu to 9220 for DSA jumbo frames
Date: Thu, 15 Jan 2026 14:40:03 +0100	[thread overview]
Message-ID: <aWjuM3Ov0e45QyW4@lore-desk> (raw)
In-Reply-To: <20260115084837.52307-1-sayantann11@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1215 bytes --]

> The Industry standard for jumbo frame MTU is 9216 bytes. When using DSA
> sub-system, an extra 4 byte tag is added to each frame. To allow users
> to set the standard 9216-byte MTU via ifconfig,increase AIROHA_MAX_MTU
> to 9220 bytes (9216+4).
> 
> Signed-off-by: Sayantan Nandy <sayantann11@gmail.com>

I think the patch is fine, but here you are missing to specify this is v2
and this patch targets net-next. Moreover, please wait 24h before reposting
a new version of the same patch.

Regards,
Lorenzo

> ---
>  drivers/net/ethernet/airoha/airoha_eth.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/airoha/airoha_eth.h b/drivers/net/ethernet/airoha/airoha_eth.h
> index fbbc58133364..20e602d61e61 100644
> --- a/drivers/net/ethernet/airoha/airoha_eth.h
> +++ b/drivers/net/ethernet/airoha/airoha_eth.h
> @@ -21,7 +21,7 @@
>  #define AIROHA_MAX_NUM_IRQ_BANKS	4
>  #define AIROHA_MAX_DSA_PORTS		7
>  #define AIROHA_MAX_NUM_RSTS		3
> -#define AIROHA_MAX_MTU			9216
> +#define AIROHA_MAX_MTU			9220
>  #define AIROHA_MAX_PACKET_SIZE		2048
>  #define AIROHA_NUM_QOS_CHANNELS		4
>  #define AIROHA_NUM_QOS_QUEUES		8
> -- 
> 2.43.0
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

  parent reply	other threads:[~2026-01-15 13:40 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-15  8:48 [PATCH] net: airoha_eth: increase max mtu to 9220 for DSA jumbo frames Sayantan Nandy
2026-01-15  9:39 ` Benjamin Larsson
2026-01-15 13:40 ` Lorenzo Bianconi [this message]
2026-01-16  3:05   ` Jakub Kicinski
2026-01-15 17:41 ` Andrew Lunn
2026-01-15 19:10   ` Benjamin Larsson
2026-01-16  1:08     ` Andrew Lunn
2026-01-16 10:48       ` Benjamin Larsson
2026-01-16 14:21         ` Andrew Lunn
     [not found]           ` <CADJVu8XP_wBudwOrT1OLhcZ3-9Qoci8FQzw+yyxnogiC2Asx5w@mail.gmail.com>
2026-01-16 14:56             ` Andrew Lunn
2026-01-16 15:05               ` Benjamin Larsson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aWjuM3Ov0e45QyW4@lore-desk \
    --to=lorenzo@kernel.org \
    --cc=aniket.negi@airoha.com \
    --cc=bread.hsu@airoha.com \
    --cc=kuldeep.malik@airoha.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=netdev@vger.kernel.org \
    --cc=rajeev.kumar@airoha.com \
    --cc=sayantan.nandy@airoha.com \
    --cc=sayantann11@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.