From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: "Yury Norov (NVIDIA)" <yury.norov@gmail.com>
Cc: "Lucas De Marchi" <lucas.demarchi@intel.com>,
"Thomas Hellström" <thomas.hellstrom@linux.intel.com>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>,
"Harish Chegondi" <harish.chegondi@intel.com>,
intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org,
"Thomas Gleixner" <tglx@linutronix.de>
Subject: Re: [PATCH] drm/xe/eustall: use bitmap_weighted_or() in xe_eu_stall_stream_init()
Date: Thu, 15 Jan 2026 10:29:33 -0500 [thread overview]
Message-ID: <aWkH3erGBlWQueX7@intel.com> (raw)
In-Reply-To: <aWEm69i8r6VJtrsx@intel.com>
On Fri, Jan 09, 2026 at 11:03:55AM -0500, Rodrigo Vivi wrote:
> On Mon, Dec 15, 2025 at 07:02:58PM -0500, Yury Norov (NVIDIA) wrote:
> > Commit 437cb3ded2503 ("cpumask: Introduce cpumask_weighted_or()") added
> > the new helper, which fits well here. Use it.
> >
> > Signed-off-by: Yury Norov (NVIDIA) <yury.norov@gmail.com>
>
> Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
>
> (I'm just resending for CI and will merge after the confirmation)
ERROR: modpost: "__bitmap_weighted_or" [drivers/gpu/drm/xe/xe.ko] undefined!
https://patchwork.freedesktop.org/series/159059/
Could you please check and fix this?!
>
> Thanks for the patch and sorry for the delay.
>
> > ---
> > drivers/gpu/drm/xe/xe_eu_stall.c | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/xe/xe_eu_stall.c b/drivers/gpu/drm/xe/xe_eu_stall.c
> > index b896b7ff5900..8bd4307afbbd 100644
> > --- a/drivers/gpu/drm/xe/xe_eu_stall.c
> > +++ b/drivers/gpu/drm/xe/xe_eu_stall.c
> > @@ -737,9 +737,9 @@ static int xe_eu_stall_stream_init(struct xe_eu_stall_data_stream *stream,
> > u32 vaddr_offset;
> > int ret;
> >
> > - bitmap_or(all_xecores, gt->fuse_topo.g_dss_mask, gt->fuse_topo.c_dss_mask,
> > - XE_MAX_DSS_FUSE_BITS);
> > - num_xecores = bitmap_weight(all_xecores, XE_MAX_DSS_FUSE_BITS);
> > + num_xecores = bitmap_weighted_or(all_xecores, gt->fuse_topo.g_dss_mask,
> > + gt->fuse_topo.c_dss_mask,
> > + XE_MAX_DSS_FUSE_BITS);
> > last_xecore = xe_gt_topology_mask_last_dss(all_xecores) + 1;
> >
> > max_wait_num_reports = num_data_rows(per_xecore_buf_size * num_xecores);
> > --
> > 2.43.0
> >
prev parent reply other threads:[~2026-01-15 15:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-16 0:02 [PATCH] drm/xe/eustall: use bitmap_weighted_or() in xe_eu_stall_stream_init() Yury Norov (NVIDIA)
2025-12-16 4:11 ` ✗ LGCI.VerificationFailed: failure for " Patchwork
2026-01-09 1:18 ` [PATCH] " Yury Norov
2026-01-09 16:03 ` Rodrigo Vivi
2026-01-15 15:29 ` Rodrigo Vivi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aWkH3erGBlWQueX7@intel.com \
--to=rodrigo.vivi@intel.com \
--cc=airlied@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=harish.chegondi@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lucas.demarchi@intel.com \
--cc=simona@ffwll.ch \
--cc=tglx@linutronix.de \
--cc=thomas.hellstrom@linux.intel.com \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.