All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Horman <horms@kernel.org>
To: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: "Maciej W. Rozycki" <macro@orcam.me.uk>,
	Ethan Nelson-Moore <enelsonmoore@gmail.com>,
	linux-mips@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH net-next] pcnet32: remove VLB support
Date: Thu, 15 Jan 2026 17:08:17 +0000	[thread overview]
Message-ID: <aWkfAQNO8PQes7sV@horms.kernel.org> (raw)
In-Reply-To: <aWVxAVHWTOgEcwAD@alpha.franken.de>

On Mon, Jan 12, 2026 at 11:09:05PM +0100, Thomas Bogendoerfer wrote:
> On Sun, Jan 11, 2026 at 12:40:56AM +0000, Maciej W. Rozycki wrote:
> > [+cc Thomas, linux-mips]
> > 
> > On Fri, 9 Jan 2026, Simon Horman wrote:
> > 
> > > > This allows the code managing device instances to be simplified
> > > > significantly. The VLB bus is very obsolete and last appeared on
> > > > P5 Pentium-era hardware. Support for it has been removed from
> > > > other drivers, and it is highly unlikely anyone is using it with
> > > > modern Linux kernels.
> > > > 
> > > > Signed-off-by: Ethan Nelson-Moore <enelsonmoore@gmail.com>
> > > 
> > > Hi Ethan,
> > > 
> > > I don't think this driver has received much attention for some time.
> > > So, unless you have hardware to test changes on, I would suggest
> > > either leaving it alone or, if we suspect there are no users,
> > > removing it.
> > 
> >  You mean discarding the whole of drivers/net/ethernet/amd/pcnet32.c?  If 
> > so, then it's a hard NAK from me.  It's the onboard/netboot interface of 
> > the MIPS Malta platform and it continues being used regularly, primarily 
> > with QEMU setups, although I have actual Malta hardware in my lab too, 
> > usually running 24/7.  It's one of the primary MIPS plaforms, cf. 
> > arch/mips/configs/malta_defconfig.
> 
> I have a few more MIPS systems with PCnet32 chip on board. And this
> driver was the first network driver for VMware. I see no reason to
> remove it as it simply works.

Understood. Thanks for the valuable feedback.

  reply	other threads:[~2026-01-15 17:08 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-07  7:18 [PATCH net-next] pcnet32: remove VLB support Ethan Nelson-Moore
2026-01-09 18:04 ` Simon Horman
2026-01-11  0:40   ` Maciej W. Rozycki
2026-01-12 22:09     ` Thomas Bogendoerfer
2026-01-15 17:08       ` Simon Horman [this message]
2026-01-15 17:07     ` Simon Horman
2026-01-15 21:28       ` Maciej W. Rozycki
2026-01-15 22:29 ` David Laight
2026-01-15 22:40   ` Maciej W. Rozycki
2026-01-25  7:22   ` Ethan Nelson-Moore

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aWkfAQNO8PQes7sV@horms.kernel.org \
    --to=horms@kernel.org \
    --cc=enelsonmoore@gmail.com \
    --cc=linux-mips@vger.kernel.org \
    --cc=macro@orcam.me.uk \
    --cc=netdev@vger.kernel.org \
    --cc=tsbogend@alpha.franken.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.