From: Kiryl Shutsemau <kas@kernel.org>
To: "David Hildenbrand (Red Hat)" <david@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Muchun Song <muchun.song@linux.dev>,
Matthew Wilcox <willy@infradead.org>,
Usama Arif <usamaarif642@gmail.com>,
Frank van der Linden <fvdl@google.com>,
Oscar Salvador <osalvador@suse.de>,
Mike Rapoport <rppt@kernel.org>,
Vlastimil Babka <vbabka@suse.cz>,
Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
Zi Yan <ziy@nvidia.com>, Baoquan He <bhe@redhat.com>,
Michal Hocko <mhocko@suse.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Jonathan Corbet <corbet@lwn.net>,
kernel-team@meta.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org
Subject: Re: [PATCHv3 02/15] mm: Move MAX_FOLIO_ORDER definition to mmzone.h
Date: Thu, 15 Jan 2026 17:26:58 +0000 [thread overview]
Message-ID: <aWkivSMMKX3AGdMw@thinkstation> (raw)
In-Reply-To: <bf788cfe-ac2e-4ffc-9349-64d9c36bf072@kernel.org>
On Thu, Jan 15, 2026 at 05:48:20PM +0100, David Hildenbrand (Red Hat) wrote:
> On 1/15/26 17:35, David Hildenbrand (Red Hat) wrote:
> > On 1/15/26 15:45, Kiryl Shutsemau wrote:
> > > Move MAX_FOLIO_ORDER definition from mm.h to mmzone.h.
> >
> > Why should that belong to mmzone.h ? Semantically doesn't make sense, no?
>
> To clarify, I would have moved it to something more folio-type specific, not
> something buddy/zone specific.
>
> I guess page-flags.h + mm.h are our dumping ground for folio handling. I
> would have moved it to the former.
I moved it next to MAX_PAGE_ORDER definition which seemed to be logical.
Moving MAX_PAGE_ORDER around is much more risky (will likely generate a
lot of build bugs) and outside of the scope of the patchset.
I think wherever they will be moved, it should be moved together.
> Likely we want some folio.h in some distant future.
Sounds like a plan! :P
> Acked-by: David Hildenbrand (Red Hat) <david@kernel.org>
Thanks!
--
Kiryl Shutsemau / Kirill A. Shutemov
next prev parent reply other threads:[~2026-01-15 17:27 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-15 14:45 [PATCHv3 00/15] mm: Eliminate fake head pages from vmemmap optimization Kiryl Shutsemau
2026-01-15 14:45 ` [PATCHv3 01/15] x86/vdso32: Prepare for <linux/pgtable.h> inclusion Kiryl Shutsemau
2026-01-15 14:45 ` [PATCHv3 02/15] mm: Move MAX_FOLIO_ORDER definition to mmzone.h Kiryl Shutsemau
2026-01-15 16:35 ` David Hildenbrand (Red Hat)
2026-01-15 16:48 ` David Hildenbrand (Red Hat)
2026-01-15 17:26 ` Kiryl Shutsemau [this message]
2026-01-15 17:45 ` David Hildenbrand (Red Hat)
2026-01-15 14:45 ` [PATCHv3 03/15] mm: Change the interface of prep_compound_tail() Kiryl Shutsemau
2026-01-15 14:45 ` [PATCHv3 04/15] mm: Rename the 'compound_head' field in the 'struct page' to 'compound_info' Kiryl Shutsemau
2026-01-15 14:45 ` [PATCHv3 05/15] mm: Move set/clear_compound_head() next to compound_head() Kiryl Shutsemau
2026-01-15 14:45 ` [PATCHv3 06/15] mm: Rework compound_head() for power-of-2 sizeof(struct page) Kiryl Shutsemau
2026-01-15 14:45 ` [PATCHv3 07/15] mm: Make page_zonenum() use head page Kiryl Shutsemau
2026-01-15 14:45 ` [PATCHv3 08/15] mm/sparse: Check memmap alignment for compound_info_has_mask() Kiryl Shutsemau
2026-01-15 14:45 ` [PATCHv3 09/15] mm/hugetlb: Refactor code around vmemmap_walk Kiryl Shutsemau
2026-01-19 10:04 ` Muchun Song
2026-01-19 15:26 ` Kiryl Shutsemau
2026-01-15 14:45 ` [PATCHv3 10/15] mm/hugetlb: Remove fake head pages Kiryl Shutsemau
2026-01-15 16:49 ` David Hildenbrand (Red Hat)
2026-01-15 17:23 ` Kiryl Shutsemau
2026-01-15 17:41 ` David Hildenbrand (Red Hat)
2026-01-15 18:58 ` Kiryl Shutsemau
2026-01-15 19:33 ` David Hildenbrand (Red Hat)
2026-01-15 19:46 ` David Hildenbrand (Red Hat)
2026-01-16 2:38 ` Muchun Song
2026-01-16 15:52 ` Kiryl Shutsemau
2026-01-17 2:38 ` Muchun Song
2026-01-19 15:15 ` Kiryl Shutsemau
2026-01-20 2:50 ` Muchun Song
2026-01-16 16:18 ` [PATCHv3.1 " Kiryl Shutsemau
2026-01-15 14:45 ` [PATCHv3 11/15] mm: Drop fake head checks Kiryl Shutsemau
2026-01-15 14:45 ` [PATCHv3 12/15] hugetlb: Remove VMEMMAP_SYNCHRONIZE_RCU Kiryl Shutsemau
2026-01-15 14:45 ` [PATCHv3 13/15] mm/hugetlb: Remove hugetlb_optimize_vmemmap_key static key Kiryl Shutsemau
2026-01-15 14:46 ` [PATCHv3 14/15] mm: Remove the branch from compound_head() Kiryl Shutsemau
2026-01-15 14:46 ` [PATCHv3 15/15] hugetlb: Update vmemmap_dedup.rst Kiryl Shutsemau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aWkivSMMKX3AGdMw@thinkstation \
--to=kas@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=bhe@redhat.com \
--cc=corbet@lwn.net \
--cc=david@kernel.org \
--cc=fvdl@google.com \
--cc=hannes@cmpxchg.org \
--cc=kernel-team@meta.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=mhocko@suse.com \
--cc=muchun.song@linux.dev \
--cc=osalvador@suse.de \
--cc=rppt@kernel.org \
--cc=usamaarif642@gmail.com \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.