From: Oleg Nesterov <oleg@redhat.com>
To: tip-bot2 for Oleg Nesterov <tip-bot2@linutronix.de>
Cc: linux-tip-commits@vger.kernel.org,
Paulo Andrade <pandrade@redhat.com>,
"Peter Zijlstra (Intel)" <peterz@infradead.org>,
stable@vger.kernel.org, x86@kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [tip: perf/core] x86/uprobes: Fix XOL allocation failure for 32-bit tasks
Date: Fri, 16 Jan 2026 11:00:23 +0100 [thread overview]
Message-ID: <aWoMN5oCPIl2M2DP@redhat.com> (raw)
In-Reply-To: <176851343815.510.11862479025865189952.tip-bot2@tip-bot2>
On 01/15, tip-bot2 for Oleg Nesterov wrote:
>
> The following commit has been merged into the perf/core branch of tip:
Damn!
thanks Peter, but...
> --- a/arch/x86/kernel/uprobes.c
> +++ b/arch/x86/kernel/uprobes.c
> @@ -1823,3 +1823,27 @@ bool is_uprobe_at_func_entry(struct pt_regs *regs)
>
> return false;
> }
> +
> +#ifdef CONFIG_IA32_EMULATION
> +unsigned long __weak arch_uprobe_get_xol_area(void)
Oh, but x86 version should not be __weak. Copy-and-paste error, sorry :/
What do you want me to do now,
- send V2 ?
- send another s/__weak// patch on top of this hack?
- or perhaps you can fix this yourself?
Oleg.
next prev parent reply other threads:[~2026-01-16 10:00 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-07 14:32 [BUG] x86: 32-bit uprobes are broken Oleg Nesterov
2026-01-07 15:27 ` Peter Zijlstra
2026-01-07 15:52 ` Oleg Nesterov
2026-01-10 15:37 ` Oleg Nesterov
2026-01-11 15:00 ` [PATCH] x86/uprobes: Fix XOL allocation failure for 32-bit tasks Oleg Nesterov
2026-01-12 16:40 ` Peter Zijlstra
2026-01-12 17:40 ` Oleg Nesterov
2026-01-14 13:10 ` Oleg Nesterov
2026-01-15 21:43 ` [tip: perf/core] " tip-bot2 for Oleg Nesterov
2026-01-16 10:00 ` Oleg Nesterov [this message]
2026-01-16 10:41 ` Peter Zijlstra
2026-01-16 10:49 ` tip-bot2 for Oleg Nesterov
2026-01-16 15:27 ` tip-bot2 for Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aWoMN5oCPIl2M2DP@redhat.com \
--to=oleg@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=pandrade@redhat.com \
--cc=peterz@infradead.org \
--cc=stable@vger.kernel.org \
--cc=tip-bot2@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.