From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Yury Norov <ynorov@nvidia.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
Andrew Morton <akpm@linux-foundation.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Christophe Leroy <chleroy@kernel.org>,
Randy Dunlap <rdunlap@infradead.org>,
Ingo Molnar <mingo@kernel.org>,
Jani Nikula <jani.nikula@linux.intel.com>,
Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
David Laight <david.laight@runbox.com>,
Petr Pavlu <petr.pavlu@suse.com>,
Andi Shyti <andi.shyti@kernel.org>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
Tvrtko Ursulin <tursulin@ursulin.net>,
Daniel Gomez <da.gomez@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Danilo Krummrich <dakr@kernel.org>,
Joel Fernandes <joelagnelf@nvidia.com>,
linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org,
dri-devel@lists.freedesktop.org, linux-modules@vger.kernel.org,
linux-trace-kernel@vger.kernel.org,
"Yury Norov (NVIDIA)" <yury.norov@gmail.com>
Subject: Re: [PATCH v5 5/6] tracing: Remove size parameter in __trace_puts()
Date: Fri, 16 Jan 2026 12:41:49 +0200 [thread overview]
Message-ID: <aWoV7cYMHmMpYVRt@smile.fi.intel.com> (raw)
In-Reply-To: <20260116042510.241009-6-ynorov@nvidia.com>
On Thu, Jan 15, 2026 at 11:25:08PM -0500, Yury Norov wrote:
> The __trace_puts() function takes a string pointer and the size of the
> string itself. All users currently simply pass in the strlen() of the
> string it is also passing in. There's no reason to pass in the size.
> Instead have the __trace_puts() function do the strlen() within the
> function itself.
>
> This fixes a header recursion issue where using strlen() in the macro
> calling __trace_puts() requires adding #include <linux/string.h> in order
> to use strlen(). Removing the use of strlen() from the header fixes the
> recursion issue.
I like this change, it unloads the header dependencies from string.h, however
the latter is not that messed up.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-01-16 10:41 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-16 4:25 [PATCH v5 0/6] Unload linux/kernel.h Yury Norov
2026-01-16 4:25 ` [PATCH v5 1/6] kernel.h: drop STACK_MAGIC macro Yury Norov
2026-01-16 4:25 ` [PATCH v5 2/6] moduleparam: include required headers explicitly Yury Norov
2026-01-16 4:25 ` [PATCH v5 3/6] kernel.h: move VERIFY_OCTAL_PERMISSIONS() to sysfs.h Yury Norov
2026-01-16 14:45 ` Greg Kroah-Hartman
2026-01-16 4:25 ` [PATCH v5 4/6] kernel.h: include linux/instruction_pointer.h explicitly Yury Norov
2026-01-16 10:43 ` Andy Shevchenko
2026-01-16 4:25 ` [PATCH v5 5/6] tracing: Remove size parameter in __trace_puts() Yury Norov
2026-01-16 10:41 ` Andy Shevchenko [this message]
2026-01-16 4:25 ` [PATCH v5 6/6] tracing: move tracing declarations from kernel.h to a dedicated header Yury Norov
2026-01-16 10:39 ` [PATCH v5 0/6] Unload linux/kernel.h Andy Shevchenko
2026-01-16 17:06 ` Yury Norov
2026-01-21 14:53 ` Steven Rostedt
2026-01-16 11:54 ` ✓ i915.CI.BAT: success for Unload linux/kernel.h (rev6) Patchwork
2026-01-16 16:58 ` ✓ i915.CI.Full: " Patchwork
2026-01-16 17:32 ` [PATCH v5 0/6] Unload linux/kernel.h Joel Fernandes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aWoV7cYMHmMpYVRt@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=andi.shyti@kernel.org \
--cc=chleroy@kernel.org \
--cc=da.gomez@kernel.org \
--cc=dakr@kernel.org \
--cc=david.laight@runbox.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=joelagnelf@nvidia.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-modules@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=mingo@kernel.org \
--cc=petr.pavlu@suse.com \
--cc=rafael@kernel.org \
--cc=rdunlap@infradead.org \
--cc=rodrigo.vivi@intel.com \
--cc=rostedt@goodmis.org \
--cc=tursulin@ursulin.net \
--cc=ynorov@nvidia.com \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.