From: Brian Masney <bmasney@redhat.com>
To: Haoxiang Li <lihaoxiang@isrc.iscas.ac.cn>
Cc: mturquette@baylibre.com, sboyd@kernel.org,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 6/7] clk: st: clkgen-pll: Remove redundant kfree() in clkgen_c32_pll_setup()
Date: Fri, 16 Jan 2026 10:45:31 -0500 [thread overview]
Message-ID: <aWpdG-wPDbe07yPu@redhat.com> (raw)
In-Reply-To: <20260116113847.1827694-7-lihaoxiang@isrc.iscas.ac.cn>
On Fri, Jan 16, 2026 at 07:38:46PM +0800, Haoxiang Li wrote:
> In clkgen_c32_pll_setup(), pll_name is actually pll_clk -> core->name.
> This variable will be released in clk_unregister() -> __clk_release()
> if some error occurs. Thus kfree(pll_name) will cause a double free.
> Remove this redundant kfree().
>
> Signed-off-by: Haoxiang Li <lihaoxiang@isrc.iscas.ac.cn>
A fixes tag is definitely appropriate here.
Fixes: b9b8e614b580 ("clk: st: Support for PLLs inside ClockGenA(s)")
Reviewed-by: Brian Masney <bmasney@redhat.com>
next prev parent reply other threads:[~2026-01-16 15:45 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-16 11:38 [PATCH 0/7] clk: st: clkgen-pll: Add cleanup in clkgen_c32_pll_setup() and clkgen_odf_register() Haoxiang Li
2026-01-16 11:38 ` [PATCH 1/7] clk: st: clkgen-pll: Fix a memory leak in clkgen_odf_register() Haoxiang Li
2026-01-16 15:29 ` Brian Masney
2026-01-17 10:15 ` Markus Elfring
2026-01-16 11:38 ` [PATCH 2/7] clk: st: clkgen-pll: Rename some variables in clkgen_c32_pll_setup() Haoxiang Li
2026-01-16 15:32 ` Brian Masney
2026-01-17 10:40 ` Markus Elfring
2026-01-16 11:38 ` [PATCH 3/7] " Haoxiang Li
2026-01-16 15:37 ` Brian Masney
2026-01-17 10:47 ` Markus Elfring
2026-01-16 11:38 ` [PATCH 4/7] clk: st: clkgen-pll: Add iounmap() " Haoxiang Li
2026-01-16 15:40 ` Brian Masney
2026-01-17 12:57 ` Markus Elfring
2026-01-16 11:38 ` [PATCH 5/7] clk: st: clkgen-pll: Add clk_unregister for pll_clk " Haoxiang Li
2026-01-16 15:43 ` Brian Masney
2026-01-16 11:38 ` [PATCH 6/7] clk: st: clkgen-pll: Remove redundant kfree() " Haoxiang Li
2026-01-16 15:45 ` Brian Masney [this message]
2026-01-16 11:38 ` [PATCH 7/7] clk: st: clkgen-pll: Add clk_unregister for odf_clk " Haoxiang Li
2026-01-16 15:53 ` Brian Masney
2026-01-17 13:43 ` Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aWpdG-wPDbe07yPu@redhat.com \
--to=bmasney@redhat.com \
--cc=lihaoxiang@isrc.iscas.ac.cn \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.