From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 84102C982D8 for ; Fri, 16 Jan 2026 16:26:54 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 1A8CC82993; Fri, 16 Jan 2026 16:26:54 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id vliazhel-YVr; Fri, 16 Jan 2026 16:26:51 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org CEDC582978 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1768580811; bh=uTNSUuysb6nDLRWNCzQf2cdw4c/lwIxBseFlOWDP2YE=; h=Date:From:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=lDGHJgoxi4rctm67SlJ8hnX+Tm/2T0bIOUEOtKJlZDRQNZOyNd/XKLHCaVBHYUsDe SWIz58NoJqDLqIHR6TAHtoJcxBgpo5yR2fyDQ8fJu9G6pyg/kQMxnJCAhamlXAWDQQ g9bwTpZmc6yVSOnOhC9U7VshYfW/r45WZxnJglo9dI8z/QJyZ+85H0PsnzJPDBZJK9 5984nmyepPkpqODsmoe5vSssFG0Xgu91VWc1VCnMIknjGB++HJK4yK4X+RpwlhGhCj m+9+OrxiU9lCGEjLHrc02H0L0UgUBDI1cUm4cxUtkSjuzHPMze4PBcBlTtxDyenJPl VMJWqGGADwqZg== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp1.osuosl.org (Postfix) with ESMTP id CEDC582978; Fri, 16 Jan 2026 16:26:51 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136]) by lists1.osuosl.org (Postfix) with ESMTP id E90BF223 for ; Fri, 16 Jan 2026 16:26:49 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id D92DD607FE for ; Fri, 16 Jan 2026 16:26:49 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id apT39nfyjS4M for ; Fri, 16 Jan 2026 16:26:49 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2600:3c0a:e001:78e:0:1991:8:25; helo=sea.source.kernel.org; envelope-from=horms@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp3.osuosl.org 4D0B4607FD DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 4D0B4607FD Received: from sea.source.kernel.org (sea.source.kernel.org [IPv6:2600:3c0a:e001:78e:0:1991:8:25]) by smtp3.osuosl.org (Postfix) with ESMTPS id 4D0B4607FD for ; Fri, 16 Jan 2026 16:26:49 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 62EA644215; Fri, 16 Jan 2026 16:26:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 380FCC116C6; Fri, 16 Jan 2026 16:26:47 +0000 (UTC) Date: Fri, 16 Jan 2026 16:26:44 +0000 From: Simon Horman To: Sreedevi Joshi Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, Aleksandr Loktionov Message-ID: References: <20260113180113.2478622-1-sreedevi.joshi@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260113180113.2478622-1-sreedevi.joshi@intel.com> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1768580808; bh=H/MeD4ThwDgkLhQV8hx2BQbg6JkHZVSJTD8llU6KeIU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=lRZai1hi5GnZ7o5B0YlQpG6n3Y2lVrXlZSP6eukJ8jhsgruXFoxluFAsb/E+lS3SG J3cYxlw2Xs5ZH8i29vqcZCDrEwo/quW000za2dDk1wIMG0CP/I5sWUNlP2hzOvR56J u8upsirQ6PfB+B9fxWgBbgKVIWZ/A/rrVEO/xWkwA8foNa3VXPCWoFFQrzih9WzdS7 drcxze0RYqBI4po16pPM3/J7xhZZE4d6n+yI4pbVAL2q3rxJpPxu2E8xzzjjG/MA8f hxku5FYa7DLmzZ4hh8CXy3VKHJsXe/v00aql0VTPgC9L0ELQFk8gxTNwCO49UI3kjk b6YQuM5hzVFqg== X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=lRZai1hi Subject: Re: [Intel-wired-lan] [PATCH iwl-net] idpf: Fix flow rule delete failure due to invalid validation X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Tue, Jan 13, 2026 at 12:01:13PM -0600, Sreedevi Joshi wrote: > When deleting a flow rule using "ethtool -N delete ", > idpf_sideband_action_ena() incorrectly validates fsp->ring_cookie even > though ethtool doesn't populate this field for delete operations. The > uninitialized ring_cookie may randomly match RX_CLS_FLOW_DISC or > RX_CLS_FLOW_WAKE, causing validation to fail and preventing legitimate > rule deletions. Remove the unnecessary sideband action enable check and > ring_cookie validation during delete operations since action validation > is not required when removing existing rules. > > Fixes: ada3e24b84a0 ("idpf: add flow steering support") > Signed-off-by: Sreedevi Joshi > Reviewed-by: Aleksandr Loktionov Thanks, I agree with your analysis. And that the problem was introduced by the cited commit. Reviewed-by: Simon Horman From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 61A7B23EAAB for ; Fri, 16 Jan 2026 16:26:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768580808; cv=none; b=f6IDu9Fa6KRhSyY6WVUxV25M1SghLVLgsWpIxr31rxjN3sP6mrpE7HGKVukbgd7HGV5PxjF5bE/2c+tcTjf6Sd3DRreRtYzHlwxuRScvIf5MiomqKO6G0MX8lQsW9K1Y122Tpy/hb2hlCxSz8oLLAo032uwtOzO7BruVoIdwQX8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768580808; c=relaxed/simple; bh=H/MeD4ThwDgkLhQV8hx2BQbg6JkHZVSJTD8llU6KeIU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=EJpHwLE3Q0+bSr5cEWRvoYp8LBbUjfiX/qHxiyMj/9A6u4rX+O/7K8Y+MyqX6gWsaB+01IwA7J3ZC8z4h8ox9adPw4cxNfggeI61QfYKcBl6SE03hjbW14rUPm0VwABsbW0lnufA53CfMAps5h8QgovniDj6kJw95blYbb2IPSI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=lRZai1hi; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="lRZai1hi" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 380FCC116C6; Fri, 16 Jan 2026 16:26:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1768580808; bh=H/MeD4ThwDgkLhQV8hx2BQbg6JkHZVSJTD8llU6KeIU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=lRZai1hi5GnZ7o5B0YlQpG6n3Y2lVrXlZSP6eukJ8jhsgruXFoxluFAsb/E+lS3SG J3cYxlw2Xs5ZH8i29vqcZCDrEwo/quW000za2dDk1wIMG0CP/I5sWUNlP2hzOvR56J u8upsirQ6PfB+B9fxWgBbgKVIWZ/A/rrVEO/xWkwA8foNa3VXPCWoFFQrzih9WzdS7 drcxze0RYqBI4po16pPM3/J7xhZZE4d6n+yI4pbVAL2q3rxJpPxu2E8xzzjjG/MA8f hxku5FYa7DLmzZ4hh8CXy3VKHJsXe/v00aql0VTPgC9L0ELQFk8gxTNwCO49UI3kjk b6YQuM5hzVFqg== Date: Fri, 16 Jan 2026 16:26:44 +0000 From: Simon Horman To: Sreedevi Joshi Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, Aleksandr Loktionov Subject: Re: [PATCH iwl-net] idpf: Fix flow rule delete failure due to invalid validation Message-ID: References: <20260113180113.2478622-1-sreedevi.joshi@intel.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260113180113.2478622-1-sreedevi.joshi@intel.com> On Tue, Jan 13, 2026 at 12:01:13PM -0600, Sreedevi Joshi wrote: > When deleting a flow rule using "ethtool -N delete ", > idpf_sideband_action_ena() incorrectly validates fsp->ring_cookie even > though ethtool doesn't populate this field for delete operations. The > uninitialized ring_cookie may randomly match RX_CLS_FLOW_DISC or > RX_CLS_FLOW_WAKE, causing validation to fail and preventing legitimate > rule deletions. Remove the unnecessary sideband action enable check and > ring_cookie validation during delete operations since action validation > is not required when removing existing rules. > > Fixes: ada3e24b84a0 ("idpf: add flow steering support") > Signed-off-by: Sreedevi Joshi > Reviewed-by: Aleksandr Loktionov Thanks, I agree with your analysis. And that the problem was introduced by the cited commit. Reviewed-by: Simon Horman