All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Bernd Kuhls <bernd@kuhls.net>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/4] package/util-linux: Remove -lpthread from uuid.pc for non-threaded builds
Date: Fri, 16 Jan 2026 22:32:04 +0100	[thread overview]
Message-ID: <aWquKyF9_zcjKaQf@windsurf> (raw)
In-Reply-To: <20251220170623.155785-1-bernd@kuhls.net>

On Sat, Dec 20, 2025 at 06:06:20PM +0100, Bernd Kuhls wrote:

> +define UTIL_LINUX_POST_EXTRACT_FIXUP
> +	$(SED) 's/-lpthread//' $(@D)/libuuid/uuid.pc.in
> +endef
> +ifneq ($(BR2_TOOLCHAIN_HAS_THREADS),y)
> +UTIL_LINUX_POST_EXTRACT_HOOKS += UTIL_LINUX_POST_EXTRACT_FIXUP
> +endif

Yerk, this is quite ugly. Why don't you fix the actual problem
upstream?

Could you try:

diff --git a/libuuid/uuid.pc.in b/libuuid/uuid.pc.in
index 51929fe80..a40dc6644 100644
--- a/libuuid/uuid.pc.in
+++ b/libuuid/uuid.pc.in
@@ -7,5 +7,5 @@ Name: uuid
 Description: Universally unique id library
 Version: @LIBUUID_VERSION@
 Cflags: -I${includedir}/uuid
-Libs.private: @SOCKET_LIBS@ -lpthread
+Libs.private: @SOCKET_LIBS@ @PTHREAD_LIBS@
 Libs: -L${libdir} -luuid

(Totally untested)

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      parent reply	other threads:[~2026-01-16 21:32 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-20 17:06 [Buildroot] [PATCH 1/4] package/util-linux: Remove -lpthread from uuid.pc for non-threaded builds Bernd Kuhls
2025-12-20 17:06 ` [Buildroot] [PATCH 2/4] package/util-linux: fix nommu build Bernd Kuhls
2025-12-30 16:20   ` Giulio Benetti
2026-01-16 21:35   ` Thomas Petazzoni via buildroot
2025-12-20 17:06 ` [Buildroot] [PATCH 3/4] package/util-linux: add dependency to BR2_USE_MMU when needed Bernd Kuhls
2025-12-30 16:21   ` Giulio Benetti
2026-01-16 21:58   ` Thomas Petazzoni via buildroot
2026-01-28 17:24   ` Arnout Vandecappelle via buildroot
2025-12-20 17:06 ` [Buildroot] [PATCH 4/4] package/util-linux: bump version to 2.41.3 Bernd Kuhls
2025-12-30 16:32   ` Giulio Benetti
2026-01-16 21:58   ` Thomas Petazzoni via buildroot
2025-12-30 16:19 ` [Buildroot] [PATCH 1/4] package/util-linux: Remove -lpthread from uuid.pc for non-threaded builds Giulio Benetti
2026-01-16 21:32 ` Thomas Petazzoni via buildroot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aWquKyF9_zcjKaQf@windsurf \
    --to=buildroot@buildroot.org \
    --cc=bernd@kuhls.net \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.