All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Jonas Jelonek <jelonek.jonas@gmail.com>
Cc: "Andrew Lunn" <andrew@lunn.ch>,
	"Maxime Chevallier" <maxime.chevallier@bootlin.com>,
	"Heiner Kallweit" <hkallweit1@gmail.com>,
	"David S . Miller" <davem@davemloft.net>,
	"Eric Dumazet" <edumazet@google.com>,
	"Jakub Kicinski" <kuba@kernel.org>,
	"Paolo Abeni" <pabeni@redhat.com>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	"Bjørn Mork" <bjorn@mork.no>
Subject: Re: [PATCH net-next v5] net: sfp: extend SMBus support
Date: Sun, 18 Jan 2026 10:08:12 +0000	[thread overview]
Message-ID: <aWyxDI6-sKc6BNQE@shell.armlinux.org.uk> (raw)
In-Reply-To: <91442f3f-0da9-4c52-89ce-2ca0a3188836@gmail.com>

On Sun, Jan 18, 2026 at 10:43:12AM +0100, Jonas Jelonek wrote:
> Looking at the SFP MSA [1], some sentences sound like one could assume
> byte access is needed at least for SFP. In Section B4, there are statements
> like:
> - "The memories are organized as a series of 8-bit data words that can be
>     addressed individually..."
> - "...provides sequential or random access to 8 bit parameters..."
> - "The protocol ... sequentially transmits one or more 8-bit bytes..."
> 
> But that may be too vague and I can't judge if that's a valid argument to not
> care about word-only here.

There's a whole bunch of documents. You also need to look at SFF-8472.
This contains the following paragraph:

 To guarantee coherency of the diagnostic monitoring data, the host is
 required to retrieve any multi-byte fields from the diagnostic
 monitoring data structure (e.g. Rx Power MSB - byte 104 in A2h, Rx
 Power LSB - byte 105 in A2h) by the use of a single two-byte read
 sequence across the 2-wire interface.

Hence why we don't allow hwmon when only byte accesses are available.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!

  reply	other threads:[~2026-01-18 10:08 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-16 11:31 [PATCH net-next v5] net: sfp: extend SMBus support Jonas Jelonek
2026-01-16 13:23 ` Maxime Chevallier
2026-01-16 13:43   ` Jonas Jelonek
2026-01-16 14:00     ` Maxime Chevallier
2026-01-16 14:07     ` Andrew Lunn
2026-01-16 14:16       ` Maxime Chevallier
2026-01-16 14:25         ` Andrew Lunn
2026-01-18  9:43           ` Jonas Jelonek
2026-01-18 10:08             ` Russell King (Oracle) [this message]
2026-01-18 15:36               ` Andrew Lunn
2026-01-18 15:39             ` Andrew Lunn
2026-01-22 10:14               ` Jonas Jelonek
2026-01-22 16:04                 ` Andrew Lunn
2026-01-22 16:22                   ` Russell King (Oracle)
2026-01-16 13:57 ` Russell King (Oracle)
2026-01-19 19:41 ` [net-next,v5] " Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aWyxDI6-sKc6BNQE@shell.armlinux.org.uk \
    --to=linux@armlinux.org.uk \
    --cc=andrew@lunn.ch \
    --cc=bjorn@mork.no \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=hkallweit1@gmail.com \
    --cc=jelonek.jonas@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maxime.chevallier@bootlin.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.