From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 382B9D4A5F4 for ; Sun, 18 Jan 2026 12:19:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=JPsUZz1qCN4Z+0NIOnYDQdDTOdI383zJj56vTlHOznc=; b=kheZ+7PkvsWAS6 2X7ZwX+fBNCOlMkJ3FhJYVxw7ByJHfwRrHs8LBmk3lW++nnXnmgLs2nfXbp1eG5tjf5ou/PAi7/AX OiZm/4rYcdGyFFdY9vM+XcQDxlhqOJQNizovTGDaIZzKvyd/WmJlVsgD8VsBC3OtZ5yt56Rob7HsF Xsmw7N5FNBXz6BQaxFM9eOtfDQW0+dZYSANjsFCkPDHV4JqFOiPlOOkGWNt/IMaGJU1/moKx3da3n 5RQIwYOZKyvPBb8MAzuJiZXXHEPTccgBp6MlJ2aAHydnBuj/hG5Nb2paPtjGymLXYcwc02g1MUBCQ McHsgAr2dB9xpTVAFupw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vhRkE-0000000HYU1-0xJ1; Sun, 18 Jan 2026 12:19:02 +0000 Received: from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vhRkB-0000000HYTK-1XK9 for linux-riscv@lists.infradead.org; Sun, 18 Jan 2026 12:19:01 +0000 Received: by mail-wm1-x32b.google.com with SMTP id 5b1f17b1804b1-4801d24d91bso22180015e9.2 for ; Sun, 18 Jan 2026 04:18:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768738737; x=1769343537; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to; bh=WD1wzEbaoKZKhuZNexa3nkG79kI0GKZ4I1GLpFTxDis=; b=F0OVckZPvZC0rhlkmKVjCtCJn5/NKKEj55XrLLfRpokDciCjqttYI6i+kE2jZKqwdb JSkwtxJ7UdxB067l7NzGz0EUFvCHiC2DGIIv6mN/UpaTVbF54QKeZnSdt9G0qGTQJ99f z/tfSoQy4s96/sw6ln6BcVHIEXGnh8i71b9HfewLEWeTfgQiNFk9GwErlOzTUKNtN5SC HqJaPKR/OYJUm8oGp3uh8rZF00J7K4+ZUeSlc6DTLlinhfid3ze1IAEnZ0l9CU3+FbNS b1cRWgeTmnTJz3m70CqfNBcF0/z7Z9SPSb8dGfmCdtG5XQt/RWzrCUKkM0VT2TXuxGlP 45zA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768738737; x=1769343537; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=WD1wzEbaoKZKhuZNexa3nkG79kI0GKZ4I1GLpFTxDis=; b=vq2boCjL0Npb9hNceZu8X8Pgq+UTlKVAOrEI8cNSILEnxunCQK5ciMp2Fg951o+SJr jXOMT2UhwSYtbIi6oCaC6g1iVbOB2zCmixLGpDe1gA93kaS/HEJHaoH5oIf/EFhTEHDC L103EM91NTNHBjz4f2ErimBcuOsUoEendBqeK7YJEDaLynP6VDqXil9LHYeEuNzjlisC 7lk+qWKkr79IGCwUyb6XPrKb6jVZjaz+dEf8tizOQJcvgyxTlHpWzaD4akJiNtXgAOKF MzX+lqnhaT6k7Fku3gGTuQPZ+5TBfDPT6+R2rb9e/qva/12sTk/EGUOjQ7G/apu+/kHx H/pQ== X-Forwarded-Encrypted: i=1; AJvYcCUHBicebpms7dXucH7ABWoZ/JujfcND810t7nuycutlYr/kddu0kZrv0Zj/n4kA1ZpfBdvs4WNQYJ9uJQ==@lists.infradead.org X-Gm-Message-State: AOJu0YyNCyNp7+FBP1YNahHyDkVzJeMaITChYC2zlmdtJt659hcP3Zqd N2x2gdXn8dwsXiLNsr5IMJHKUDOkM6B3v20RrYciUU0bSdAna0M2krxg X-Gm-Gg: AY/fxX7tpbs616lwd0sJuY+4CHr1xGVMNhBg4TpeXXuBNoXztFPMmWqRauyx0s41jRr UkOTm0foQNs3YtXeujFk/cOZA2fzNn7bMSCJKh4V6wc39CRhXiAhG5ia6j1Rz6yfuJs2WNj/iFv 3iH7u2I/pmxhCCMHiFTv+bdj/DUc99nn5w+pl0CEAyX5FnZcvt37WgqBA2eB60lIgliKTQrcuDx KUDVuB5AofONkP/+se9rtbMKbg2rgMJE4BVTz6W+Xy+NnsY9USiHsin8zdNlzC4+Nn63OC3d8m2 6wVMqcOkV+VZgWxVsjZvpzcostVnXbfnbLhidu2b+o2INvI8AlHor0WuQIk3y72D+A9q8/tnl74 hL2KFFC/B/8zG5auTupIUrusxFAECl9nJtbKqBRCunHCb3IX4iYsMpWzpH5v6yccKQsbNJmjNH1 zShCAUVMx5xGGCHmmQ2IGfKyznAwgIVJJ1V0tUc789xYk= X-Received: by 2002:a05:600c:8b33:b0:479:1b0f:dfff with SMTP id 5b1f17b1804b1-4801e30d72bmr97350495e9.10.1768738737157; Sun, 18 Jan 2026 04:18:57 -0800 (PST) Received: from anton.local (vps-58d0fbce.vps.ovh.net. [51.178.29.162]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47f3b7a5f94sm207544765e9.0.2026.01.18.04.18.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 18 Jan 2026 04:18:56 -0800 (PST) Date: Sun, 18 Jan 2026 16:18:51 +0400 From: "Anton D. Stavinskii" To: Krzysztof Kozlowski Cc: Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen Wang , Inochi Amaoto , Jaroslav Kysela , Takashi Iwai , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , linux-sound@vger.kernel.org, devicetree@vger.kernel.org, sophgo@lists.linux.dev, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH v2 1/7] dt-bindings: sound: sophgo: add CV1800B I2S/TDM controller binding Message-ID: Mail-Followup-To: Krzysztof Kozlowski , Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen Wang , Inochi Amaoto , Jaroslav Kysela , Takashi Iwai , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , linux-sound@vger.kernel.org, devicetree@vger.kernel.org, sophgo@lists.linux.dev, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org References: <20260118-cv1800b-i2s-driver-v2-0-d10055f68368@gmail.com> <20260118-cv1800b-i2s-driver-v2-1-d10055f68368@gmail.com> <20260118-famous-magnificent-peccary-474ba8@quoll> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20260118-famous-magnificent-peccary-474ba8@quoll> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260118_041859_687523_F5722888 X-CRM114-Status: GOOD ( 35.10 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Sun, Jan 18, 2026 at 11:14:34AM +0400, Krzysztof Kozlowski wrote: > On Sun, Jan 18, 2026 at 12:18:53AM +0400, Anton D. Stavinskii wrote: > > Purpose: introduce DT schema for the CPU driver > > Bindings are for hardware, not drivers. Drop the purpose. Noted. Will do in v3 > > > The driver uses dma to transfer data. The dma it self has 8 channels. > > Describe the hardware. Will try to rephrase. Thanks. > > > > Each channel can be connected only to a specific i2s node. But each > > of dma channel can have multiple purposes so in order to save dma > > channels the configurations allows to use tx and rx, only rx, only tx > > or none channels. I2S controller without channels can be useful in > > configuration where I2S is used as clock source only and doesn't > > produce any data. > > Please use subject prefixes matching the subsystem. You can get them for > example with 'git log --oneline -- DIRECTORY_OR_FILE' on the directory > your patch is touching. For bindings, the preferred subjects are > explained here: > https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters I will do my best in V3. And will read provided links again. > > A nit, subject: drop second/last, redundant "binding". The > "dt-bindings" prefix is already stating that these are bindings. > See also: > https://elixir.bootlin.com/linux/v6.17-rc3/source/Documentation/devicetree/bindings/submitting-patches.rst#L18 > > > > > Signed-off-by: Anton D. Stavinskii > > --- > > .../bindings/sound/sophgo,cv1800b-i2s.yaml | 75 ++++++++++++++++++++++ > > 1 file changed, 75 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/sound/sophgo,cv1800b-i2s.yaml b/Documentation/devicetree/bindings/sound/sophgo,cv1800b-i2s.yaml > > new file mode 100644 > > index 000000000000..cf30880a62da > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/sound/sophgo,cv1800b-i2s.yaml > > @@ -0,0 +1,75 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/sound/sophgo,cv1800b-i2s.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Sophgo CV1800B I2S/TDM controller > > + > > +maintainers: > > + - Anton D. Stavinskii > > + > > +description: | > > Do not need '|' unless you need to preserve formatting. noted. will be fixed. > > > + I2S/TDM controller found in CV1800B / Sophgo SG2002/SG2000 SoCs. > > + > > Miss allOf with ref to dai-common. > > > +properties: > > + compatible: > > + const: sophgo,cv1800b-i2s > > + > > + reg: > > + maxItems: 1 > > + > > + "#sound-dai-cells": > > + const: 0 > > + > > + clocks: > > + minItems: 1 > > + maxItems: 2 > > 1. Why is it flexible? It's my mistake. > > 2. And then why names are not flexible. These should be synced in > constraints. > > > + > > + clock-names: > > + items: > > + - const: i2s > > + - const: mclk > > + > > + dmas: > > + maxItems: 2 > > + > > + dma-names: > > + description: | > > + Names of DMA channels. May be omitted. If present, one entry > > + selects a single direction, while two entries select RX and TX. Will drop. > > Drop desription. Don't repeat constraints in free form text. > > > + minItems: 1 > > + maxItems: 2 > > Again, messed constraints. > > > + items: > > + enum: [rx, tx] > > No, it has to be a specific/fixed list. Here is the question. Can you please help to understand how to describe this properly. The idea is that TDM module is usable even without specified dmas. Each TDM can work as clock source, only rx only tx or both. I can force to use both channels but the user probably will want to not consume all the channels for if it is not needed. DMA can provide channels for something else like SPI/I2C/UART etc. I'm asking because I'm afraid I will do some mess again here. > > > + > > + "#address-cells": > > + const: 1 > > + > > + "#size-cells": > > + const: 0 > > Why? Drop these. noted. Will remove. > > > + > > +required: > > + - compatible > > + - reg > > + - clocks > > + - clock-names > > + - "#sound-dai-cells" > > + > > +additionalProperties: false > > unevaluatedProperties instead Thanks. > > > + > > +examples: > > + - | > > + #include > > + > > + i2s1: i2s@4110000 { > > Drop unused label. will be fixed. Thanks > > > + compatible = "sophgo,cv1800b-i2s"; > > + reg = <0x04110000 0x10000>; > > + #address-cells = <1>; > > + #size-cells = <0>; > > Drop useless properties. > > Best regards, > Krzysztof > Sorry for the mess. It is my first ever patch. Thank you for your review and your time. Will do my best to improve the patch series. _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0BCC64F5E0 for ; Sun, 18 Jan 2026 12:18:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768738742; cv=none; b=tntPQx4axkJh7YCFrqg70rkv7UhgTNcR8d1pE8U1o7bjykzgLRNsjj3rmWpaOBzThpYDpkT0zfYlhYR0veQlUl2LL13TJYoMjn5kyGD/66mOEoVrFZ95U1fIdNQ+1iS7PHZd4IB+CC8unyf7o6t0uazjIgI+0dNiYNEe6fcOMjA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768738742; c=relaxed/simple; bh=AM7nm1BS1hlDTXwcdh1EHXiQu1Si/CyAPg2Ikrwu8lU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ushDjkpWmsS4YY7BJCPXnCabZy5lYLDKKMw0xaqxnerVSU2julnaucUknLKaRxJ2ab+i+UMxJIC2fqTQOnUSVC6VLeq2/UkP4MI3+zGCoP86mMaGoJbgFv6O8TIRFEDnuoN7Gai2yObVPUTE+VPAz/Cj3P1OX4cZbRMw4KqvSBs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=TYBJaL/d; arc=none smtp.client-ip=209.85.221.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TYBJaL/d" Received: by mail-wr1-f50.google.com with SMTP id ffacd0b85a97d-430fbb6012bso2694362f8f.1 for ; Sun, 18 Jan 2026 04:18:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768738737; x=1769343537; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to; bh=WD1wzEbaoKZKhuZNexa3nkG79kI0GKZ4I1GLpFTxDis=; b=TYBJaL/di8WU5YLbMXPuj3t/bq2sjQn3XGh4LzfGIgOyIzQeDVfskSLU7D8wXu2wdH 4tP2ziZ/a+h8g1h27PnTc/Biv5A24eSyrru22JrS4AvIiQuR6+L+D3wjlDiLrDuY6wCY zic2s+PRBpxbV2r6n9j27Y2XTNMoDwMCfwe+0BxHtEc6bBxJuMp6OoPFgnk6M3bQRl1n VfbVl8B0ACNZ4osZYPe/TAQUUva0dmXIlzLtCocxgsjc2fOvKTvs1Ep5MWMiWWxQuFpD BxRqyhEsvRJPET60NpiRwumQ+OMhAeVg6Yk+tTeNi+tSFdqLJiFxvqaNVYYz9q/DC9I6 jrBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768738737; x=1769343537; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=WD1wzEbaoKZKhuZNexa3nkG79kI0GKZ4I1GLpFTxDis=; b=dDa/dUkTx4Cp5wZeP4nyU04sZpIv+UnvNfo9DC3yllJ+MHwN6q5YnYSAqeihgsiyn4 dWiu2NuBMly3BDah1PKSraWh90PlRYUM3Mfuo4jmYNkWcDFBk8VTP+gsZsonv0q00wxk fhW/ySKTohZnhftBd+FGDxC5JUpwVBZgq4ketvdXXyIlGMYysBxvIuRuCtsuw3usc1Fw IViDXnWY1MypeQF/qi+Jmz6aZ2au3wjBGZHvor+UWOesFBX1JlOuLO+RaIGILuZzqV73 Ru2Uwq9OEceNsotWd1FQNt4yCUK82O6lOUw9AhFpyUfM5WbyV3ythRk6J8fluq8mp9Ae tt8Q== X-Forwarded-Encrypted: i=1; AJvYcCXOUyoL82Kj750SdYOw2Fiz3CcCM18SW776zF2SF2OtlFI2DiMQ23VGTvBN6LmV038neDiHzJKeMrAIyg==@vger.kernel.org X-Gm-Message-State: AOJu0Yw+MyVrAq8/XnrTnMHIB9ze8Xr7aWzkYfbH046MCNDSi8/jSHeR +zHIiIn+i129EA9mulTQaJUHfzM+I0Qb4t5SxAGqaLEW1YEg73FXkJc3 X-Gm-Gg: AY/fxX55U/E14jVPC1dJqCyogddYTIOfnTARYjqZhIkIrqg9mvgGIGCMsM/j90UBKFP gtkSOBf0BIyYPGpVvEnT9OHSVJNHCmawf88Nu/wAHhuJnCBPsdMdYeHYDFW0+STDL2X0u5U9MMi h1CXKT3GPhrF4RkVR4+E4xY86FerWIkHj7BHjZ881mTkV6V1Pp7chSX5Z4R9Arpz8vN6zIi57wQ /VezMR93cUv7WSP7rkRa0+wGOq92mk9o5247KUIk514JwKaxUHl5kjWxRNTheiXmWt6FUs4N0Ph oosG2Zr5ZKfYhekcfkkrYQzpyCIM+35Nl/H+TLXaZQeKEMGukHLwTqzSLfLzreKl+HPbTY2m7mf GjPzRse0JsBYHhDPQQfCS8b7+D5dzZW5zWI1Xv0B/UKI2f+QWLiOLS3PTJNoA3d4VCZm7HDM+Il f5oCqNV+SqzyFSXPp51wEXQHAzN3JBLeeqnOjy/c3NkaA= X-Received: by 2002:a05:600c:8b33:b0:479:1b0f:dfff with SMTP id 5b1f17b1804b1-4801e30d72bmr97350495e9.10.1768738737157; Sun, 18 Jan 2026 04:18:57 -0800 (PST) Received: from anton.local (vps-58d0fbce.vps.ovh.net. [51.178.29.162]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47f3b7a5f94sm207544765e9.0.2026.01.18.04.18.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 18 Jan 2026 04:18:56 -0800 (PST) Date: Sun, 18 Jan 2026 16:18:51 +0400 From: "Anton D. Stavinskii" To: Krzysztof Kozlowski Cc: Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen Wang , Inochi Amaoto , Jaroslav Kysela , Takashi Iwai , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , linux-sound@vger.kernel.org, devicetree@vger.kernel.org, sophgo@lists.linux.dev, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH v2 1/7] dt-bindings: sound: sophgo: add CV1800B I2S/TDM controller binding Message-ID: Mail-Followup-To: Krzysztof Kozlowski , Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen Wang , Inochi Amaoto , Jaroslav Kysela , Takashi Iwai , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , linux-sound@vger.kernel.org, devicetree@vger.kernel.org, sophgo@lists.linux.dev, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org References: <20260118-cv1800b-i2s-driver-v2-0-d10055f68368@gmail.com> <20260118-cv1800b-i2s-driver-v2-1-d10055f68368@gmail.com> <20260118-famous-magnificent-peccary-474ba8@quoll> Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260118-famous-magnificent-peccary-474ba8@quoll> On Sun, Jan 18, 2026 at 11:14:34AM +0400, Krzysztof Kozlowski wrote: > On Sun, Jan 18, 2026 at 12:18:53AM +0400, Anton D. Stavinskii wrote: > > Purpose: introduce DT schema for the CPU driver > > Bindings are for hardware, not drivers. Drop the purpose. Noted. Will do in v3 > > > The driver uses dma to transfer data. The dma it self has 8 channels. > > Describe the hardware. Will try to rephrase. Thanks. > > > > Each channel can be connected only to a specific i2s node. But each > > of dma channel can have multiple purposes so in order to save dma > > channels the configurations allows to use tx and rx, only rx, only tx > > or none channels. I2S controller without channels can be useful in > > configuration where I2S is used as clock source only and doesn't > > produce any data. > > Please use subject prefixes matching the subsystem. You can get them for > example with 'git log --oneline -- DIRECTORY_OR_FILE' on the directory > your patch is touching. For bindings, the preferred subjects are > explained here: > https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters I will do my best in V3. And will read provided links again. > > A nit, subject: drop second/last, redundant "binding". The > "dt-bindings" prefix is already stating that these are bindings. > See also: > https://elixir.bootlin.com/linux/v6.17-rc3/source/Documentation/devicetree/bindings/submitting-patches.rst#L18 > > > > > Signed-off-by: Anton D. Stavinskii > > --- > > .../bindings/sound/sophgo,cv1800b-i2s.yaml | 75 ++++++++++++++++++++++ > > 1 file changed, 75 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/sound/sophgo,cv1800b-i2s.yaml b/Documentation/devicetree/bindings/sound/sophgo,cv1800b-i2s.yaml > > new file mode 100644 > > index 000000000000..cf30880a62da > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/sound/sophgo,cv1800b-i2s.yaml > > @@ -0,0 +1,75 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/sound/sophgo,cv1800b-i2s.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Sophgo CV1800B I2S/TDM controller > > + > > +maintainers: > > + - Anton D. Stavinskii > > + > > +description: | > > Do not need '|' unless you need to preserve formatting. noted. will be fixed. > > > + I2S/TDM controller found in CV1800B / Sophgo SG2002/SG2000 SoCs. > > + > > Miss allOf with ref to dai-common. > > > +properties: > > + compatible: > > + const: sophgo,cv1800b-i2s > > + > > + reg: > > + maxItems: 1 > > + > > + "#sound-dai-cells": > > + const: 0 > > + > > + clocks: > > + minItems: 1 > > + maxItems: 2 > > 1. Why is it flexible? It's my mistake. > > 2. And then why names are not flexible. These should be synced in > constraints. > > > + > > + clock-names: > > + items: > > + - const: i2s > > + - const: mclk > > + > > + dmas: > > + maxItems: 2 > > + > > + dma-names: > > + description: | > > + Names of DMA channels. May be omitted. If present, one entry > > + selects a single direction, while two entries select RX and TX. Will drop. > > Drop desription. Don't repeat constraints in free form text. > > > + minItems: 1 > > + maxItems: 2 > > Again, messed constraints. > > > + items: > > + enum: [rx, tx] > > No, it has to be a specific/fixed list. Here is the question. Can you please help to understand how to describe this properly. The idea is that TDM module is usable even without specified dmas. Each TDM can work as clock source, only rx only tx or both. I can force to use both channels but the user probably will want to not consume all the channels for if it is not needed. DMA can provide channels for something else like SPI/I2C/UART etc. I'm asking because I'm afraid I will do some mess again here. > > > + > > + "#address-cells": > > + const: 1 > > + > > + "#size-cells": > > + const: 0 > > Why? Drop these. noted. Will remove. > > > + > > +required: > > + - compatible > > + - reg > > + - clocks > > + - clock-names > > + - "#sound-dai-cells" > > + > > +additionalProperties: false > > unevaluatedProperties instead Thanks. > > > + > > +examples: > > + - | > > + #include > > + > > + i2s1: i2s@4110000 { > > Drop unused label. will be fixed. Thanks > > > + compatible = "sophgo,cv1800b-i2s"; > > + reg = <0x04110000 0x10000>; > > + #address-cells = <1>; > > + #size-cells = <0>; > > Drop useless properties. > > Best regards, > Krzysztof > Sorry for the mess. It is my first ever patch. Thank you for your review and your time. Will do my best to improve the patch series.