From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: "Lin, Shuicheng" <shuicheng.lin@intel.com>
Cc: "Wajdeczko, Michal" <Michal.Wajdeczko@intel.com>,
"intel-xe@lists.freedesktop.org" <intel-xe@lists.freedesktop.org>
Subject: Re: [PATCH] drm/xe/pf: Fix typo in function kernel-doc
Date: Fri, 30 Jan 2026 16:08:51 -0500 [thread overview]
Message-ID: <aX0d4-Krwwit9kWj@intel.com> (raw)
In-Reply-To: <DM4PR11MB5456623FF9658D6D85BAC5DBEA9EA@DM4PR11MB5456.namprd11.prod.outlook.com>
On Thu, Jan 29, 2026 at 04:55:25PM +0000, Lin, Shuicheng wrote:
> On Wed, Dec 17, 2025 9:24 AM Rodrigo Vivi wrote:
> > On Wed, Dec 17, 2025 at 04:07:02PM +0100, Michal Wajdeczko wrote:
> > > The function name is missing an underscore, which results in:
> >
> > I'm glad you wrote this. I was looking to the patch first without been able to
> > spot the difference! o.O
> >
> > Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
>
> It seems this patch is missed to be merged. I don't see it in the latest xe kernel.
Thanks for the heads up. Pushed to drm-xe-next now.
> LGTM.
> Reviewed-by: Shuicheng Lin <shuicheng.lin@intel.com>
>
> >
> > >
> > > Warning: ../drivers/gpu/drm/xe/xe_gt_sriov_pf_control.c:1261
> > > This comment starts with '/**', but isn't a kernel-doc comment.
> > > Refer to Documentation/doc-guide/kernel-doc.rst
> > > * xe_gt_sriov_pf_control_trigger restore_vf() - Start ...
> > >
> > > Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
> > > ---
> > > drivers/gpu/drm/xe/xe_gt_sriov_pf_control.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/gpu/drm/xe/xe_gt_sriov_pf_control.c
> > > b/drivers/gpu/drm/xe/xe_gt_sriov_pf_control.c
> > > index bf48b05797de..5cb705c7ee7a 100644
> > > --- a/drivers/gpu/drm/xe/xe_gt_sriov_pf_control.c
> > > +++ b/drivers/gpu/drm/xe/xe_gt_sriov_pf_control.c
> > > @@ -1259,7 +1259,7 @@ int
> > > xe_gt_sriov_pf_control_process_restore_data(struct xe_gt *gt, unsigned
> > > int v }
> > >
> > > /**
> > > - * xe_gt_sriov_pf_control_trigger restore_vf() - Start an SR-IOV VF
> > migration data restore sequence.
> > > + * xe_gt_sriov_pf_control_trigger_restore_vf() - Start an SR-IOV VF
> > migration data restore sequence.
> > > * @gt: the &xe_gt
> > > * @vfid: the VF identifier
> > > *
> > > --
> > > 2.47.1
> > >
next prev parent reply other threads:[~2026-01-30 21:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-17 15:07 [PATCH] drm/xe/pf: Fix typo in function kernel-doc Michal Wajdeczko
2025-12-17 16:34 ` ✓ CI.KUnit: success for " Patchwork
2025-12-17 17:23 ` [PATCH] " Rodrigo Vivi
2026-01-29 16:55 ` Lin, Shuicheng
2026-01-30 21:08 ` Rodrigo Vivi [this message]
2025-12-17 17:29 ` ✓ Xe.CI.BAT: success for " Patchwork
2025-12-18 15:21 ` ✗ Xe.CI.Full: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aX0d4-Krwwit9kWj@intel.com \
--to=rodrigo.vivi@intel.com \
--cc=Michal.Wajdeczko@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=shuicheng.lin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.