From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: raskar.shree97@gmail.com
Cc: "Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
skhan@linuxfoundation.org, david.hunter.linux@gmail.com,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 4/5] iio: proximity: rfd77402: Document device private data structure
Date: Wed, 21 Jan 2026 11:18:42 +0200 [thread overview]
Message-ID: <aXCZ8gRTsR93A5Kz@smile.fi.intel.com> (raw)
In-Reply-To: <20260121-b4-rfd77402_v5-v6-4-5b944d0605dd@gmail.com>
On Wed, Jan 21, 2026 at 02:05:44AM +0530, Shrikant Raskar via B4 Relay wrote:
> Add kernel-doc style comments for struct rfd77402_data to describe
> the purpose of each member.
Assuming checkpatch.pl doesn't complain (see below why),
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
...
> +/**
> + * struct rfd77402_data - device-specific data for the RFD77402 sensor
> + * @client: I2C client handle
> + * @lock: mutex to serialize sensor reads
> + */
> struct rfd77402_data {
> struct i2c_client *client;
> - /* Serialize reads from the sensor */
Not sure if this can be removed due to some checkpatch checks.
Have you run it to verify?
> struct mutex lock;
> };
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-01-21 9:18 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-20 20:35 [PATCH v6 0/5] iio: proximity: Add interrupt support for RFD77402 Shrikant Raskar
2026-01-20 20:35 ` Shrikant Raskar via B4 Relay
2026-01-20 20:35 ` [PATCH v6 1/5] iio: proximity: rfd77402: Reorder header includes Shrikant Raskar
2026-01-20 20:35 ` Shrikant Raskar via B4 Relay
2026-01-21 8:54 ` Andy Shevchenko
2026-01-22 20:57 ` Jonathan Cameron
2026-01-23 3:42 ` Shrikant
2026-01-23 9:59 ` Jonathan Cameron
2026-01-20 20:35 ` [PATCH v6 2/5] iio: proximity: rfd77402: Use kernel helper for result polling Shrikant Raskar
2026-01-20 20:35 ` Shrikant Raskar via B4 Relay
2026-01-21 9:05 ` Andy Shevchenko
2026-01-24 16:56 ` Shrikant
2026-01-26 9:44 ` Andy Shevchenko
2026-01-26 15:28 ` Shrikant
2026-01-26 16:11 ` Andy Shevchenko
2026-01-20 20:35 ` [PATCH v6 3/5] iio: proximity: rfd77402: Use devm-managed mutex initialization Shrikant Raskar
2026-01-20 20:35 ` Shrikant Raskar via B4 Relay
2026-01-21 9:16 ` Andy Shevchenko
2026-01-20 20:35 ` [PATCH v6 4/5] iio: proximity: rfd77402: Document device private data structure Shrikant Raskar
2026-01-20 20:35 ` Shrikant Raskar via B4 Relay
2026-01-21 9:18 ` Andy Shevchenko [this message]
2026-01-22 17:42 ` Shrikant
2026-01-20 20:35 ` [PATCH v6 5/5] iio: proximity: rfd77402: Add interrupt handling support Shrikant Raskar
2026-01-20 20:35 ` Shrikant Raskar via B4 Relay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aXCZ8gRTsR93A5Kz@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=david.hunter.linux@gmail.com \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=raskar.shree97@gmail.com \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.