From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7B504285C98; Wed, 21 Jan 2026 10:13:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768990397; cv=none; b=g2IoK1g9HdSk/YJ4Pg97ueFNN++iwCq8sW1xJ/AG8Y6/6ZwO7GhePQn00gbdxRV5qF6j/avsTArfAgkgBCMuZAq8YbLC5AbZV9PAEPCfxp8m4KpFR6kr/N0c7lGt/LP5S2LNgf4vjXQJSAgpeXtGxguOM3XRbrgrK5AwMeWmxuw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768990397; c=relaxed/simple; bh=ww/A3r+fSI3VAGDS9V/iZEiW76yABU7WPE7tQHQsZng=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=utF0ADdTm1SXmERk/tCFqYUEUure6ZCOlGGsiSVI/V1r8C/oNMl52qDkkEdqu0rOlREhvsxQLVeW5rauJ2dwvZakXOt6gFGQy2KtlJUusdS2vOYEkG2Giuu4ajQRZJdLn/NWFQd2ffmyRf0VNMA6PCO9qGbhhA+6WZ+3d22cpM4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=hF+cUy+2; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="hF+cUy+2" Received: by smtp.kernel.org (Postfix) with ESMTPSA id CFB45C116D0; Wed, 21 Jan 2026 10:13:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1768990397; bh=ww/A3r+fSI3VAGDS9V/iZEiW76yABU7WPE7tQHQsZng=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hF+cUy+2KpyttqywgJgLGrO1uqdoRCFkRxEfBbxvVZ8pm0vVVVxuf1nVwYgTyn+dV 6fQfQHb0/m3m9WljBSxoKFc7DXwP0ho9YYEowhXMd+jMi31oYIpDKP2fvLQ9RyoYYj AKeeixMeVCPRQkiFV4feGXGIgJ9LWv6xNA5jV7GyadesMV7lyuE+u5iDQmWti73+po bAbpqQS+C9yr9AJA5k+jVH1cfD4PKC9F/rRJve2ZQE7TLI7Bd+9mJy3+yZH2FWd7IS mFtqPUGk3E78DUVrBZnLJMiB+tq/z2RIzsldb6SCAQfI8HS05VVTyd+4xkFQuTAs83 658kvYYcrOt5Q== Date: Wed, 21 Jan 2026 11:13:12 +0100 From: Niklas Cassel To: Qiang Yu , Manivannan Sadhasivam Cc: Jingoo Han , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , Heiko Stuebner , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org Subject: Re: [PATCH] PCI: dwc: Remove duplicate dw_pcie_ep_hide_ext_capability() function Message-ID: References: <20251224-remove_dw_pcie_ep_hide_ext_capability-v1-1-4302c9cdc316@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Dec 30, 2025 at 03:22:39PM +0100, Niklas Cassel wrote: > Hello Qiang Yu, > > On Wed, Dec 24, 2025 at 02:10:46AM -0800, Qiang Yu wrote: > > Remove dw_pcie_ep_hide_ext_capability() and replace its usage with > > dw_pcie_remove_ext_capability(). Both functions serve the same purpose > > of hiding PCIe extended capabilities, but dw_pcie_remove_ext_capability() > > provides a cleaner API that doesn't require the caller to specify the > > previous capability ID. > > > > Compile-tested only. Runtime testing on RK3588 hardware would be > > appreciated. > > This patch does not appy on top of pci/controller/dwc > > Anyway, I applied it manually, and tested, thus: > Tested-by: Niklas Cassel I just tried to apply this patch for pci/controller/dwc and right now, this patch does apply. Mani, any chance to get this picked up? Kind regards, Niklas From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1B100C44501 for ; Wed, 21 Jan 2026 10:13:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=EDhhimO/HJDeO5hcWJjYbof3S1X1ijdR6J/K1BqlW3Q=; b=tN3VvperqOv8jD F1BpqyF/5SXLJz3ksTX8kqv4fuUhGgnX4boD/carVhXsyw2/cqMQOHV+qxmLCFbSI/Va4ghH20vJL fV0aJOBZxx4uHr/kw45fpYFGW/JoHcuPvF5FMSn0T/tFSx0ck6AMi1iyY4jADgj3+40JxmAh1q7/k Sgjce/c+Cv4gUZDs45EMxqtKIjtCn7O+fiy3zv9iOGG8H3/Gm99th1ONMz632vCi5k7yI+ftn5uMm l5yrAZLN5iTkXGzklW1nFbGKZy39YG7J2YGjVPPLj5qivloTSbF8K4qyPeP5A/jv8emsT/C2OpaUq kSJsBX3cszMJ5Cf082vQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1viVDE-00000005FMz-112Q; Wed, 21 Jan 2026 10:13:20 +0000 Received: from sea.source.kernel.org ([172.234.252.31]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1viVDC-00000005FMT-2emQ for linux-rockchip@lists.infradead.org; Wed, 21 Jan 2026 10:13:19 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 49B0243DBB; Wed, 21 Jan 2026 10:13:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CFB45C116D0; Wed, 21 Jan 2026 10:13:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1768990397; bh=ww/A3r+fSI3VAGDS9V/iZEiW76yABU7WPE7tQHQsZng=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hF+cUy+2KpyttqywgJgLGrO1uqdoRCFkRxEfBbxvVZ8pm0vVVVxuf1nVwYgTyn+dV 6fQfQHb0/m3m9WljBSxoKFc7DXwP0ho9YYEowhXMd+jMi31oYIpDKP2fvLQ9RyoYYj AKeeixMeVCPRQkiFV4feGXGIgJ9LWv6xNA5jV7GyadesMV7lyuE+u5iDQmWti73+po bAbpqQS+C9yr9AJA5k+jVH1cfD4PKC9F/rRJve2ZQE7TLI7Bd+9mJy3+yZH2FWd7IS mFtqPUGk3E78DUVrBZnLJMiB+tq/z2RIzsldb6SCAQfI8HS05VVTyd+4xkFQuTAs83 658kvYYcrOt5Q== Date: Wed, 21 Jan 2026 11:13:12 +0100 From: Niklas Cassel To: Qiang Yu , Manivannan Sadhasivam Cc: Jingoo Han , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , Heiko Stuebner , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org Subject: Re: [PATCH] PCI: dwc: Remove duplicate dw_pcie_ep_hide_ext_capability() function Message-ID: References: <20251224-remove_dw_pcie_ep_hide_ext_capability-v1-1-4302c9cdc316@oss.qualcomm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260121_021318_693988_EED4025D X-CRM114-Status: GOOD ( 13.15 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org On Tue, Dec 30, 2025 at 03:22:39PM +0100, Niklas Cassel wrote: > Hello Qiang Yu, > > On Wed, Dec 24, 2025 at 02:10:46AM -0800, Qiang Yu wrote: > > Remove dw_pcie_ep_hide_ext_capability() and replace its usage with > > dw_pcie_remove_ext_capability(). Both functions serve the same purpose > > of hiding PCIe extended capabilities, but dw_pcie_remove_ext_capability() > > provides a cleaner API that doesn't require the caller to specify the > > previous capability ID. > > > > Compile-tested only. Runtime testing on RK3588 hardware would be > > appreciated. > > This patch does not appy on top of pci/controller/dwc > > Anyway, I applied it manually, and tested, thus: > Tested-by: Niklas Cassel I just tried to apply this patch for pci/controller/dwc and right now, this patch does apply. Mani, any chance to get this picked up? Kind regards, Niklas _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip