From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: linux-pci@vger.kernel.org, "Bjorn Helgaas" <bhelgaas@google.com>,
"Christian König" <christian.koenig@amd.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] PCI: BAR resize rollback fixes
Date: Wed, 21 Jan 2026 17:52:07 +0200 [thread overview]
Message-ID: <aXD2J0-Rlh2ZlxSN@intel.com> (raw)
In-Reply-To: <20260121131417.9582-1-ilpo.jarvinen@linux.intel.com>
On Wed, Jan 21, 2026 at 03:14:15PM +0200, Ilpo Järvinen wrote:
> Hi all,
>
> This series fixes two issue in BAR resize rollback found by
> Ville Syrjälä <ville.syrjala@linux.intel.com>.
>
> Ilpo Järvinen (2):
> PCI: Fix BAR resize rollback path overwriting ret
> PCI: Fix Resizable BAR restore order
Thanks.
Looks to be working fine now:
i915 0000:03:00.0: BAR 2 [mem 0x4030000000-0x403fffffff 64bit pref]: releasing
pcieport 0000:02:01.0: bridge window [mem 0x4030000000-0x403fffffff 64bit pref]: releasing
pcieport 0000:01:00.0: bridge window [mem 0x4030000000-0x403fffffff 64bit pref]: releasing
pcieport 0000:00:01.0: bridge window [mem 0x4030000000-0x40407fffff 64bit pref]: was not released (still contains assigned resources)
pcieport 0000:00:01.0: Assigned bridge window [mem 0x4030000000-0x40407fffff 64bit pref] to [bus 01-04] cannot fit 0x200000000 required for 0000:02:01.0 bridging to [bus 03]
pcieport 0000:02:01.0: bridge window [mem size 0x200000000 64bit pref] to [bus 03] requires relaxed alignment rules
pcieport 0000:00:01.0: Assigned bridge window [mem 0x4030000000-0x40407fffff 64bit pref] to [bus 01-04] cannot fit 0x200000000 required for 0000:01:00.0 bridging to [bus 02-04]
pcieport 0000:01:00.0: bridge window [mem size 0x200000000 64bit pref] to [bus 02-04] requires relaxed alignment rules
pcieport 0000:01:00.0: bridge window [mem size 0x200000000 64bit pref]: can't assign; no space
pcieport 0000:01:00.0: bridge window [mem size 0x200000000 64bit pref]: failed to assign
pcieport 0000:01:00.0: bridge window [mem size 0x200000000 64bit pref]: can't assign; no space
pcieport 0000:01:00.0: bridge window [mem size 0x200000000 64bit pref]: failed to assign
pcieport 0000:02:01.0: bridge window [mem size 0x200000000 64bit pref]: can't assign; no space
pcieport 0000:02:01.0: bridge window [mem size 0x200000000 64bit pref]: failed to assign
pcieport 0000:02:01.0: bridge window [mem size 0x200000000 64bit pref]: can't assign; no space
pcieport 0000:02:01.0: bridge window [mem size 0x200000000 64bit pref]: failed to assign
i915 0000:03:00.0: BAR 2 [mem size 0x200000000 64bit pref]: can't assign; no space
i915 0000:03:00.0: BAR 2 [mem size 0x200000000 64bit pref]: failed to assign
i915 0000:03:00.0: BAR 2 [mem size 0x200000000 64bit pref]: can't assign; no space
i915 0000:03:00.0: BAR 2 [mem size 0x200000000 64bit pref]: failed to assign
pcieport 0000:00:01.0: PCI bridge to [bus 01-04]
pcieport 0000:00:01.0: bridge window [mem 0x57000000-0x583fffff]
pcieport 0000:00:01.0: bridge window [mem 0x4030000000-0x40407fffff 64bit pref]
pcieport 0000:01:00.0: PCI bridge to [bus 02-04]
pcieport 0000:01:00.0: bridge window [mem 0x57000000-0x583fffff]
pcieport 0000:01:00.0: bridge window [mem 0x4030000000-0x403fffffff 64bit pref]
pcieport 0000:02:01.0: PCI bridge to [bus 03]
pcieport 0000:02:01.0: bridge window [mem 0x57000000-0x581fffff]
pcieport 0000:02:01.0: bridge window [mem 0x4030000000-0x403fffffff 64bit pref]
i915 0000:03:00.0: BAR 2 [mem 0x4030000000-0x403fffffff 64bit pref]: old value restored
i915 0000:03:00.0: [drm] Failed to resize BAR2 to 8192M (-28)
i915 0000:03:00.0: [drm] Using a reduced BAR size of 256MiB. Consider enabling 'Resizable BAR' or similar, if available in the BIOS.
For the series:
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Tested-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> drivers/pci/rebar.c | 18 +-----------------
> drivers/pci/setup-bus.c | 23 +++++++++++++++++++----
> 2 files changed, 20 insertions(+), 21 deletions(-)
>
>
> base-commit: 8f0b4cce4481fb22653697cced8d0d04027cb1e8
> --
> 2.39.5
--
Ville Syrjälä
Intel
next prev parent reply other threads:[~2026-01-21 15:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-21 13:14 [PATCH 0/2] PCI: BAR resize rollback fixes Ilpo Järvinen
2026-01-21 13:14 ` [PATCH 1/2] PCI: Fix BAR resize rollback path overwriting ret Ilpo Järvinen
2026-01-22 10:07 ` Ilpo Järvinen
2026-01-22 16:30 ` Bjorn Helgaas
2026-01-21 13:14 ` [PATCH 2/2] PCI: Fix Resizable BAR restore order Ilpo Järvinen
2026-01-21 15:52 ` Ville Syrjälä [this message]
2026-01-21 17:46 ` [PATCH 0/2] PCI: BAR resize rollback fixes Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aXD2J0-Rlh2ZlxSN@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=christian.koenig@amd.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.