From: Dan Carpenter <dan.carpenter@linaro.org>
To: 2023060904@ycu.edu.cn
Cc: linux-staging@lists.linux.dev, gregkh@linuxfoundation.org,
guagua210311@qq.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] rtl8723bs: Refactor continual_io_error check
Date: Wed, 21 Jan 2026 16:22:44 +0300 [thread overview]
Message-ID: <aXDTJIERbdMPN8-b@stanley.mountain> (raw)
In-Reply-To: <5A122A378F3E53A7+20260120141129.8262-1-2023060904@ycu.edu.cn>
On Tue, Jan 20, 2026 at 10:11:25PM +0800, 2023060904@ycu.edu.cn wrote:
> From: Changjun Zheng <guagua210311@qq.com>
>
> Refactor the error count check logic to follow kernel 'single responsibility' principle:
> 1. Move the increment logic (atomic_inc) from rtw_inc_and_chk_continual_io_error() to its callers in sdio_ops_linux.c (line 226/302)
> 2. Keep only the check logic in rtw_inc_and_chk_continual_io_error() (use atomic_read to get current count)
>
> This change addresses Greg KH's feedback to move increment to callers, while keeping atomic operations to ensure no compilation/run-time errors.
>
There are a lot of style issues in this patch. I also still don't
really understand why we are doing this. Was Greg's email this one?
https://lore.kernel.org/all/2025121757-crowbar-junkman-a96a@gregkh/
I'm guessing that Greg wants you to change this to refcount_t.
regards,
dan carpenter
next prev parent reply other threads:[~2026-01-21 13:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-19 8:06 [PATCH] [rtl8723bs] Remove unnecessary atomic operations for continual_io_error 2023060904
2026-01-19 8:20 ` Greg KH
2026-01-20 14:11 ` [PATCH v2 1/2] rtl8723bs: Refactor continual_io_error check 2023060904
2026-01-20 14:34 ` Greg KH
2026-01-21 13:22 ` Dan Carpenter [this message]
2026-01-21 13:27 ` Greg KH
[not found] ` <20260120141129.8262-1-2023060904@ycu.edu.cn>
2026-01-20 14:11 ` [PATCH v2 2/2] rtl8723bs: Replace atomic ops with normal vars 2023060904
2026-01-19 8:25 ` [PATCH] [rtl8723bs] Remove unnecessary atomic operations for continual_io_error Dan Carpenter
2026-01-20 13:39 ` 2023060904
2026-01-20 14:05 ` Greg KH
2026-01-20 14:18 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aXDTJIERbdMPN8-b@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=2023060904@ycu.edu.cn \
--cc=gregkh@linuxfoundation.org \
--cc=guagua210311@qq.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.