From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: cem@kernel.org, stable@vger.kernel.org, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 5/6] xfs: fix the xattr scrub to detect freemap/entries array collisions
Date: Wed, 21 Jan 2026 07:08:29 -0800 [thread overview]
Message-ID: <aXDr7esBWDzANCmo@infradead.org> (raw)
In-Reply-To: <176897695663.202569.9251656342143621163.stgit@frogsfrogsfrogs>
On Tue, Jan 20, 2026 at 10:38:59PM -0800, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
>
> In the previous patches, we observed that it's possible for there to be
> freemap entries with zero size but a nonzero base. This isn't an
> inconsistency per se, but older kernels can get confused by this and
> corrupt the block, leading to corruption.
A bit hard to follow between removing the helper and the logic
change, but the result looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2026-01-21 15:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-21 6:34 [PATCHSET 2/3] xfs: fix problems in the attr leaf freemap code Darrick J. Wong
2026-01-21 6:37 ` [PATCH 1/6] xfs: delete attr leaf freemap entries when empty Darrick J. Wong
2026-01-21 15:05 ` Christoph Hellwig
2026-01-21 6:38 ` [PATCH 2/6] xfs: fix freemap adjustments when adding xattrs to leaf blocks Darrick J. Wong
2026-01-21 15:06 ` Christoph Hellwig
2026-01-21 6:38 ` [PATCH 3/6] xfs: refactor attr3 leaf table size computation Darrick J. Wong
2026-01-21 15:06 ` Christoph Hellwig
2026-01-21 6:38 ` [PATCH 4/6] xfs: strengthen attr leaf block freemap checking Darrick J. Wong
2026-01-21 15:06 ` Christoph Hellwig
2026-01-21 6:38 ` [PATCH 5/6] xfs: fix the xattr scrub to detect freemap/entries array collisions Darrick J. Wong
2026-01-21 15:08 ` Christoph Hellwig [this message]
2026-01-21 6:39 ` [PATCH 6/6] xfs: fix remote xattr valuelblk check Darrick J. Wong
2026-01-21 15:08 ` Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2026-01-23 7:00 [PATCHSET 1/3] xfs: fix problems in the attr leaf freemap code Darrick J. Wong
2026-01-23 7:02 ` [PATCH 5/6] xfs: fix the xattr scrub to detect freemap/entries array collisions Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aXDr7esBWDzANCmo@infradead.org \
--to=hch@infradead.org \
--cc=cem@kernel.org \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.