All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: correctmost <cmlists@sent.com>,
	dmaengine@vger.kernel.org, regressions@lists.linux.dev,
	vkoul@kernel.org, linux-i2c@vger.kernel.org
Subject: Re: [REGRESSION][BISECTED] Lenovo IdeaPad touchpad does not work when idma64 is present in initramfs
Date: Wed, 21 Jan 2026 17:19:17 +0200	[thread overview]
Message-ID: <aXDuddwBCelAVouQ@smile.fi.intel.com> (raw)
In-Reply-To: <20260121150256.GN2275908@black.igk.intel.com>

On Wed, Jan 21, 2026 at 04:02:56PM +0100, Mika Westerberg wrote:
> On Wed, Jan 21, 2026 at 04:54:43PM +0200, Andy Shevchenko wrote:
> > > My understanding is that some models touchpad does not work if the idma64
> > > driver is loaded but they do work if it is not. Also there is some sort of
> > > interrupt flood coming from somewhere?
> > > 
> > > When idma64 is not present the toucpad works flawlessly?
> > 
> > On *old* kernels where idma64 blindly acknowledges all the interrupts.
> > Fixed idma64 doesn't affect the IRQ storm because it's just a given
> > fact on these laptops.
> > 
> > > Does it works in Windows?
> > > 
> > > I mean if it works in Windows and we also know it works in Linux without
> > > idma64 then we can go with some sort of quirk (or better yet figure out
> > > what is going on) to keep users touchpads working. I think this is much
> > > better option than asking BIOS update from vendor which there is close to
> > > zero possibility to happen in reality.
> > 
> > What kind of a quirk? Just to create a module that will request the same IRQ
> > and always acknowledges it? Sounds to me like a heavily papering over solution
> > TBH. (Yes, I assume it may be used only on DMI based enumeration only on the
> > affected models, but still...)
> 
> Well I mean if touchpads actually worked prior this idma64 commit and now
> they don't isn't that a regression?

I don't think so, because commit did the right thing and just revealed an issue
that was rather hidden. Reverting is not an option.

> After that one commit touchpads don't
> work anymore. I would much rather make sure users devices keep functional
> even if it turns out to be hack of some sort.

It's one of the ugliest hacks I ever seen. I really don't want to go this way.
In any case, the problem is with interrupts coming from I²C controller. You can
consider adding that hack into there which sounds at least much better place
than idma64.c which has nothing to do with all this.

> For example could be blacklist idma64? Does that help?

No, it won't.

> Yes the interrupt flood still happens but if that does not affect the
> toucpad then that's still better than non-functional touchpad IMO.

So, the only "best" option I see is to add a quirk module (somewhere in PDx86
area) that just registers an interrupt handler to acknowledge it. Very weird.

-- 
With Best Regards,
Andy Shevchenko



  reply	other threads:[~2026-01-21 15:19 UTC|newest]

Thread overview: 55+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-16 17:57 [REGRESSION][BISECTED] Lenovo IdeaPad touchpad does not work when idma64 is present in initramfs correctmost
2026-01-12 14:35 ` Andy Shevchenko
2026-01-12 16:52   ` Andy Shevchenko
2026-01-15 22:50   ` correctmost
2026-01-16 10:03     ` Andy Shevchenko
2026-01-16 10:35       ` Andy Shevchenko
2026-01-17  0:25         ` correctmost
2026-01-19 10:39           ` Andy Shevchenko
2026-01-19 10:49             ` Andy Shevchenko
2026-01-20  9:33               ` Andy Shevchenko
2026-01-21  4:56                 ` correctmost
2026-01-21  9:13                   ` Andy Shevchenko
2026-01-21 13:58                     ` Mika Westerberg
2026-01-21 14:54                       ` Andy Shevchenko
2026-01-21 15:02                         ` Mika Westerberg
2026-01-21 15:19                           ` Andy Shevchenko [this message]
2026-01-22 11:00                             ` Mika Westerberg
2026-01-22 22:29                               ` correctmost
2026-01-23  6:36                                 ` Mika Westerberg
2026-01-25  3:38                                   ` correctmost
2026-01-26 13:53                                     ` Mika Westerberg
2026-01-27  6:52                                       ` correctmost
2026-01-27  8:42                                         ` Mika Westerberg
2026-01-27 10:11                                           ` correctmost
2026-01-27 10:19                                             ` Mika Westerberg
2026-01-27 10:56                                               ` correctmost
2026-01-27 14:43                                                 ` Mika Westerberg
2026-01-27 15:09                                                   ` Andy Shevchenko
2026-01-28  3:06                                                   ` correctmost
2026-01-23  6:53                                 ` Andy Shevchenko
2026-01-28  9:34                   ` Andy Shevchenko
2026-01-28 10:21                     ` correctmost
2026-01-28 12:31                       ` Mika Westerberg
2026-01-29  4:54                         ` correctmost
2026-01-29  6:58                           ` Mika Westerberg
2026-01-29  7:20                             ` correctmost
2026-01-29 11:56                               ` Mika Westerberg
2026-01-29 13:06                                 ` correctmost
2026-01-30  7:26                                   ` Mika Westerberg
2026-01-30  8:18                                     ` correctmost
2026-02-02  7:51                                       ` Mika Westerberg
2026-02-02  8:38                                         ` correctmost
2026-02-02 10:22                                           ` Mika Westerberg
2026-02-02 11:16                                             ` correctmost
2026-02-03 10:04                                               ` Mika Westerberg
2026-02-03 12:39                                                 ` correctmost
2026-02-04 12:31                                                   ` Mika Westerberg
2026-02-04 13:11                                                     ` correctmost
2026-02-04 13:19                                                       ` Andy Shevchenko
2026-02-04 14:01                                                         ` correctmost
2026-02-04 15:12                                                           ` correctmost
2026-02-04 15:34                                                             ` Mika Westerberg
2026-02-04 15:53                                                               ` correctmost
2026-02-05 10:31                                                                 ` Mika Westerberg
2026-02-14 20:17                                                                   ` correctmost

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aXDuddwBCelAVouQ@smile.fi.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=cmlists@sent.com \
    --cc=dmaengine@vger.kernel.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=mika.westerberg@linux.intel.com \
    --cc=regressions@lists.linux.dev \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.