All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Anthony PERARD <anthony.perard@vates.tech>,
	Michal Orzel <michal.orzel@amd.com>
Subject: Re: [PATCH] symbols: don't omit "end" symbols upon mixed code / data aliases
Date: Wed, 21 Jan 2026 18:16:18 +0100	[thread overview]
Message-ID: <aXEJ4jGCLVCG1q6U@Mac.lan> (raw)
In-Reply-To: <9dc297d2-08f1-460a-b513-91deaecbd2d4@suse.com>

On Wed, Jan 21, 2026 at 04:26:03PM +0100, Jan Beulich wrote:
> At the example of _sinitext - that symbol has four aliases on x86:
> __init_begin, __2M_init_start, __2M_rodata_end, and whatever the first
> function in .init.text. With the GNU toolchain all of them are marked
> 'T' or 't'. With Clang/LLVM, however, some are marked 'r'. Since, to
> save space, we want fake "end" symbols only for text, right now
> want_symbol_end() has a respective check. That is getting in the way,
> however, when the final of those symbols is 'r'. Remove the check and
> instead zap the size for anything that is non-code.
> 
> Fixes: 6eede548df21 ('symbols: avoid emitting "end" symbols for data items')
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Acked-by: Roger Pau Monné <roger.pau@citrix.com>

> ---
> Roger, just fyi that I think that this change would mask the other issue
> that you reported, without actually adressing the underlying problem.
> Hence both changes will be wanted.

Yes, it does indeed mask the other issue.

Thanks, Roger.


      reply	other threads:[~2026-01-21 17:17 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-21 15:26 [PATCH] symbols: don't omit "end" symbols upon mixed code / data aliases Jan Beulich
2026-01-21 17:16 ` Roger Pau Monné [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aXEJ4jGCLVCG1q6U@Mac.lan \
    --to=roger.pau@citrix.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=anthony.perard@vates.tech \
    --cc=jbeulich@suse.com \
    --cc=julien@xen.org \
    --cc=michal.orzel@amd.com \
    --cc=sstabellini@kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.