From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Christoph Hellwig <hch@infradead.org>,
cem@kernel.org, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 2/3] xfs: speed up parent pointer operations when possible
Date: Wed, 21 Jan 2026 22:31:28 -0800 [thread overview]
Message-ID: <aXHEQN3g31QPZ5mX@infradead.org> (raw)
In-Reply-To: <20260121180646.GG5945@frogsfrogsfrogs>
On Wed, Jan 21, 2026 at 10:06:46AM -0800, Darrick J. Wong wrote:
> > This is really a could and not a can, it might still not be possible
> > and we bail out. Maybe reflect that in at least the comment, if not
> > also the name?
>
> How about:
>
> /*
> * Decide if it is theoretically possible to try to bypass the attr
> * intent mechanism for better performance. Other constraints (e.g.
> * available space in the existing structure) are not considered
> * here.
> */
> static inline bool
> xfs_attr_can_shortcut(
Sounds good.
next prev parent reply other threads:[~2026-01-22 6:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-21 6:34 [PATCHSET 3/3] xfs: improve shortform attr performance Darrick J. Wong
2026-01-21 6:39 ` [PATCH 1/3] xfs: reduce xfs_attr_try_sf_addname parameters Darrick J. Wong
2026-01-21 15:11 ` Christoph Hellwig
2026-01-21 6:39 ` [PATCH 2/3] xfs: speed up parent pointer operations when possible Darrick J. Wong
2026-01-21 15:22 ` Christoph Hellwig
2026-01-21 18:06 ` Darrick J. Wong
2026-01-22 6:31 ` Christoph Hellwig [this message]
2026-01-21 6:40 ` [PATCH 3/3] xfs: add a method to replace shortform attrs Darrick J. Wong
2026-01-21 15:22 ` Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2026-01-23 7:00 [PATCHSET 2/3] xfs: improve shortform attr performance Darrick J. Wong
2026-01-23 7:02 ` [PATCH 2/3] xfs: speed up parent pointer operations when possible Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aXHEQN3g31QPZ5mX@infradead.org \
--to=hch@infradead.org \
--cc=cem@kernel.org \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.