All of lore.kernel.org
 help / color / mirror / Atom feed
From: Harry Yoo <harry.yoo@oracle.com>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: Petr Tesarik <ptesarik@suse.com>,
	Christoph Lameter <cl@gentwo.org>,
	David Rientjes <rientjes@google.com>,
	Roman Gushchin <roman.gushchin@linux.dev>,
	Hao Li <hao.li@linux.dev>,
	Andrew Morton <akpm@linux-foundation.org>,
	Uladzislau Rezki <urezki@gmail.com>,
	"Liam R. Howlett" <Liam.Howlett@oracle.com>,
	Suren Baghdasaryan <surenb@google.com>,
	Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
	Alexei Starovoitov <ast@kernel.org>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	linux-rt-devel@lists.linux.dev, bpf@vger.kernel.org,
	kasan-dev@googlegroups.com
Subject: Re: [PATCH v3 18/21] slab: update overview comments
Date: Thu, 22 Jan 2026 15:41:00 +0900	[thread overview]
Message-ID: <aXHGfLV6FdlNPc14@hyeyoo> (raw)
In-Reply-To: <20260116-sheaves-for-all-v3-18-5595cb000772@suse.cz>

On Fri, Jan 16, 2026 at 03:40:38PM +0100, Vlastimil Babka wrote:
> The changes related to sheaves made the description of locking and other
> details outdated. Update it to reflect current state.
> 
> Also add a new copyright line due to major changes.
> 
> Reviewed-by: Suren Baghdasaryan <surenb@google.com>
> Signed-off-by: Vlastimil Babka <vbabka@suse.cz>
> ---
> @@ -112,47 +123,46 @@
> + *   node->barn->lock (spinlock)
>   *
> - *   lockless fastpaths
> + *   Lockless freeing
> + *
> + *   Objects may have to be freed to their slabs when they are from a remote
> + *   node (where we want to avoid filling local sheaves with remote objects)
> + *   or when there are too many full sheaves. On architectures supporting
> + *   cmpxchg_double this is done by a lockless update of slab's freelist and
> + *   counters, otherwise slab_lock is taken. This only needs to take the
> + *   list_lock if it's a first free to a full slab, or when there are too many
> + *   fully free slabs and some need to be discarded.

nit: "or when a slab becomes empty after the free"?
because we don't check nr_partial before acquiring list_lock.

With that addressed,
Reviewed-by: Harry Yoo <harry.yoo@oracle.com>

-- 
Cheers,
Harry / Hyeonggon

  parent reply	other threads:[~2026-01-22  6:41 UTC|newest]

Thread overview: 106+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-16 14:40 [PATCH v3 00/21] slab: replace cpu (partial) slabs with sheaves Vlastimil Babka
2026-01-16 14:40 ` [PATCH v3 01/21] mm/slab: add rcu_barrier() to kvfree_rcu_barrier_on_cache() Vlastimil Babka
2026-01-16 14:40 ` [PATCH v3 02/21] slab: add SLAB_CONSISTENCY_CHECKS to SLAB_NEVER_MERGE Vlastimil Babka
2026-01-16 17:22   ` Suren Baghdasaryan
2026-01-19  3:41   ` Harry Yoo
2026-01-16 14:40 ` [PATCH v3 03/21] mm/slab: move and refactor __kmem_cache_alias() Vlastimil Babka
2026-01-16 14:40 ` [PATCH v3 04/21] mm/slab: make caches with sheaves mergeable Vlastimil Babka
2026-01-16 14:40 ` [PATCH v3 05/21] slab: add sheaves to most caches Vlastimil Babka
2026-01-20 18:47   ` Breno Leitao
2026-01-21  8:12     ` Vlastimil Babka
2026-01-16 14:40 ` [PATCH v3 06/21] slab: introduce percpu sheaves bootstrap Vlastimil Babka
2026-01-17  2:11   ` Suren Baghdasaryan
2026-01-19  3:40     ` Harry Yoo
2026-01-19  9:13       ` Vlastimil Babka
2026-01-19  9:34     ` Vlastimil Babka
2026-01-21 10:52     ` Vlastimil Babka
2026-01-19 11:32   ` Hao Li
2026-01-21 10:54     ` Vlastimil Babka
2026-01-16 14:40 ` [PATCH v3 07/21] slab: make percpu sheaves compatible with kmalloc_nolock()/kfree_nolock() Vlastimil Babka
2026-01-18 20:45   ` Suren Baghdasaryan
2026-01-19  4:31   ` Harry Yoo
2026-01-19 10:09     ` Vlastimil Babka
2026-01-19 10:23       ` Vlastimil Babka
2026-01-19 12:06         ` Hao Li
2026-01-16 14:40 ` [PATCH v3 08/21] slab: handle kmalloc sheaves bootstrap Vlastimil Babka
2026-01-19  5:23   ` Harry Yoo
2026-01-20  1:04   ` Hao Li
2026-01-16 14:40 ` [PATCH v3 09/21] slab: add optimized sheaf refill from partial list Vlastimil Babka
2026-01-19  6:41   ` Harry Yoo
2026-01-19  8:02     ` Harry Yoo
2026-01-19 10:54     ` Vlastimil Babka
2026-01-20  1:41       ` Harry Yoo
2026-01-20  9:32         ` Hao Li
2026-01-20 10:22           ` Harry Yoo
2026-01-20  2:32   ` Harry Yoo
2026-01-20  6:33     ` Vlastimil Babka
2026-01-20 10:27       ` Harry Yoo
2026-01-20 10:32         ` Vlastimil Babka
2026-01-20  2:55   ` Hao Li
2026-01-20 17:19   ` Suren Baghdasaryan
2026-01-21 13:22     ` Vlastimil Babka
2026-01-21 16:12       ` Suren Baghdasaryan
2026-01-16 14:40 ` [PATCH v3 10/21] slab: remove cpu (partial) slabs usage from allocation paths Vlastimil Babka
2026-01-20  4:20   ` Harry Yoo
2026-01-20  8:36   ` Hao Li
2026-01-20 18:06   ` Suren Baghdasaryan
2026-01-21 13:56     ` Vlastimil Babka
2026-01-16 14:40 ` [PATCH v3 11/21] slab: remove SLUB_CPU_PARTIAL Vlastimil Babka
2026-01-20  5:24   ` Harry Yoo
2026-01-20 12:10   ` Hao Li
2026-01-20 22:25   ` Suren Baghdasaryan
2026-01-21  0:58     ` Harry Yoo
2026-01-21  1:06       ` Harry Yoo
2026-01-21 16:21       ` Suren Baghdasaryan
2026-01-21 14:22     ` Vlastimil Babka
2026-01-21 14:43       ` Vlastimil Babka
2026-01-21 16:22       ` Suren Baghdasaryan
2026-01-16 14:40 ` [PATCH v3 12/21] slab: remove the do_slab_free() fastpath Vlastimil Babka
2026-01-20  5:35   ` Harry Yoo
2026-01-20 12:29   ` Hao Li
2026-01-21 16:57     ` Suren Baghdasaryan
2026-01-16 14:40 ` [PATCH v3 13/21] slab: remove defer_deactivate_slab() Vlastimil Babka
2026-01-20  5:47   ` Harry Yoo
2026-01-20  9:35   ` Hao Li
2026-01-21 17:11     ` Suren Baghdasaryan
2026-01-16 14:40 ` [PATCH v3 14/21] slab: simplify kmalloc_nolock() Vlastimil Babka
2026-01-20 12:06   ` Hao Li
2026-01-21 17:39     ` Suren Baghdasaryan
2026-01-22  1:53   ` Harry Yoo
2026-01-22  8:16     ` Vlastimil Babka
2026-01-22  8:34       ` Harry Yoo
2026-01-16 14:40 ` [PATCH v3 15/21] slab: remove struct kmem_cache_cpu Vlastimil Babka
2026-01-20 12:40   ` Hao Li
2026-01-21 14:29     ` Vlastimil Babka
2026-01-21 17:54       ` Suren Baghdasaryan
2026-01-21 19:03         ` Vlastimil Babka
2026-01-22  3:10   ` Harry Yoo
2026-01-16 14:40 ` [PATCH v3 16/21] slab: remove unused PREEMPT_RT specific macros Vlastimil Babka
2026-01-21  6:42   ` Hao Li
2026-01-21 17:57     ` Suren Baghdasaryan
2026-01-22  3:50   ` Harry Yoo
2026-01-16 14:40 ` [PATCH v3 17/21] slab: refill sheaves from all nodes Vlastimil Babka
2026-01-21 18:30   ` Suren Baghdasaryan
2026-01-22  4:44   ` Harry Yoo
2026-01-22  8:37     ` Vlastimil Babka
2026-01-22  4:58   ` Hao Li
2026-01-22  8:32     ` Vlastimil Babka
2026-01-22  7:02   ` Harry Yoo
2026-01-22  8:42     ` Vlastimil Babka
2026-01-16 14:40 ` [PATCH v3 18/21] slab: update overview comments Vlastimil Babka
2026-01-21 20:58   ` Suren Baghdasaryan
2026-01-22  3:54   ` Hao Li
2026-01-22  6:41   ` Harry Yoo [this message]
2026-01-22  8:49     ` Vlastimil Babka
2026-01-16 14:40 ` [PATCH v3 19/21] slab: remove frozen slab checks from __slab_free() Vlastimil Babka
2026-01-22  0:54   ` Suren Baghdasaryan
2026-01-22  6:31     ` Vlastimil Babka
2026-01-22  5:01   ` Hao Li
2026-01-16 14:40 ` [PATCH v3 20/21] mm/slub: remove DEACTIVATE_TO_* stat items Vlastimil Babka
2026-01-22  0:58   ` Suren Baghdasaryan
2026-01-22  5:17   ` Hao Li
2026-01-16 14:40 ` [PATCH v3 21/21] mm/slub: cleanup and repurpose some " Vlastimil Babka
2026-01-22  2:35   ` Suren Baghdasaryan
2026-01-22  9:30     ` Vlastimil Babka
2026-01-22  5:52   ` Hao Li
2026-01-22  9:30     ` Vlastimil Babka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aXHGfLV6FdlNPc14@hyeyoo \
    --to=harry.yoo@oracle.com \
    --cc=Liam.Howlett@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=ast@kernel.org \
    --cc=bigeasy@linutronix.de \
    --cc=bpf@vger.kernel.org \
    --cc=cl@gentwo.org \
    --cc=hao.li@linux.dev \
    --cc=kasan-dev@googlegroups.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-rt-devel@lists.linux.dev \
    --cc=ptesarik@suse.com \
    --cc=rientjes@google.com \
    --cc=roman.gushchin@linux.dev \
    --cc=surenb@google.com \
    --cc=urezki@gmail.com \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.