Re: [PATCH 3/4] ASoC: pxa2xx-ac97: Remove platform_data

[Andy Shevchenko <andriy.shevchenko@intel.com>]

On Thu, Jan 22, 2026 at 08:44:59PM +0800, Peng Fan (OSS) wrote:

> Since commit d6df7df7ae5a0 ("ARM: pxa: remove unused board files"), there
> has been no in-tree user to create the device with platform data. So remove
> them.

I like the changes for PXA27x, but one important comment below.

...

> +	if (dev->dev.of_node) {
> +		reset_gpio = of_get_named_gpio(dev->dev.of_node, "reset-gpios", 0);
> +		if (reset_gpio == -ENOENT)
> +			reset_gpio = -1;
> +		else if (reset_gpio < 0)
> +			return reset_gpio;

No, please convert to devm_gpiod_get*() or even better to use reset-gpio driver.
TL;DR: no (reinstantiated) of_get_named_gpio() or alike must be in the kernel.

>  	} else {
>  		if (cpu_is_pxa27x())
>  			reset_gpio = 113;

-- 
With Best Regards,
Andy Shevchenko