All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andi Shyti <andi.shyti@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
	 Mika Westerberg <mika.westerberg@linux.intel.com>,
	Jan Dabros <jsd@semihalf.com>
Subject: Re: [PATCH v1 2/2] i2c: designware: Use device_is_compatible() instead of custom approach
Date: Thu, 22 Jan 2026 12:10:48 +0100	[thread overview]
Message-ID: <aXIDQtLlzYvbJSGV@zenone.zhora.eu> (raw)
In-Reply-To: <20260114081954.252160-3-andriy.shevchenko@linux.intel.com>

Hi,

On Wed, Jan 14, 2026 at 09:17:51AM +0100, Andy Shevchenko wrote:
> We use MODEL_MSCC_OCELOT effectively is a flag for comparing against
> "compatible" property. Use device_is_compatible() directly to make it
> clear.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

I'm coming into the discussion and I personally like Andy's
approach. As a third party, I believe this patch has reached the
consensus and I'm taking it in i2c/i2c-host.

Thanks Andy,
Andi

  parent reply	other threads:[~2026-01-22 11:10 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-14  8:17 [PATCH v1 0/2] i2c: designware: Clean up MODEL_* definitions Andy Shevchenko
2026-01-14  8:17 ` [PATCH v1 1/2] i2c: designware: Remove not-going-to-be-supported code for Baikal SoC Andy Shevchenko
2026-01-14 11:50   ` Mika Westerberg
2026-01-15 15:23   ` Andi Shyti
2026-01-14  8:17 ` [PATCH v1 2/2] i2c: designware: Use device_is_compatible() instead of custom approach Andy Shevchenko
2026-01-14 11:53   ` Mika Westerberg
2026-01-14 16:09     ` Andy Shevchenko
2026-01-15  5:39       ` Mika Westerberg
2026-01-15  7:41         ` Andy Shevchenko
2026-01-15 10:06           ` Mika Westerberg
2026-01-22 11:10   ` Andi Shyti [this message]
2026-01-22 11:49     ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aXIDQtLlzYvbJSGV@zenone.zhora.eu \
    --to=andi.shyti@kernel.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=jsd@semihalf.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mika.westerberg@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.