From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: abdurrahman@nexthop.ai
Cc: Michal Simek <michal.simek@amd.com>,
Andi Shyti <andi.shyti@kernel.org>,
linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 5/5] i2c: xiic: minor cosmetic cleanup
Date: Fri, 23 Jan 2026 10:28:07 +0200 [thread overview]
Message-ID: <aXMxF45gX1qS-CeU@smile.fi.intel.com> (raw)
In-Reply-To: <20260123-i2c-xiic-v3-5-eb7cd4254dfb@nexthop.ai>
On Fri, Jan 23, 2026 at 08:02:48AM +0000, Abdurrahman Hussain via B4 Relay wrote:
>
> Add a temporary dev variable and reuse it instead of referencing pdev->dev
> everywhere.
...
> + struct device *dev = &pdev->dev;
No, this part should go earlier because of other patches that use it.
devm_clk_get*()
device_get_match_data()
Without this you add an unneeded churn.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-01-23 8:28 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-23 8:02 [PATCH v3 0/5] i2c: xiic: use generic device property accessors Abdurrahman Hussain
2026-01-23 8:02 ` Abdurrahman Hussain via B4 Relay
2026-01-23 8:02 ` [PATCH v3 1/5] i2c: xiic: make the clock optional Abdurrahman Hussain
2026-01-23 8:02 ` Abdurrahman Hussain via B4 Relay
2026-01-23 8:29 ` Andy Shevchenko
2026-01-23 19:20 ` Andrew Lunn
2026-01-23 19:56 ` Abdurrahman Hussain
2026-01-23 8:02 ` [PATCH v3 2/5] i2c: xiic: switch to managed version of mutex_init Abdurrahman Hussain
2026-01-23 8:02 ` Abdurrahman Hussain via B4 Relay
2026-01-23 8:30 ` Andy Shevchenko
2026-01-23 19:22 ` Andrew Lunn
2026-01-23 20:20 ` Abdurrahman Hussain
2026-01-23 21:36 ` Andrew Lunn
2026-01-23 22:25 ` Abdurrahman Hussain
2026-01-23 8:02 ` [PATCH v3 3/5] i2c: xiic: remove duplicate error message Abdurrahman Hussain
2026-01-23 8:02 ` Abdurrahman Hussain via B4 Relay
2026-01-23 19:23 ` Andrew Lunn
2026-01-23 8:02 ` [PATCH v3 4/5] i2c: xiic: switch to generic device property accessors Abdurrahman Hussain
2026-01-23 8:02 ` Abdurrahman Hussain via B4 Relay
2026-01-23 8:33 ` Andy Shevchenko
2026-01-23 8:02 ` [PATCH v3 5/5] i2c: xiic: minor cosmetic cleanup Abdurrahman Hussain
2026-01-23 8:02 ` Abdurrahman Hussain via B4 Relay
2026-01-23 8:28 ` Andy Shevchenko [this message]
2026-01-23 8:37 ` Andy Shevchenko
2026-01-23 8:31 ` [PATCH v3 0/5] i2c: xiic: use generic device property accessors Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aXMxF45gX1qS-CeU@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=abdurrahman@nexthop.ai \
--cc=andi.shyti@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.