Re: [PATCH] i386/cpu: Fix unexpected initializer override in CPU model definition for Diamond Rapids

[Zhao Liu <zhao1.liu@intel.com>]

(Cc Maintainer Paolo)

On Tue, Jan 13, 2026 at 12:43:56PM -0400, Aidan Khoury wrote:
> Date: Tue, 13 Jan 2026 12:43:56 -0400
> From: Aidan Khoury <aidan@aktech.ai>
> Subject: [PATCH] i386/cpu: Fix unexpected initializer override in CPU model
>  definition for Diamond Rapids
> X-Mailer: git-send-email 2.43.0
> 
> The new Diamond Rapids x86 cpu model definition that was added in 7a6dd8bde159 has an unexpected comma in
> the `.features[FEAT_VMX_EXIT_CTLS]` subobject initializer causing the prior initialization to be overridden,
> meaning that `VMX_VM_EXIT_SAVE_DEBUG_CONTROLS | VMX_VM_EXIT_HOST_ADDR_SPACE_SIZE` is not included.
> 
> Fix this by replacing the comma with the missing bitwise OR to properly combine all the flags into a single
> bitmask value.
> 
> Fixes: 7a6dd8bde159 ("i386/cpu: Add CPU model for Diamond Rapids")
> Signed-off-by: Aidan Khoury <aidan@aktech.ai>
> ---
>  target/i386/cpu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Thank you and my bad,

Reviewed-by: Zhao Liu <zhao1.liu@intel.com>

BTW, just curious, what warning did you meet? I can make some
improvements.

Thanks,
Zhao